Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp38034588rwd; Wed, 12 Jul 2023 01:56:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlGMmVF0v5kFGbY7TtrkPW0rhEstpNZ31ZaV2O71mDvbg5ZEsjjeaKza/k+0/Gu0CtgzOQXs X-Received: by 2002:ac8:5c01:0:b0:403:2dfd:1fdf with SMTP id i1-20020ac85c01000000b004032dfd1fdfmr22928792qti.23.1689152173017; Wed, 12 Jul 2023 01:56:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689152172; cv=none; d=google.com; s=arc-20160816; b=oQ1VN+jcyhoA1amNZKX7LbC5utebA7trqsGoE8vc5fe2+phq1H2rN+AuGil0qqkXPA 6HgSX7A+zq3CVtLbBfrpLxDFWNchMntbObXozbGASm2C2VGB0K46a5EVtLtWxoHEZlWB D1DmwAJxhD9a0VWx39G4p48GyOqzkbMauS+RcN0zK1Cm67HwvnY8V8uZHemE2no0Nzu7 ypLtkRvhXsmCcc1XjmwQDOOuz6XlMMVzquJrt/x77R+y2kzSE6mRxjc72M21WSLrSonz wd9q0GB63pGEgGIVLk5zJXd3tq2ap/eaw7omlXZpk2sL4dqYtYxGySi1Rsg7RZ+pUHFj pThQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nnUTLIL0q5cp0wnb92sRVYY4FT+Dnttj2HcH5bm540c=; fh=k7XzfpyqnKqnwxpqVF0NftrWa2FIpeAcHVbykF5xarA=; b=j67IWuZlAPz9H6wYQfdRsRrcKFTB9u5E7M9QqYy6PW90qL3HU6y8PyxJnwaLIrIXGv PO9/3R00uSiVxBByCIx2ODqNAhQrHMlCNcd+AIoAxSQGrboaegbktKbTYZLDfCMFYhvs Ufb7eWb/F704lwSPvk4dCGa5sNxJA00DW5V4x4aH+3tLJgt4AG30iRS8T8bsnfL2jUF6 1V3WyNvC7D3D+hhultQLVDMYh16V/1tvYFKjYK+kh0jkYudNsKvEPpQ5+UJMzHL31e9L MMenYWsiE81dnAV/mMV6X7Qzem3i79Gz0D6xhKB1Ealzv9m9v6zrV6ma5hyvOIv7e7FW Ataw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RJXJcRTD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020a17090301cd00b001b8698d619asi3087293plh.602.2023.07.12.01.56.00; Wed, 12 Jul 2023 01:56:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RJXJcRTD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232052AbjGLIXt (ORCPT + 99 others); Wed, 12 Jul 2023 04:23:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbjGLIWr (ORCPT ); Wed, 12 Jul 2023 04:22:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A33564487; Wed, 12 Jul 2023 01:18:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E5D576168A; Wed, 12 Jul 2023 08:18:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42503C433CA; Wed, 12 Jul 2023 08:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689149896; bh=AnR6U7SNoPqjubiusL5iLkGLY4N6OAzOKEM7mQdl/ck=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RJXJcRTDyCjTcjykoHcORmeLIiu1SQyvAzuB4QGFcbkFmsOKaBWT14DIkRTZcBYOe OiNGq/2iwCvqCI2myJFdd3YiGV3kBEEuhSgqiNS6/BhYPjL+bCig/mYx7ORJXW6pHB AhU7nG5PSdR2szqpsUcTX6oYPS2Qzkg3vyDZ0/+eN3YE4pjaK8zM9jE2fUi9+SDXZG DPrzJ4mG+T00swI5yaVrhe4fBSzGqtPcUfjmyXA3N4m0ly6+I2lXoscsUF0we18lgn oZMVOx7woNKa0INW/EyaVe1kcW6de4PuI00eo6unr/MZ1M8ObVXhHmhjJNjWQmeXXW 66eUkeFC0umhw== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 01/10] tty: sysrq: rename and re-type i in sysrq_handle_loglevel() Date: Wed, 12 Jul 2023 10:18:02 +0200 Message-ID: <20230712081811.29004-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230712081811.29004-1-jirislaby@kernel.org> References: <20230712081811.29004-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'i' is a too generic name for something which carries a 'loglevel'. Name it as such and make it 'u8', the same as key will become in the next patches. Note that we are not stripping any high bits away, 'key' is given only 8bit values. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/sysrq.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index e1df63a88aac..13465e4cca9b 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c @@ -100,12 +100,11 @@ __setup("sysrq_always_enabled", sysrq_always_enabled_setup); static void sysrq_handle_loglevel(int key) { - int i; + u8 loglevel = key - '0'; - i = key - '0'; console_loglevel = CONSOLE_LOGLEVEL_DEFAULT; - pr_info("Loglevel set to %d\n", i); - console_loglevel = i; + pr_info("Loglevel set to %u\n", loglevel); + console_loglevel = loglevel; } static const struct sysrq_key_op sysrq_loglevel_op = { .handler = sysrq_handle_loglevel, -- 2.41.0