Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     =?UTF-8?q?Niklas=20S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>
Cc:     Yangtao Li <frank.li@vivo.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH 21/27] thermal/drivers/rcar_thermal: Convert to platform remove callback returning void
Date:   Wed, 12 Jul 2023 16:12:52 +0800
Message-Id: <20230712081258.29254-21-frank.li@vivo.com>
In-Reply-To: <20230712081258.29254-1-frank.li@vivo.com>
References: <20230712081258.29254-1-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3dtOHBxS1MxVmdmdHMzUXRlaURBYURUNStHRGlucGpnRW1nWUI5ZnJxa0do?=
 =?utf-8?B?TEJQYTJyZktuYThjcGhRSjllb0VzZ1ZVV2Y5WWFQbUJZOUszdG9yeVpLaFJm?=
 =?utf-8?B?aVYzUVJaZUpmLzYrNjM4VHB5VEZFUWI1bWlnbEFKNGZ0R2FpdFk3QTBkdWp1?=
 =?utf-8?B?S1BucURSTjFSYkhYM2NETXVSOUtYWXZRbUdTQTlSeGtubVV3MU9FSWRWamxV?=
 =?utf-8?B?WStoQVNDK3g0d3k4R2tmM3Bidjd1aDArQzF1OWpxZDloVDFnSkI3OXc3dlNq?=
 =?utf-8?B?d3RxNDJxcnFEL3ZZSVdQdFN4MENiTm1MUXFCNlludjZPN3lmVG9TNktKQzZL?=
 =?utf-8?B?YlFDdVk0czNsbjltN0FsWXUzeWdvL2RPS1p2MUVwZ2tMNGY3S0FMM3FXZHlN?=
 =?utf-8?B?S2dEWWoxTjdZNmhkOXlhYzByZ29OTGJzdzZGMnlJSlNIRnhxK0ZrNG4vVzZq?=
 =?utf-8?B?alhZT1daNlRSdWlySFpUeVpweDY5RWh5MldqNEh5TnU2YzFTWkpxS2NkbGxz?=
 =?utf-8?B?emhwWUo0U3ltYS9pOW5saU91L095bzBvTmY5NkNEUDIwd0dOdGx4ZFh1R0FS?=
 =?utf-8?B?enF3bDB6MThkUDZJSWZobU9ramJCYWR1Q2QvdndMdmFiaWw5bFRxZGI4azVj?=
 =?utf-8?B?ZzRXbXp4a2FVS1krTzhDNFFURTFubW1SRS9jekdwa0F1L3grU0pjajM5dkdJ?=
 =?utf-8?B?VmFKQXFnRk9wS0xKajFHUWc3NTUyd2VEWlFWS04wUnpOZGpDMkoxYmF2TXl4?=
 =?utf-8?B?eTVCeVVuaG5EWEs1cURBWm0zbE80Qld3VmJIb0IyQ1VRbkJMcHZVMWRqYUdy?=
 =?utf-8?B?SnhPdUttWW9WcE45c0EzWk4yTzJGVFFlNVEyK2RGTUtnNFpYcUZWb0RqS3Qv?=
 =?utf-8?B?Nmg2cVVKS1B1aXEzaWxUTllqTHRVSmFROXFONTV0bDhtRXdqZTVTT1AvTnFS?=
 =?utf-8?B?L1pWbUEyakNmSEU1VEhKOWVqV05MMExPemorU1VrdmFpS1ZKdTJxOVNWU0tB?=
 =?utf-8?B?bkhRMk01SGU2RzcwWHNBc1ZtT1dqN1JDdnpLN0xXK1VRQWp6aHlnMFd1Wllt?=
 =?utf-8?B?SmVKaVFRN0FBQTBPTmN3cTRBMSthL2FBV2xGeU1jRzNwMm1QUm1SWWxTSHcw?=
 =?utf-8?B?SzNZcXRmTHprYjlYaVYzYUhaOSszNVNhSUR6K01uTm4vT0xSNk5WZmdtaC8v?=
 =?utf-8?B?Z1FkNHNYaUg2UXMxZjJFN0ZDbXVzbk0vOTVid0FHUXI3c3dWLzZtTGQzNHBk?=
 =?utf-8?B?QjlmM29tazJHK3V6OVp6Z1J1SU9CZ1BVVDM2V1dMaGJMd3YzTFA2QXdyUGoz?=
 =?utf-8?B?UktObVJjdCtzUTZPeXlEVTdoNlo3RnhxWkpTNzN0TWI0N3FyMVhlVUxzOG5U?=
 =?utf-8?B?TGltY1hZODVMeXJDSW9Wa3lKMnRhRW4xaXdDbGFIWjBEUFFXTkFsWnJVc25G?=
 =?utf-8?B?Q0txaC8vVVBNanV1WW5Cd2kycXMxaU1mbjNNQkg3SWxCeEFqMm9XL25yZmxv?=
 =?utf-8?B?VkJCRnROMEFZVHB3TGJaOTVqZVlpaFY3TGdlMGRYL0RyVHQ3K2JpQWxHN2pu?=
 =?utf-8?B?SDI1Yll2dHZvQi9tWlVOazU0d1dGVnEzNzBMb0YrL1ZKeCtvVDFNL09iTDcy?=
 =?utf-8?B?WUpIV1FHQTExMloxMkp0ZHptbWNiTllubEhZWTJZOWJ4Z3ljMEJneFU0dkhS?=
 =?utf-8?B?ckVhVERxd1pDK2RsbVNRMFFyVUJZMnl1MXN4dzFkeTBKNnFoeXBmUGJCMWti?=
 =?utf-8?B?UWVXVlZPWUNtWlJYUEJmVXZoRzVLNjN6bzY0RHlTaUxrNU45bzhBeVZpSlND?=
 =?utf-8?B?V244dmtoQmNXSU9obDJhWHNsc3o4dzB1Q0RaKytlR2FneE5kTmdlSHdqOXd3?=
 =?utf-8?B?QjFDUGtOZ3pqR0tyREpNalI0TjJRa3dBalNRdkpVeithczBqVlgveXlKN29P?=
 =?utf-8?B?NnpLZ1J3RXF5QmRlQzdTWElQd0VLVEZFK2x3cHlyVmJZdy92bUNtTUtudWJj?=
 =?utf-8?B?ek9vU25QVjBmTXNWUTVHYnhiVC83TnZzS2lCVzJxRUlGZUNid3dIWm9ETFF6?=
 =?utf-8?B?azhLUGZMTmgxNXcwcHRmQkZJVWdLd0NybUVkZ1RBc25ZeUdDUnRpc2VzNmo3?=
 =?utf-8?Q?4tHyo9noa1bTRFYfA6/aZGj0r?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d0b128f-b9df-4228-7e7b-08db82b003df
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 08:14:29.5389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lq26VdSOYwJAvEAVYEkKk6nAvmL0S4NXogRzAZsVnBYcDB826147ACMpPaYelsLNIljjySmNRAhyFJVQ5ex6Rg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6524
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/thermal/rcar_thermal.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index b8571f7090aa..b4c58c5f6f6d 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -371,7 +371,7 @@ static irqreturn_t rcar_thermal_irq(int irq, void *data)
 /*
  *		platform functions
  */
-static int rcar_thermal_remove(struct platform_device *pdev)
+static void rcar_thermal_remove(struct platform_device *pdev)
 {
 	struct rcar_thermal_common *common = platform_get_drvdata(pdev);
 	struct device *dev = &pdev->dev;
@@ -388,8 +388,6 @@ static int rcar_thermal_remove(struct platform_device *pdev)
 
 	pm_runtime_put(dev);
 	pm_runtime_disable(dev);
-
-	return 0;
 }
 
 static int rcar_thermal_probe(struct platform_device *pdev)
@@ -581,7 +579,7 @@ static struct platform_driver rcar_thermal_driver = {
 		.of_match_table = rcar_thermal_dt_ids,
 	},
 	.probe		= rcar_thermal_probe,
-	.remove		= rcar_thermal_remove,
+	.remove_new	= rcar_thermal_remove,
 };
 module_platform_driver(rcar_thermal_driver);
 
-- 
2.39.0