Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7dab9de-9014-720a-ac11-77d87e8231c5@amd.com>
Date:   Wed, 12 Jul 2023 10:43:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 2/6] drm/amdgpu: Mark contexts guilty for causing soft
 recoveries
Content-Language: en-US
To:     =?UTF-8?Q?Andr=c3=a9_Almeida?= <andrealmeid@igalia.com>,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     kernel-dev@igalia.com, alexander.deucher@amd.com,
        pierre-eric.pelloux-prayer@amd.com,
        =?UTF-8?B?J01hcmVrIE9sxaHDoWsn?= <maraeo@gmail.com>,
        Samuel Pitoiset <samuel.pitoiset@gmail.com>,
        Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>,
        =?UTF-8?Q?Timur_Krist=c3=b3f?= <timur.kristof@gmail.com>,
        michel.daenzer@mailbox.org,
        =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>
References: <20230711213501.526237-1-andrealmeid@igalia.com>
 <20230711213501.526237-3-andrealmeid@igalia.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230711213501.526237-3-andrealmeid@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTMvWUdweTNuTWg4M05tdkZOU3dGdmptR0ZxU2tWRlprK2JrSmhZOFdxcXdr?=
 =?utf-8?B?bVloeXJIc2VUNFJ4LzAvUkVwOThJeEpuRWRIbDBqdzZrc0dQMStIY3hyS2lY?=
 =?utf-8?B?SEhGWU9zeTJKQXlyMXF2R0xIdCsrMjJUUzJCa1pPb0xoaHh3TGNzdG5XdGwr?=
 =?utf-8?B?NyswT09HVGEzRmFDMEd4UnZuR2xFZ05oWkZEZGQvMGdXUEpLRS9nMi9NRFA3?=
 =?utf-8?B?UE5GdTJVVmtnVmQ3akdUNFBmWU1TaHdQa2ltMVRnR0xTMlE2c2F1dDJJd0Iy?=
 =?utf-8?B?M0hDaVVOZlhTS0Z1Y2tJdG03a01CeEgrZmdpb2QwdUFOdTY2L3JyUlJBVThZ?=
 =?utf-8?B?dTRudEdJR2R2VzlHb05wNmROWVBvajFWZ0FLMFkvRkNVY210V3dIYStPaHNX?=
 =?utf-8?B?Wld3Ry9Db3BWWnk1U3IrZ3lDVmFkZUtvSHZ2YmN0MEJMRis2Q3YwOENlM0JG?=
 =?utf-8?B?b1BzQ0xrYlVTUzVNZ2VhUXZpaTc5bVlUdUNlS1haWm5zN3RDWEdEc3pEQUJ6?=
 =?utf-8?B?V1NXRmtBeXVWTlZyOCszS1hhYXpvbHp4WmFvREJiSWpCTHJSajNyTnNzTmYz?=
 =?utf-8?B?bFVBU0xzeHJLUEZ1OGlTWWRRbm5ZM2paY1RZWFIrSHh5dnV3ZElsb2ltL2h0?=
 =?utf-8?B?RUVHWHVZbWRSZHBqY3ozNFZwZkNIOHhVK3hMLzVjVVBtWkU1UVVOV1FuMHU4?=
 =?utf-8?B?NUdGNEpOSFdNckZQemwzcDVoQVFhR1Z4Mk0zKzVWNzNtVlExL2ptMXlNejNI?=
 =?utf-8?B?dzFDSHdxWUZIUFZ2MFFqbTNodXVtTEdDRDNpVG8xUXIranVWb0NoVFRZUjJE?=
 =?utf-8?B?amFFc1ZGcDBualQ3NWlQNUdqZlNQbHpVMGJ6YjZqcU1tTjB4YVNsS0MralNZ?=
 =?utf-8?B?UmNYSTYyTGgxMVI4MTFOS2FLSFlCOFAyREFHbGJBaUY0UUpLMjZqbTFtRXMw?=
 =?utf-8?B?TTJnK3ppMkpuQ0pxL0YraVhERElCNEJDV2w0cTllUGFDaDdrZVFvOUtQQlJs?=
 =?utf-8?B?eHdsVTRLZXRVSk9kTXllVE9JUkNoVE1mZkRXZ3liSk9jNDBpaEtiYXBEMkxm?=
 =?utf-8?B?RlNncU5JRXlCSEhLMG1JQ2EwNnAyU21lb3ptRDRWMFFNOS81ZjNwdW5vTlgv?=
 =?utf-8?B?STU4UW9oczdLY3QweGpQNlg3MEJIZ25EdXYzam5lRGJXS3BTM0FaQW8rRnVY?=
 =?utf-8?B?enl3WlVycUlVdlp0WmY3bVlqMi90ekZ1UWErOVpaNWRwcE5JOVE1QnNDVGxP?=
 =?utf-8?B?U2JVVnNoTGFYRkFkUDd3UVUzNkliWll4Z1lpODVuRUp4eGFwMWJrcTRFVHhH?=
 =?utf-8?B?N3l6MysrNXBDMnA4UENJdEhyalZ4bDJTZ21ZNVVSK2RjM1k4bTh1SURtSFRB?=
 =?utf-8?B?RW5TNS9hVFVaaDBoa3dNUU10MFlXYnB5UGdLVTJoTHZ2SnhmeXltRWd1YkVH?=
 =?utf-8?B?cnd5TGJjT3dZOVFSajB6bGNaODdKeUxkbjdybFREd1g1alR4YU9nZUtBUmdD?=
 =?utf-8?B?dlBUWkMzTitUdWI2MUdtS3ArSFdjcG5QcUpsbEhuUk5HbmdZZ3U3LzdaSDN1?=
 =?utf-8?B?SHVKRWhiaHNmcHRJbCs2WUxLQmRHRXo5dXZML1Nta2VUTm4rWlgyNEFMRmZN?=
 =?utf-8?B?Y2ZkQ1FFV2VHQlNJM200YmpOQy8vNDJFeDFuQVhPeDhVL1VDUkEyWlJaL3p2?=
 =?utf-8?B?Wm1zaC8xWkZiaVBmRncxc0I2enBQMlRJUjZkazAxZGo3bk52a2tDOHl3VDU1?=
 =?utf-8?B?TlI1d3pQRVRicElHcnY1OHpoU1EveVFYaHpmbzdpWmIxTHFGM1RqcXZPK0p0?=
 =?utf-8?B?ZC9LY3ZITXN5WXkvcmNkczdVcStVdDNOWEl3QkJ4VDVSYTdmKzBsYktLM0o5?=
 =?utf-8?B?cjE1RVRIa1BPZ00rYkxSbkdGMWFsNEh1VU5KalhNZ0lIcjVRa1VHU09ORlIy?=
 =?utf-8?B?T2x1Ri9Kb0V1Vk5rRXY5ZkJ5OTFFeEIvTUJFT3I4cUE1UkxIUGRvOXlPOEhP?=
 =?utf-8?B?c1JFNjZMSm1MbmtvMTdVVUlRVTg0TzhkM1VoOUlqQzQwWVp0S2U3WDNuc3V0?=
 =?utf-8?B?SHpsTnRWOEIvakRsdXpYZGF6TVlaNldFcjloNzFsSklpUG5JZjdObEZwUzZw?=
 =?utf-8?B?UVJTMmRtQWdESG5vNTRyU2RDcDhSQ004M3kvS2c5Y0RQclY1ZWt4N0MvKzZM?=
 =?utf-8?Q?sqT+jODTNxqO1OaYaUf3gRfUmuL2CAVflTGaXwJE+6ov?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d603c08b-b651-49c7-5695-08db82b40f3b
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 08:43:26.6627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rq9dSS1HrYD4qt3zmdrJhftkh86uX12URap/PxV5ZwyXzqhOhtlGCztxj1sVakj9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8402
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 11.07.23 um 23:34 schrieb André Almeida:
> If a DRM fence is set to -ENODATA, that means that this context was a
> cause of a soft reset, but is never marked as guilty. Flag it as guilty
> and log to user that this context won't accept more submissions.
>
> Signed-off-by: André Almeida <andrealmeid@igalia.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> index 0dc9c655c4fb..fe8e47d063da 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> @@ -459,6 +459,12 @@ int amdgpu_ctx_get_entity(struct amdgpu_ctx *ctx, u32 hw_ip, u32 instance,
>   	ctx_entity = &ctx->entities[hw_ip][ring]->entity;
>   	r = drm_sched_entity_error(ctx_entity);
>   	if (r) {
> +		if (r == -ENODATA) {
> +			DRM_ERROR("%s (%d) context caused a reset,"
> +				  "marking it guilty and refusing new submissions.\n",
> +				  current->comm, current->pid);
> +			atomic_set(&ctx->guilty, 1);
> +		}

I'm going back and forth with that as well.

Michel has a very good point that it often is sufficient to cancel just 
one rough shader to keep going.

But Marek has a very good point as well that when that happens multiple 
times we probably want to block the application from making further 
submissions.

Christian.

>   		DRM_DEBUG("error entity %p\n", ctx_entity);
>   		return r;
>   	}