Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v1] riscv: dts: renesas: clean up dtbs_check W=1 warning
 due to empty phy node
To:     Conor Dooley <conor.dooley@microchip.com>, geert+renesas@glider.be
Cc:     conor@kernel.org, Magnus Damm <magnus.damm@gmail.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230712-squealer-walmart-9587342ddec1@wendy>
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
Message-ID: <18871eff-f2be-9eed-ee4c-99eba87686d8@gmail.com>
Date:   Wed, 12 Jul 2023 11:43:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20230712-squealer-walmart-9587342ddec1@wendy>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello!

On 7/12/23 11:14 AM, Conor Dooley wrote:

> dtbs_check w/ W=1 complains:
> Warning (unit_address_vs_reg): /soc/ethernet@11c20000/ethernet-phy@7: node has a unit name, but no reg or ranges property
> Warning (avoid_unnecessary_addr_size): /soc/ethernet@11c20000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> The ethernet@11c20000 node is guarded by an `#if (!SW_ET0_EN_N)` in
> rzg2ul-smarc-som.dtsi, where the phy child node is added. In
> rzfive-smarc-som.dtsi, the ethernet node is marked disabled & the
> interrupt properties are deleted from the phy child node. As a result,
> the produced dts looks like:
> 	ethernet@11c20000 {
> 		compatible = "renesas,r9a07g043-gbeth\0renesas,rzg2l-gbeth";
> 		/* snip */
> 		#address-cells = <0x01>;
> 		#size-cells = <0x00>;
> 		status = "disabled";
> 
> 		ethernet-phy@7 {
> 		};
> 	};
> 
> Adding a corresponding `#if (!SW_ET0_EN_N)` around the node in
> rzfive-smarc-som.dtsi avoids the complaint, as the empty child node is
> not added:
> 	ethernet@11c20000 {
> 		compatible = "renesas,r9a07g043-gbeth\0renesas,rzg2l-gbeth";
> 		/* snip */
> 		#address-cells = <0x01>;
> 		#size-cells = <0x00>;
> 		status = "disabled";
> 	};
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
[...]

> diff --git a/arch/riscv/boot/dts/renesas/rzfive-smarc-som.dtsi b/arch/riscv/boot/dts/renesas/rzfive-smarc-som.dtsi
> index d6f18754eb5d..c62debc7ca7e 100644
> --- a/arch/riscv/boot/dts/renesas/rzfive-smarc-som.dtsi
> +++ b/arch/riscv/boot/dts/renesas/rzfive-smarc-som.dtsi
> @@ -22,6 +22,7 @@ &dmac {
>  	status = "disabled";
>  };
>  
> +#if (!SW_ET0_EN_N)

   Are the parens really needed here?

>  &eth0 {
>  	status = "disabled";
>  
[...]

MBR, Sergey