Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230712-squealer-walmart-9587342ddec1@wendy> <18871eff-f2be-9eed-ee4c-99eba87686d8@gmail.com>
In-Reply-To: <18871eff-f2be-9eed-ee4c-99eba87686d8@gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 12 Jul 2023 11:13:43 +0200
Message-ID: <CAMuHMdX00X=L387jSrP_mZo04u0zkU8V6-g13Y2urrU1cRgS-A@mail.gmail.com>
Subject: Re: [PATCH v1] riscv: dts: renesas: clean up dtbs_check W=1 warning
 due to empty phy node
To:     Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc:     Conor Dooley <conor.dooley@microchip.com>, conor@kernel.org,
        Magnus Damm <magnus.damm@gmail.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Sergei.

On Wed, Jul 12, 2023 at 10:43 AM Sergei Shtylyov
<sergei.shtylyov@gmail.com> wrote:
> On 7/12/23 11:14 AM, Conor Dooley wrote:
>
> > dtbs_check w/ W=1 complains:
> > Warning (unit_address_vs_reg): /soc/ethernet@11c20000/ethernet-phy@7: node has a unit name, but no reg or ranges property
> > Warning (avoid_unnecessary_addr_size): /soc/ethernet@11c20000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> >
> > The ethernet@11c20000 node is guarded by an `#if (!SW_ET0_EN_N)` in
> > rzg2ul-smarc-som.dtsi, where the phy child node is added. In
> > rzfive-smarc-som.dtsi, the ethernet node is marked disabled & the
> > interrupt properties are deleted from the phy child node. As a result,
> > the produced dts looks like:
> >       ethernet@11c20000 {
> >               compatible = "renesas,r9a07g043-gbeth\0renesas,rzg2l-gbeth";
> >               /* snip */
> >               #address-cells = <0x01>;
> >               #size-cells = <0x00>;
> >               status = "disabled";
> >
> >               ethernet-phy@7 {
> >               };
> >       };
> >
> > Adding a corresponding `#if (!SW_ET0_EN_N)` around the node in
> > rzfive-smarc-som.dtsi avoids the complaint, as the empty child node is
> > not added:
> >       ethernet@11c20000 {
> >               compatible = "renesas,r9a07g043-gbeth\0renesas,rzg2l-gbeth";
> >               /* snip */
> >               #address-cells = <0x01>;
> >               #size-cells = <0x00>;
> >               status = "disabled";
> >       };
> >
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> [...]
>
> > diff --git a/arch/riscv/boot/dts/renesas/rzfive-smarc-som.dtsi b/arch/riscv/boot/dts/renesas/rzfive-smarc-som.dtsi
> > index d6f18754eb5d..c62debc7ca7e 100644
> > --- a/arch/riscv/boot/dts/renesas/rzfive-smarc-som.dtsi
> > +++ b/arch/riscv/boot/dts/renesas/rzfive-smarc-som.dtsi
> > @@ -22,6 +22,7 @@ &dmac {
> >       status = "disabled";
> >  };
> >
> > +#if (!SW_ET0_EN_N)
>
>    Are the parens really needed here?

No they aren't. But this follows the existing style of the other users.

>
> >  &eth0 {
> >       status = "disabled";
> >
> [...]

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds