Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230712-squealer-walmart-9587342ddec1@wendy>
In-Reply-To: <20230712-squealer-walmart-9587342ddec1@wendy>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 12 Jul 2023 11:12:28 +0200
Message-ID: <CAMuHMdWzHSPRjJRyj0BWEBD6t6MMmRSzkbu9coGZS4bcd8yEjA@mail.gmail.com>
Subject: Re: [PATCH v1] riscv: dts: renesas: clean up dtbs_check W=1 warning
 due to empty phy node
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     conor@kernel.org, Magnus Damm <magnus.damm@gmail.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Jul 12, 2023 at 10:15 AM Conor Dooley
<conor.dooley@microchip.com> wrote:
> dtbs_check w/ W=1 complains:
> Warning (unit_address_vs_reg): /soc/ethernet@11c20000/ethernet-phy@7: node has a unit name, but no reg or ranges property
> Warning (avoid_unnecessary_addr_size): /soc/ethernet@11c20000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> The ethernet@11c20000 node is guarded by an `#if (!SW_ET0_EN_N)` in
> rzg2ul-smarc-som.dtsi, where the phy child node is added. In
> rzfive-smarc-som.dtsi, the ethernet node is marked disabled & the
> interrupt properties are deleted from the phy child node. As a result,
> the produced dts looks like:
>         ethernet@11c20000 {
>                 compatible = "renesas,r9a07g043-gbeth\0renesas,rzg2l-gbeth";
>                 /* snip */
>                 #address-cells = <0x01>;
>                 #size-cells = <0x00>;
>                 status = "disabled";
>
>                 ethernet-phy@7 {
>                 };
>         };
>
> Adding a corresponding `#if (!SW_ET0_EN_N)` around the node in
> rzfive-smarc-som.dtsi avoids the complaint, as the empty child node is
> not added:
>         ethernet@11c20000 {
>                 compatible = "renesas,r9a07g043-gbeth\0renesas,rzg2l-gbeth";
>                 /* snip */
>                 #address-cells = <0x01>;
>                 #size-cells = <0x00>;
>                 status = "disabled";
>         };
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.6.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds