Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp38106921rwd; Wed, 12 Jul 2023 03:12:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlF8cJ7WfLuzg+iNS1k/zhWSF3+vJoioNj0sTowZTl1zQcMujw3ZMVVTVbF9M2cJEZyRR+AW X-Received: by 2002:a17:90a:f286:b0:263:1f1c:ef49 with SMTP id fs6-20020a17090af28600b002631f1cef49mr2008568pjb.13.1689156743297; Wed, 12 Jul 2023 03:12:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689156743; cv=none; d=google.com; s=arc-20160816; b=kSOvaktuVb1ih8/GA6su39hDtXbGBjRPJvoSZInJhnZBcBPmM3M/f1DkTl3A9VfmS0 Rg82kCCyfgmDncBV/2G8hCTJKRhX03qpVYR4ltQcT5EGuM097lCH7TjySgItYLNXYEfw hk2l4HnEP4oCM4nNyGHqiPGhGKtTQMwyVkucanAWvJOUwSu5oIZOhoBJIc5jOj2ERJi4 YvBKoqQ8JDPu75o5J5wkcRVsIUkhWyjCtXf4AcyAjRlrrSwew+v8GKOXzs1G3po8Uc11 Z79Zt5ifFjJZ6v1WwQ5S7eCUMnKoQYYBE+nUUAyDpXCXX3IsQOEimFX3y0Bd7p45hSkD 5ybA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=58xT+KMKS+Z2LsgPsKcaZ8yBZPaDFZE37ddgncPyqRA=; fh=S6uBPpUkJLzcUZQx3gJcJBkKS3t4HruG8RZGCxWLZ+c=; b=kNvZCRtT2NW7y8a0bjmea+wOnGcwZxkU87h2P9gvPcKoq3M0crJBpnlwlnZNZUg8Ix AVtTxXwMtgwLfG5yRmBro0g7RskYzK0O5ohOruwNeAuaw/v+Ft/Inc5GmANSZ74QcWrH pg7ZZr+J317OMGNg4f+v2YMibDIyZlp223HOfyjPHjE5oLiaUokEvLlryJDahbjiwR4g juyvDcsLC5LslblyuUp5AIZEgsXDp1cB4Y9Iz8ZkkrVwxbbEtE5ASZkzT5HAKhWDhaO0 fJCMI3AjAs3GDUQmavg0AxMaIH8Gm8SBnCib+vcN9JCysK6x7Jiju2V+VvqH38EcZMFy Tc7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kx14-20020a170902f94e00b001b9ea0f6c7csi2945160plb.540.2023.07.12.03.12.11; Wed, 12 Jul 2023 03:12:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232887AbjGLJ6H convert rfc822-to-8bit (ORCPT + 99 others); Wed, 12 Jul 2023 05:58:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232026AbjGLJ6G (ORCPT ); Wed, 12 Jul 2023 05:58:06 -0400 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B0271720; Wed, 12 Jul 2023 02:58:05 -0700 (PDT) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-5768a7e3adbso8595087b3.0; Wed, 12 Jul 2023 02:58:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689155884; x=1691747884; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y6MzudJP2Fu/sGdEnelPPluUqTi475Db7xeaDmuW9Sk=; b=LJrwQd7/GT/f6oIF/VO5++yTV31g4WJbSQ1fWlc/6aaAe0vQvJYr4kByUnVfNzoT7X 3q3FGJZT/6Z6RHfymi63tAJPT1EY2iwRa75CXHjS3Ot25+fRu84WDKLN9xUi8pxJQluj PwGyOtMkZiK8HKdqp2iAgC0FDJFT+heoiVo5a8pdlw7A+EuipACA1m7X08NZYQuLg/OD 4BH/kujvK/Db+8rFjpsFKMfyxPvqea1avTy6JQUB0jahhM9Itqqy49SgaLfGIPhGEnbL ljW/5yIUDSlUn4axOB9G4IApIlfDzHpZdHk/JMhE1rmohX36QxlmsHnsHGtr/7g1jdHD Kl4w== X-Gm-Message-State: ABy/qLY/EwIOYS6AZrz2ivULfQAnXCA21K/X7hfKfuI+kiyLNdahXYQ4 UHdcDF7kMwh4RmGN6+ZFK/Up2wQ6pmTPxA== X-Received: by 2002:a0d:d616:0:b0:573:284d:6476 with SMTP id y22-20020a0dd616000000b00573284d6476mr1711934ywd.1.1689155884332; Wed, 12 Jul 2023 02:58:04 -0700 (PDT) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com. [209.85.219.178]) by smtp.gmail.com with ESMTPSA id f67-20020a816a46000000b0057a93844c15sm1059234ywc.127.2023.07.12.02.58.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jul 2023 02:58:03 -0700 (PDT) Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-ca9804dc6e4so198576276.0; Wed, 12 Jul 2023 02:58:03 -0700 (PDT) X-Received: by 2002:a25:ae5d:0:b0:bd6:a97e:3597 with SMTP id g29-20020a25ae5d000000b00bd6a97e3597mr1632945ybe.30.1689155883328; Wed, 12 Jul 2023 02:58:03 -0700 (PDT) MIME-Version: 1.0 References: <20230511181931.869812-1-tj@kernel.org> <20230511181931.869812-7-tj@kernel.org> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 12 Jul 2023 11:57:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Consider switching to WQ_UNBOUND messages (was: Re: [PATCH v2 6/7] workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism) To: Tejun Heo Cc: Lai Jiangshan , "torvalds@linux-foundation.org" , Peter Zijlstra , Linux Kernel Mailing List , kernel-team@meta.com, Linux PM list , DRI Development , linux-rtc@vger.kernel.org, linux-riscv , netdev , Linux Fbdev development list , Linux MMC List , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On Wed, Jul 12, 2023 at 2:30 AM Tejun Heo wrote: > On Tue, Jul 11, 2023 at 11:39:17AM -1000, Tejun Heo wrote: > > On Tue, Jul 11, 2023 at 04:06:22PM +0200, Geert Uytterhoeven wrote: > > > On Tue, Jul 11, 2023 at 3:55 PM Geert Uytterhoeven wrote: > ... > > > workqueue: neigh_managed_work hogged CPU for >10000us 4 times, > > > consider switching to WQ_UNBOUND > > > > I wonder whether the right thing to do here is somehow scaling the threshold > > according to the relative processing power. It's difficult to come up with a > > threshold which works well across the latest & fastest and really tiny CPUs. > > I'll think about it some more but if you have some ideas, please feel free > > to suggest. > > Geert, do you mind posting the full kernel logs for the affected machines? https://drive.google.com/file/d/1toDs7ugZJ2eXatpdvySY4yxSsNam9xAC is an archive with boot and s2ram logs. Note that my kernels do contain local debug code, and may be noisy. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds