Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 12:14:45 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 06/27] thermal/drivers/mediatek/lvts_thermal: Convert to
 platform remove callback returning void
Message-ID: <20230712101445.bci4qkcf33wkr66d@pengutronix.de>
References: <20230712081258.29254-1-frank.li@vivo.com>
 <20230712081258.29254-6-frank.li@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bzvs6qosiovvxhrt"
Content-Disposition: inline
In-Reply-To: <20230712081258.29254-6-frank.li@vivo.com>
Precedence: bulk


--bzvs6qosiovvxhrt
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 12, 2023 at 04:12:37PM +0800, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Cc: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

While I like like you picking up the quest of converting drivers, I'd
like to have some coordination in place to not let us do duplicate work.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--bzvs6qosiovvxhrt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSufRQACgkQj4D7WH0S
/k5CGwf+J9LZL39gNGaKLsIHlIqVcOPuaffvlQEbuDPEk+NXzDuFe8zPPMp2Q47i
u53yJb74c9cR03QdbMMAmLI5Z348gpIamQtynQ7gHIwOrHNeY5cLRrdyXhrRVg5z
W7w9/KR+QlKenZogcWWIjoQHS2CHbQ8O4THEYn0SH6YIOfhT19vZtdz5DHSiH0xr
8FiJxXBzBBlpY+oGkLw58t0tkJCKlBj5AtR8LWWt320FiRPBgbGiNzfBvOaSXd5y
DWD+19p5HzYJkaKgtXmGKTOQ4DGS5zCHPxAK43BgNVguwma9ZM7baQjKnfv6AY3T
dZzKa7Yyfq6vuvAxHq4OgAIOyDnYdw==
=8PTH
-----END PGP SIGNATURE-----

--bzvs6qosiovvxhrt--