Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Santosh Shilimkar <ssantosh@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        linux-kernel@vger.kernel.org (open list:ARM/TEXAS INSTRUMENT KEYSTONE
        CLOCK FRAMEWORK),
        linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] drivers: clk: keystone: Fix parameter judgment in _of_pll_clk_init()
Date:   Wed, 12 Jul 2023 18:22:46 +0800
Message-Id: <20230712102246.10348-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+eZbbSC0m1XJCNWMa0wx0fw/ncXZg3yGoULe3o2In2jjVcDQqJHBgvBtufYr?=
 =?us-ascii?Q?Qu+ROdLIaqjVWJJ0l92yWr1j80CCnvbO4CRmhWQJ3crUAJvp0YVl0FviKrw5?=
 =?us-ascii?Q?yx3P3QCCIW9SLec9i5+Ou35H5aybTw2DmuKOMgyGmoj3kH5CCAfvgYSTlRsb?=
 =?us-ascii?Q?22fmfZLIePsV0qq8ZVjYlansSsBMQ5pavvCR5PUr7Umge01sXKH0SCkuk9QM?=
 =?us-ascii?Q?A/IheU2aBGLotdMhKfsWJFuyA5P5snymZcT+DAlw2+wGSclXrJFl7NCo/szB?=
 =?us-ascii?Q?RxDEuah8zMA3E5QzMFnS8TdID0LodKa50/ho/HPQB5k7HZqTeqIkpcWqGGPw?=
 =?us-ascii?Q?sPx0s2CiDSbD5fX81lQbmX/WV2dqiA47TLGl44VlCkn+r4Vu0CLlmqdikRGL?=
 =?us-ascii?Q?g/xqAmXeGGLg7dg9nQxIsn2fBfQIA4+kDIbqZgk8RCI4sb5qKpfP5TdaJw1h?=
 =?us-ascii?Q?KWMi7ZMqlxGoYXxVxs9lKpTmYba89eR94o20JolpA9jI9U7bxnnqBlsPJ86Q?=
 =?us-ascii?Q?dP7VEh/k9J9FrcyWfajAD7t5XP0qI85pGigMU3nBy6Lk+AqFipZJYGtPzrSL?=
 =?us-ascii?Q?27ht4yck1fVm7B8QsuC9nA5LmsdH9mcn6N9LkpRcoVACeXayi1XODZE5vCg4?=
 =?us-ascii?Q?bo/GPjd20zGii/2nOa/ASVlnVIn2edX2GA26OCJw74teTjLmpLHR8m2rx9Rw?=
 =?us-ascii?Q?xrnSvxuGJcHEd7uXEfneu/r46s2w36sbXPegBbvfTvxe3GxEk/0sBaRd1sSf?=
 =?us-ascii?Q?ArgWIzTrZwbjmX/I6u89Z4BhYLuAu+9C5+D6AW+HnsDnlkicsOJToCZVqTbI?=
 =?us-ascii?Q?W59TmclkMwSLT0A5GwWw2ayTyp3dxvi/KOzb/MHVtXOgj8n9DpA+o6gNj8x3?=
 =?us-ascii?Q?oivM3olkVeKXYg6x4EJjswLQ0v14yGDmeHdLG4gezwEvkkSh/DhhXMs/LO+H?=
 =?us-ascii?Q?AMKsIh6FNgtSQxfWqQNIJVGeRZ6F/ifu5QudawFPsHQ7b2WvVBlsVIeQ3I42?=
 =?us-ascii?Q?F4XhL3bc6txgsdlxTZWfr3VxIZViu3H6GbPNFU23b5USHdejA6nT/yLmlhnM?=
 =?us-ascii?Q?aEHRb7lX3PvzPaogEddpq0KpBS1k6dZ6Bj9P1eE6ieoxtTMqHFukF2iWFbU/?=
 =?us-ascii?Q?UnzLqo8+FluLZyhmsoeChT+PDjiDh3sUh5MOsIWFoTL2ThfHiSitAVZSy8Kj?=
 =?us-ascii?Q?y3nDsdLxXcipBH0s06KneAHgMf8j/sZZevKA1e/TQ/w9vt+hbAeMBFfDexbt?=
 =?us-ascii?Q?ukIIvP9sf5tiO+16MgkMLpWnPEF9Ns9c6SfeLpBpA20kCG67QSLGtr7Ysg0u?=
 =?us-ascii?Q?TOR7Z2gwgQgWqRMFpCG/AiqdEWaTvDq7lUM7rLuBV8vYJBTTx2XKVdoePr0V?=
 =?us-ascii?Q?yyNRghF/sAFg93DBEotsIzNQ5LMMYqG6rPuUk/GfBAnB0mgPD1Ad/Zjr4yEY?=
 =?us-ascii?Q?rV+A0R1cudYdpnz/A37AFmwogySOqMFR6/9Oa0Z65KP9tP9CCU7pOyj30/6i?=
 =?us-ascii?Q?J5JNrgEph9Ki4JAHCDvesbp7slZvsv8ICN7Myr0iQdM5shAWF+LqGvxRv0Sp?=
 =?us-ascii?Q?y+uLEnIEVLIApoFfHJ2odZ0Xd1zjtea5l30Vlqhc?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5be1ed7-acfd-4b9c-7df0-08db82c1f995
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 10:23:03.2199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i29oXt/iq4dS8nihaQkcw3Vk6LSlY06IbRZTdpUubvz0VaWpbu9wYnnoovlNhw4HvQ6zbZEdsq+67y+kvn2k2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4213
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The function clk_register_pll() may return NULL(in line 149) or ERR_PTR
(in line 131).
Fix: make IS_ERR_OR_NULL() judge the clk_register_pll() function return.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/clk/keystone/pll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/keystone/pll.c b/drivers/clk/keystone/pll.c
index d59a7621b..ee5c72369 100644
--- a/drivers/clk/keystone/pll.c
+++ b/drivers/clk/keystone/pll.c
@@ -209,7 +209,7 @@ static void __init _of_pll_clk_init(struct device_node *node, bool pllctrl)
 	}
 
 	clk = clk_register_pll(NULL, node->name, parent_name, pll_data);
-	if (clk) {
+	if (!IS_ERR_OR_NULL(clk)) {
 		of_clk_add_provider(node, of_clk_src_simple_get, clk);
 		return;
 	}
-- 
2.39.0