Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 12:05:27 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Guillaume La Roque <glaroque@baylibre.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/27] thermal/drivers/amlogic: Convert to platform
 remove callback returning void
Message-ID: <20230712100527.33gei4nyfvejhy2q@pengutronix.de>
References: <20230712081258.29254-1-frank.li@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="st54h4lvkk4iirjp"
Content-Disposition: inline
In-Reply-To: <20230712081258.29254-1-frank.li@vivo.com>
Precedence: bulk


--st54h4lvkk4iirjp
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 12, 2023 at 04:12:32PM +0800, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Cc: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  drivers/thermal/amlogic_thermal.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_=
thermal.c
> index 756b218880a7..a95c8959e5af 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -293,11 +293,11 @@ static int amlogic_thermal_probe(struct platform_de=
vice *pdev)
>  	return ret;
>  }
> =20
> -static int amlogic_thermal_remove(struct platform_device *pdev)
> +static void amlogic_thermal_remove(struct platform_device *pdev)
>  {
>  	struct amlogic_thermal *data =3D platform_get_drvdata(pdev);
> =20
> -	return amlogic_thermal_disable(data);
> +	amlogic_thermal_disable(data);

I'd make amlogic_thermal_disable() return void, too.

Otherwise looks ok.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--st54h4lvkk4iirjp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSueuYACgkQj4D7WH0S
/k6IaAf/Tc1hMZUjWFoPJ7YHR9dJiBEfDNwycNw/iawByqBJErgwBllns9wyhBHd
Wiu2QAHKEZeJSvbwP0g8gAeKMLk3WKaooWUBGtcJiMG29HfcO/INO1BG+g08xJrB
615/bLjUCoamEQeuJqBa7Fs06D1FOqDw4SZ9p0HUtIar2m6Ws3C6/0EJvbwFOguK
UfsG8QnTXtjerJwHyBYViU9h3S41acOY2mpNXzgVwjk5xMwaUD2vdPQPklxBXuLN
rhc7DG7PgJ8nKfTBw6xKmPv9d/Bnke6YuUnd4U2fAoWscznbEmRUl3EcFKhQA8vu
qxycJcrx1/j2Gsv0fAkDaXP1lR9xdQ==
=EaAv
-----END PGP SIGNATURE-----

--st54h4lvkk4iirjp--