Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 13:04:05 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Alejandro Tafalla <atafalla@dnyon.com>
Cc:     jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval
Message-ID: <ZK6IpZvG47zsKZFk@lore-rh-laptop>
References: <12960181.O9o76ZdvQC@alexpc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="a1ZHb+yY60egR0aD"
Content-Disposition: inline
In-Reply-To: <12960181.O9o76ZdvQC@alexpc>
Precedence: bulk


--a1ZHb+yY60egR0aD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI
> support is not enabled to allow executing iio_read_mount_matrix in the
> probe function.
>=20
> Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
>=20
> Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
> ---
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/i=
mu/
> st_lsm6dsx/st_lsm6dsx_core.c
> index 6a18b363cf73..62bc3ee783fb 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct dev=
ice=20
> *dev,
>  static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
>  					  struct=20
> iio_mount_matrix *orientation)
>  {
> -	return false;
> +	return true;

I would say it should return something like -EOPNOTSUPP.

Regards,
Lorenzo

>  }
> =20
>  #endif
> --=20
> 2.41.0
>=20
>=20
>=20
>=20

--a1ZHb+yY60egR0aD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZK6IoQAKCRA6cBh0uS2t
rLw5AP97OM4FyYf1bRULy7a0yrejqbRvsTYgBHpnO3Okk3GF+AEA3xnWcjF4LTAO
o3VyGdcNfSq9Vx8lFJwnzaZ/MsMAwAc=
=rqcn
-----END PGP SIGNATURE-----

--a1ZHb+yY60egR0aD--