Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org (open list:NVM EXPRESS DRIVER),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] drivers: host: fix parameter check in nvme_fault_inject_init()
Date:   Wed, 12 Jul 2023 19:18:37 +0800
Message-Id: <20230712111838.11923-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xmgZhZsHlPTlwlxtnEzpsQKnichNpbWqolWyGcT6k5oPc8sODE0jewcJlkTo?=
 =?us-ascii?Q?GSkXhAfBsfpnxoqpeND4tZQbKj2PkN6p/Zgb+wubDkfjD9zTgkIIqIhRJe6Z?=
 =?us-ascii?Q?1eHESGvTZS+Ffl6cZuUnvnShL/26DmE3dtePKK4rht/MRB8RXCsH66HFucHT?=
 =?us-ascii?Q?iwALhEjWpGhbRgjhKdPeQTc2EQ5N0k3erD128aKN6tgWjTNQMxg3FHhEPRan?=
 =?us-ascii?Q?9BnY9a43M33x9D4g1M1d+P3ft4UiMt/e0e3ndCrOcADLQRa7AuMSeWachDvD?=
 =?us-ascii?Q?T8+YzDUT4RIKMlSiHmPoEL48qHRLgFcO5RQzj9y6gpgukBQdc2zqb4/eVuBI?=
 =?us-ascii?Q?wQuXclSvQAhTkUKUnkRWPlAuofs/WCVoZrRJzPautQ9gmx7HGkUs/OF3gD87?=
 =?us-ascii?Q?IHS9RfB9/IvBtrjyDk2pBVb6zW4IvzM7vX85+VkRBP2bcVOgHkBtoW1Dyfk/?=
 =?us-ascii?Q?CP11sl2KscmnzbqhlK337WyROx/9Zm7+uCj4JA7L3459mNVF9mHpT8q4JRio?=
 =?us-ascii?Q?HJUJQGO6QOlMvkDdgfOc+s2pB23dtFCq2m9PtbWwAUUQ4pjNk64M/lDRyR/7?=
 =?us-ascii?Q?vw/wVGZ4H4KUaJik55r9J8WNV7i4bSch+stqm1p1fknGABHHYZXP91p4KNEr?=
 =?us-ascii?Q?McWJQ8zJmstrpThavyeoosnJLU8gD6hZ0F+UsIQzHwsVjmMjZOtlTT6HoqyI?=
 =?us-ascii?Q?+FFjlDfEaxNpetDvfa7zgUyY02Oaw8bO6SC2Btea+8LmG00xUUdEhnEzjRWx?=
 =?us-ascii?Q?+pSCoAVlijXS9V1tdWoy7Tc74QZh41qYAlVKEqQtib1HuWzkIfoSuBi5M+X4?=
 =?us-ascii?Q?AnfgunobcivtPJ+rFhFSks7i04EMHBIImklmwPhi1eEwU8HQLld4E8HzvMpl?=
 =?us-ascii?Q?v248VryFNp0qcvpnuZg68nDT4318xhu5nLywzq6G952zGH5+QEDuY2oVvHNV?=
 =?us-ascii?Q?JW4zLbhxlZG5V/vIVw6tQfnrJQzVbInegsEwaQq1BcyGYo2BcOniF3uG8k1z?=
 =?us-ascii?Q?ECb8Z62jciL54mBxgFDkUjsuOE8W88uPBJUqGZNG8yKp2md6Y6aWJOhJeTes?=
 =?us-ascii?Q?gomAqZpT6n/vMAHU7YOg6i/7cu+xtFMSWi1ZyOGgEDg9qJoB3HGksFKd7N6S?=
 =?us-ascii?Q?CiHx2kGQiXiM58y9XbgH3rFGZtnjvosxI6cU4KWV+AJwnhg6ke+usGBAoiY8?=
 =?us-ascii?Q?rGY9akTFiDdHJ987zHbmFbZfPx+ZRL4AAMO6M+VVO3w29wRzitgD3PqrFv3i?=
 =?us-ascii?Q?0ex2UZa91kXDA6pHCaMu6uxu1D80juriO6cDu0H6rLBAxefjIhF/2y8HZYRY?=
 =?us-ascii?Q?EgWnDJoOkFM5+q5zmp/0OZeq7wW3fC6R4AysBtxMzkh++Zh4Arwn0j0ndQ91?=
 =?us-ascii?Q?qdxqcD5X48kxM1MrCZJ5gb0wDb9o8Fm10nMLx41qUF4xSDH+tbnF+yaVSPHo?=
 =?us-ascii?Q?5DBvKoMaS96MDm4EDu29BBTSVfKcmugSXBzzk0v36OeigqZ69SG19vt4IKi4?=
 =?us-ascii?Q?xuKQc9uIWnn0d+Ifsq21BUWGGRSrFSwRMZOtjnjkh97YHj80QlYqtUU/ZFZD?=
 =?us-ascii?Q?bKmr7hTXTlMj+8ludiNgLmrXl4JpHssZoGZpME77?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f364131-5524-4cc9-c724-08db82c9c265
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 11:18:46.6519
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WZN97aoClfK41Rq5XrlBkqGypVPHE8v35GzCU3TSxCqySY+5hobKjnp6WcSkMSEi/WIJha+OzHbbm/1e65UOlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6544
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Make IS_ERR() judge the debugfs_create_dir() function return.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/nvme/host/fault_inject.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/fault_inject.c b/drivers/nvme/host/fault_inject.c
index 83d2e6860..1ba10a5c6 100644
--- a/drivers/nvme/host/fault_inject.c
+++ b/drivers/nvme/host/fault_inject.c
@@ -27,7 +27,7 @@ void nvme_fault_inject_init(struct nvme_fault_inject *fault_inj,
 
 	/* create debugfs directory and attribute */
 	parent = debugfs_create_dir(dev_name, NULL);
-	if (!parent) {
+	if (IS_ERR(parent)) {
 		pr_warn("%s: failed to create debugfs directory\n", dev_name);
 		return;
 	}
-- 
2.39.0