Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Andi Shyti <andi.shyti@kernel.org>,
        linux-i2c@vger.kernel.org (open list:I2C SUBSYSTEM HOST DRIVERS),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] i2c: busses: fix parameter check in i2c_gpio_fault_injector_init()
Date:   Wed, 12 Jul 2023 18:52:17 +0800
Message-Id: <20230712105218.11056-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PyKkM9G+PrLrg2RD9UAHBI/QD+s0j3lSAv2HLvTZUm0tmtwhLbVmq1CXkpsP?=
 =?us-ascii?Q?5xObQSybfV/kIuafw+R8p654VjJZe2WauLk2ejBMHbDarNXRt/EsTF5nwrcd?=
 =?us-ascii?Q?oCel6SB/fP0zugd6wh/tNeMJBzGaTBFkhzYKtAht16OVDpEEOuADDfPjoLkk?=
 =?us-ascii?Q?8+f4LZy9CJUTxoDvya1M88ACHxuabN49N/bx5K7NIgQLo20huoxG1Dz6H5iT?=
 =?us-ascii?Q?x6pJY50A/36rZmN2kAGFLdmDqcdq+0Cn3PAQgozSdoyZaeSkBl9F8iwJ/kzo?=
 =?us-ascii?Q?kVb1ICPrtCNFPntP/D20L0sNe0cxjMpabkjS8d+WsaiIaHYFFvArttDOtMRI?=
 =?us-ascii?Q?1dw8FIds9uQ/4eHwBYoun4rFmD9qiPymf7nH1pLTysAWQhoCmtxll9eax7hL?=
 =?us-ascii?Q?zxY54C0IZL01cXUhCbY40FjrXUPjV4P4zsCUhnCSL2ZYL3n35wJaY3gnE14a?=
 =?us-ascii?Q?s7q5qwr6djtbIPFduIr3N/8es1NxywMmsGJ/8ZMUp2LTCGVZ0Lf1CWj4ulnX?=
 =?us-ascii?Q?epfaxjFWXj1AvB3i21jxP0eN68MuNFAnXBTyBtpX/zk1p1qXgGTxUlHzhQ4V?=
 =?us-ascii?Q?BaLOYj4S46FiUn2On60171sa+7nrk0MOKlCcsFPSjfhI0mQWnUF/c1jI9lqI?=
 =?us-ascii?Q?V7TdkSiaDtEeV9vte12nPTK4KYqWi35hec64h9BlxiJxpuvqKG05XOaXEHZc?=
 =?us-ascii?Q?uIuEiSiSXoVOVgecBMzwbyi7J8IrYeELfUSyB8atxDB/NqTupbHa0RVcTTcD?=
 =?us-ascii?Q?F4c4Rc7u8JPjXKcHacirceMac2oUK549eauDtCbRifDBa0wDirhU6So3eJlY?=
 =?us-ascii?Q?Z9NdYeCn4tKStEg1YnnLz0kksB473Is9Wf+YZxCtjl1whstLj/ykHoBECqhR?=
 =?us-ascii?Q?h8T9Xp20vqD492i2SXJAjWd5dWoxT3ylSEwekQYw9LxTABSlhbiwwXWDzdlX?=
 =?us-ascii?Q?TYhV07NFh6SN4EWa3X3fZEqbbRPsqdF4uYoytJmxeJ+kE8zJT2rjffFpCbU3?=
 =?us-ascii?Q?kLLUC2PttAxNIEVl9yeqey+OABK5lvQg7shDaVALwypVQPnZsJl/eAd8lWVf?=
 =?us-ascii?Q?+/NcSfcaX6zBjof8r6n7TnXfljSroAlrIKWea+4ebDSeZaoxgJvIJylD/28C?=
 =?us-ascii?Q?lGEk0BSvh9jM+ByOJGykxFSeZuLivqAUT6vRHz14W1xKHG4W4bb1ewx7/va2?=
 =?us-ascii?Q?XUNIc+GeZnWnut7qIgyvyNRbNxzhjHoWEAucT9n6/xiHCtlnDHbzSPE1YEoE?=
 =?us-ascii?Q?IZyM3sMm+IMbmLVAnGK2VjclDrpN7jQrk4mv0AzFw2OOmAKM1WZUQlgb1XBs?=
 =?us-ascii?Q?+E4d3F1ljrdFi3lCe1GuTrCzwOtVLpVufTm1lqBEtNs6DcbO5HW5oPRE4IXE?=
 =?us-ascii?Q?/Yjbt9pcaAs5czgTcKnmf8eb8VLywmwfbibWLleiWOujtcqgS2zdnPT62Xlf?=
 =?us-ascii?Q?Sk5etQoIbDEHPhOq7N7kNwWDuDmKiIlzHfEmEpiQd2lwLLP8Kk+LJNYc6Nzp?=
 =?us-ascii?Q?uXnSVG8Ne4OIRuobueGK+tWwZkJI29OXnPG23k9lD6PZh/JiccVszwRfAR0x?=
 =?us-ascii?Q?KSExYkAezzw+lN77XDD5of+iyB4X1vii2LrOunjH?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df65577c-ed15-47ce-b2a3-08db82c61913
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 10:52:34.0892
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r2GhXP+8dag4Kx0cSG0t6Evu0PP0hDuALTTghx0VWI7ndG8189cTw6mh3AlomoW9UTNVnw+k5DgKFQ5Vdc0jpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6766
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Make IS_ERR() judge the debugfs_create_dir() function return.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/i2c/busses/i2c-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index e5a5b9e8b..07719ad74 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++ b/drivers/i2c/busses/i2c-gpio.c
@@ -265,7 +265,7 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
 	 */
 	if (!i2c_gpio_debug_dir) {
 		i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
-		if (!i2c_gpio_debug_dir)
+		if (!IS_ERR(i2c_gpio_debug_dir))
 			return;
 	}
 
-- 
2.39.0