Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Thierry Reding <thierry.reding@gmail.com>,
        Krishna Reddy <vdumpa@nvidia.com>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-tegra@vger.kernel.org (open list:TEGRA IOMMU DRIVERS),
        iommu@lists.linux.dev (open list:IOMMU SUBSYSTEM),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] iommu: fix parameter check in tegra_smmu_debugfs_init()
Date:   Wed, 12 Jul 2023 19:31:45 +0800
Message-Id: <20230712113145.12888-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ncvss9A4qvmX/xUDRmEVNQ4w0v5eL0q/PlxAjgxFk0RVBw6E28HDc1+HqGyb?=
 =?us-ascii?Q?vtt084FiR43KyhDO9zartL2wyh81DMLNewOClYrskQSHAjB7gs1smvwvhI3f?=
 =?us-ascii?Q?TaTuGOEvd8QLNfdNnAZ/uArXJaQszw9QXgeD/q7/+ui7u8ikJ6QWfMxe5Pee?=
 =?us-ascii?Q?hh3hoeZBwmCzM1SSE7qkAq+y2Ga7x7y0sO0rfqCOCERSNwEZnPeJ2JFccqdV?=
 =?us-ascii?Q?dE7/TMBOPdOQ7/ZyoTMYO1BJsRc9GVVelWHTqWDY5nL/T4O9vZEntaFSA2TV?=
 =?us-ascii?Q?GDJXjeHmUcTK+dBWDfTYnyaGTtLh9yPd5PYxWQtUvQBNuKI5AKrNoZsiNuXs?=
 =?us-ascii?Q?1bS17BmbP7kvtyfGdBK+KyumbMMcM6+6jKwBwEzdWaGe9sBKXFoDoXkp3beE?=
 =?us-ascii?Q?dzwDZ601N+Bdkw672o0VsymgDvXWZBOOgQM6/wctIr2o5mG7IFn/p71QtM5h?=
 =?us-ascii?Q?uulyBxfNzD5nQPRsfmU34o3ooJAkQy9T/1pPM7sNO2r8Li9xFlpEOM/ah0rk?=
 =?us-ascii?Q?Bj6hWOvi8DEBBWYyjCacKRhAPkjdKgb/JvF++i4bVF5UYTdYU5/vdhI9SmOQ?=
 =?us-ascii?Q?AA3hter0uc0rSTc/XWzSQV0IAdPDWTdWI6D9VphaN2rrJ+v2Dx0acBFGyM3n?=
 =?us-ascii?Q?2IY1a3hg2L3qVbKY+NtSZmrwYRzyjcBnnSt21bnufUxBCvnH9v4LZXIWJnH6?=
 =?us-ascii?Q?i6uMQSx/f3dGClIoJqh868dtYp50rG/6yokhWvNDZ5sUxAGFKxbzXuoNGgMA?=
 =?us-ascii?Q?JdJ3ZOkoNcSiKloVzBlvDBxvyqzxDyJF9DAfjhvEAxPFqZdBRwatl8ARyy0h?=
 =?us-ascii?Q?s0dAj4AOJmeA6ptr8X6K207ZaEmqac0A9ZnRECZarjos13X8QQrsCTt+8Xef?=
 =?us-ascii?Q?dwSZt74syWx4Zdboi0pVPR/LHAZ1fN6pngpD0jRBsWM1rCRfTxg7ghKaep1a?=
 =?us-ascii?Q?OPTnXafKoaXpwgbxfrxGr9Nou6QZIe3/ZSVcSDe68X+WGTCOICAcaKkZyPNH?=
 =?us-ascii?Q?07oGPsf0F5GWEN08lJJekE1Y8rOujXz0KOfX45MFjF7ZeibrrMzpOyB4RDeB?=
 =?us-ascii?Q?wdYTfi0jiMTsAN5SjbKUayjHevKMCB6z7O+t82wtMtiGGkX8wUuqsCS5yeoZ?=
 =?us-ascii?Q?bpuSwvLBA2dByCE3/6yLkROMa9BX5xgXi4NaKH7OO/blztyrwP+f15GL1Fcu?=
 =?us-ascii?Q?ipQ2TrBLVLmdJe02siyFDc1eh3sTx8qDP6xUs8n1MviZipVoYIiDYP3cwMw0?=
 =?us-ascii?Q?t+Er3CbjX8WdjrW+VP41W5LMMgMpEbu785UjZ2wVY+wS4RatwbeKAxd6iw9s?=
 =?us-ascii?Q?YN7R0NnIjsR/sm5uL5Qe4Kr/eWiDjwyHhsrgXhe6oInO4v4FIJbYPM17g9TK?=
 =?us-ascii?Q?nO1BSRzapqsfNlKlgiDjI2NuyRkJRYYJdm/r4D7daF1rGb6QPeh2UcY8BIk3?=
 =?us-ascii?Q?0MtdfiXqCwN3a+sHceVlrQ1+NEBzFIEPlyCimBmm8Pd1YuPCjyWI4Tx/u04P?=
 =?us-ascii?Q?pkzTJ//W1jsdT7nQYOtQmqOXU270Hgv/vmaSan0Yb8feXJYY6NcUaTTOKQ9u?=
 =?us-ascii?Q?580FAFgSNphBgTdbu3atRDHj7I1Jh/qQkAm9fjaE?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dab15e1e-12c8-4f7a-11bd-08db82cb9c0a
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 11:32:01.3528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kYLAf17oVOlCRXfT+oiXVD/FBAGS3mIUHBlE7cnJ2ag9u+QLF0RiQDeDTaV2jrA2S8y3IMqH3cd6fNMw8j6hbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6713
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Make IS_ERR() judge the debugfs_create_dir() function return
in tegra_smmu_debugfs_init()

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/iommu/tegra-smmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 1cbf063cc..841e14cce 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -1056,7 +1056,7 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients);
 static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
 {
 	smmu->debugfs = debugfs_create_dir("smmu", NULL);
-	if (!smmu->debugfs)
+	if (IS_ERR(smmu->debugfs))
 		return;
 
 	debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
-- 
2.39.0