Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 14:06:55 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        linux-mtd@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/18] mtd: rawnand: sunxi: Use
 devm_platform_get_and_ioremap_resource()
Message-ID: <20230712140655.72fc2a3d@xps-13>
In-Reply-To: <20230712135455.71fbeb5f@xps-13>
References: <20230707040622.78174-1-frank.li@vivo.com>
        <20230712135455.71fbeb5f@xps-13>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


miquel.raynal@bootlin.com wrote on Wed, 12 Jul 2023 13:54:55 +0200:

> Hi Yangtao,
>=20
> frank.li@vivo.com wrote on Fri,  7 Jul 2023 12:06:05 +0800:
>=20
> > Convert platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.
> >=20
> > Signed-off-by: Yangtao Li <frank.li@vivo.com>
> > ---
> >  drivers/mtd/nand/raw/sunxi_nand.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >=20
> > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/s=
unxi_nand.c
> > index 9884304634f6..db36bd755b8d 100644
> > --- a/drivers/mtd/nand/raw/sunxi_nand.c
> > +++ b/drivers/mtd/nand/raw/sunxi_nand.c
> > @@ -2087,8 +2087,7 @@ static int sunxi_nfc_probe(struct platform_device=
 *pdev)
> >  	nand_controller_init(&nfc->controller);
> >  	INIT_LIST_HEAD(&nfc->chips);
> > =20
> > -	r =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	nfc->regs =3D devm_ioremap_resource(dev, r);
> > +	nfc->regs =3D devm_platform_get_and_ioremap_resource(pdev, 0, &r);
>=20
> Why do you keep a reference over the resource? Why not just
> devm_platform_ioremap_resource(pdev, 0) ?
>=20
> This comment is valid for almost all the cases in this series.

Actually 'r' is used at the bottom, so the patch is good. I reviewed
all the patches, 17 look right, I have a minor comment on one of them.
In order to avoid resending all the patches, I'll first apply the 17
good ones and ask you to resend just the last one.

> When the resource is only needed in an error printk, I am also in favor
> of modifying the error message to avoid having to grab the resource.
>=20
> >  	if (IS_ERR(nfc->regs))
> >  		return PTR_ERR(nfc->regs);
> > =20
>=20
> These comments apply to the 18 patches.
>=20
> Thanks,
> Miqu=C3=A8l


Thanks,
Miqu=C3=A8l