Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 14:10:13 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Lee Jones <lee@kernel.org>
Cc:     Pavel Machek <pavel@ucw.cz>, Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in
 SPDX header
Message-ID: <20230712141013.67140778@md1za8fc.ad001.siemens.net>
In-Reply-To: <20230712115252.GA10768@google.com>
References: <20230706161040.21152-1-henning.schild@siemens.com>
        <20230706161040.21152-3-henning.schild@siemens.com>
        <20230712115252.GA10768@google.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G1jkC6V6xnuLgaC1a6sOmMc60BMmNBgTk15liiODrqjHmZnroHE+emO4Klss?=
 =?us-ascii?Q?3fBtxrtkh7rYGL/K9nWRKxaBX78xebHmzKGDE8QcRvf1fQRTQ72LcvpuzONB?=
 =?us-ascii?Q?WvTNEftpKTzKYl+Ks+uo4gA6l5iOfb7qc4L6uZWQiTIpi2mSEFMgLjrpTDys?=
 =?us-ascii?Q?tmc6RxUbZsck5vD52bYZNQN5FYmyLHseqcHFYpRBPlmuaECmWiQGDoOPxq4q?=
 =?us-ascii?Q?9UI29TsC+G3SmE21Chh7VrQk7k76kX7B7+BvVx6JuSF/PjVJWS88DvxrtX2v?=
 =?us-ascii?Q?jy7esBFGaC3gTPPdS0faTOHYrGycGH/fb00uaDMUhLvdkScjDVxIHFXeI+kJ?=
 =?us-ascii?Q?/rEzU97GOR8VYHR/EfdSmwakIo1z0KnKYpdnrYOIMcSF+JNC908zAB24uU18?=
 =?us-ascii?Q?MRkI3jzoCGI1Ui42Bo6mFXhzfEpklCOqbz2w8hMJeHIgX4KhXCT4FNWnnL9+?=
 =?us-ascii?Q?UjwTmadvV+/c27+c4XTRi1A7nHH2nDUCHckOd6nplfm3XJJP9VIG4Cf6J5lo?=
 =?us-ascii?Q?R5a3ayXQmtXKK6rNrvSCRjhX+SZeBuXakaMnRa1rqwCGIZIGu3W7+wJR5aDz?=
 =?us-ascii?Q?yAEvJZJ7FOncSHOcH33mLC+1dRFkkkQBJB7OBN2z2rpMhPJTnhtpa4OyU4Ge?=
 =?us-ascii?Q?yR2OLhh8+G7K0l0nchwUjaGJMo4knG5f+Pp/+sVX1xMidkUEp93CiITgU+SD?=
 =?us-ascii?Q?mSrbgbyGpVZOqEzQRs8c7ICioD2xVau0r0zqUfbMx7/+JEtFfcXS/mCGAvFM?=
 =?us-ascii?Q?76xz/u2nQBJCGIgwhPMpqAwUFTQAbHXhSpaxJjijYbTUVvj7eOAeNP7mhONg?=
 =?us-ascii?Q?eAP2si5uZu6hATj3QKom2MrjEXFNy9t5wIvUqYd78K13vlZoSmIFPOtk/11Q?=
 =?us-ascii?Q?5lRUEhYJFL7UQPnbR1fhYnH9llW58TaLqy8pKDJLJpUnYQc0tk2w4DWNTxj6?=
 =?us-ascii?Q?syPgi1hb4fxioZy/qAXII5nyiwWun9RHhEk4dqtTe+EdF0TqkHk7+2+Tgqgm?=
 =?us-ascii?Q?nfhRVKeZOmK1rs0xxdxJr7lyLhCb+PhUaEKPzRKHAwAYpTj+je7zevNVydqx?=
 =?us-ascii?Q?oQdiwHE5XKRUOzziEy9LfusgTP5gEJnebyjiBJr1zvPztlOv2RSmKZQVQF6o?=
 =?us-ascii?Q?GeggvRN4KnJOtrDpDTNU/jKVWyZ7X+0SeY75FPTrnwQ9ogXzzVrvtfuRieaQ?=
 =?us-ascii?Q?UrET5yRSrj9PMhCmLxfjkiO4o5QTcC15u/t0tOgdeVVkTGnnKhlcmMEcPwaa?=
 =?us-ascii?Q?//rcLLjogMFSCdzOH5bFNHx9OtybblzMlW/JCV2SSw6M+URIzbCZW2LKUei4?=
 =?us-ascii?Q?1rtqP29FKrkPgkcGEGGf+IZkLY1tAex+kBbpM8NZSs7/cnlQNSqmEenA6kw1?=
 =?us-ascii?Q?WCk4H5Qi+JFRyhfQMdz5VeApJ/Tliw/Clj6F2LG+epbzjDgRFoLouJrny2HI?=
 =?us-ascii?Q?3cS0OXRPcPnoDkWbMYrrrZGNhZUpCTZsh1zmt0YSeB5RvzrUvgwQRirc5KaT?=
 =?us-ascii?Q?zriyvI222YkApruXKT4jBWmROC+6vKHqfwFivzRG+VYHCF5/eMWpXB2fvxif?=
 =?us-ascii?Q?OY4BJnpnNUmc25LIbw5hwwZvQiGmuMsReHFon2PuTZn23bxI6ubSngoGc0Dy?=
 =?us-ascii?Q?QstyKhoYdUZdx/8wPGaBa/gJJcpfzc/U5AtxKQL68eh1Vz+J+uC5GNNUkVTg?=
 =?us-ascii?Q?Tl5CiA=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b45cecad-3367-4c8d-7a46-08db82d0f911
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 12:10:24.9195
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZxK8eokbu4s9SBiY7DxnComBjI8jGouvHhnqDk2O5IrCHaurPzx6IgIC95q9scoPpmrkYHSeMN/DKKj00DTWiLsQu3eI9/sbHyqWjl+Q7Vk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR10MB7693
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Wed, 12 Jul 2023 12:52:52 +0100
schrieb Lee Jones <lee@kernel.org>:

> On Thu, 06 Jul 2023, Henning Schild wrote:
> 
> > This was found with giving the file to checkpatch.
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index
> > bf258c32f83d..3d4877aa4e0c 100644 ---
> > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > +/* SPDX-License-Identifier: GPL-2.0 */  
> 
> What prompted this change?
> 
> % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
> 117
> % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
> 2
> 

./scripts/checkpatch.pl --no-tree --file
drivers/leds/simple/simatic-ipc-leds-gpio.h 

it boils down to header versus c-file, not sure why headers prefer that
other style

Henning