Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 14:22:17 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Minjie Du <duminjie@vivo.com>
Cc:     Krishna Reddy <vdumpa@nvidia.com>, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "open list:TEGRA IOMMU DRIVERS" <linux-tegra@vger.kernel.org>,
        "open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
        open list <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
Subject: Re: [PATCH v1] iommu: fix parameter check in
 tegra_smmu_debugfs_init()
Message-ID: <ZK6a-f2Se3HWjU7D@orome>
References: <20230712113145.12888-1-duminjie@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="So7QhWFQ1LiNBVmH"
Content-Disposition: inline
In-Reply-To: <20230712113145.12888-1-duminjie@vivo.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--So7QhWFQ1LiNBVmH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 12, 2023 at 07:31:45PM +0800, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in tegra_smmu_debugfs_init()
>=20
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  drivers/iommu/tegra-smmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> index 1cbf063cc..841e14cce 100644
> --- a/drivers/iommu/tegra-smmu.c
> +++ b/drivers/iommu/tegra-smmu.c
> @@ -1056,7 +1056,7 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients);
>  static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
>  {
>  	smmu->debugfs =3D debugfs_create_dir("smmu", NULL);
> -	if (!smmu->debugfs)
> +	if (IS_ERR(smmu->debugfs))
>  		return;

I think we can just drop the error check altogether since
debugfs_create_file() will simply return early if smmu->debugfs is an
error pointer.

Thierry

--So7QhWFQ1LiNBVmH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSumvkACgkQ3SOs138+
s6FfXhAAjRjwsGjs2rm1PFgf1a1quzdz67t2GTDswhEnV/zLM0eXE9y7LzTzl23O
wM3y49DWK44J4d77LAZeXw2vCa7QjorWCcLX9uwJhxFOVwYJ5ptjRDOVkCjNTscu
JYCLoKICX5NmpT4z5zUp/bCTm4hu0fsGQIKilEpH0+0h6JrUObbtappv70dxLCFp
c4YJ8ZDR0faBjjrIOUQdbMqSB2fOyuOgfdtO9n9Q0PMkek6JXywr+DNUtuidoD1j
0NtgJnreYfvkgyn+dQ61XoqYHi3Ql0VpIMrQKrey45urtFRgpN75KxrJhlKSHSGo
MVDNLEEyoLGNAqjOpVErnmmDQvDXUcpDieXzn35LsW9ijpdX2/i1JI/Y7sJwkSTG
uuWZRDW53E7C6xjlMk3GklMJEn/ChJU4AMgvQrQ85dxokO6XTfP1GbjcmoofPoA6
Jl5+9BrN31j8aCnOlEarbVXyFQdKSu54Vsu+INoIj9cpsVmOQNeTGfqpQnjOiXkj
cpJOEfetwB1L/WcjQyaUJjti8nk5AMwfx5bclJPXJ7qT7sHcbB0n0GXmcmOog6o0
XvO1baO+9lCIS9Nchn8KR+oo7wmCT7E8IWKxWLkDgznInfXXXl1WtIbPgbzNN1qk
8w55I6NwjRfo80lpkGxlr23Vk6wiJJCbv2BC3IjmGkHP4eZoPP4=
=kkYV
-----END PGP SIGNATURE-----

--So7QhWFQ1LiNBVmH--