Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
        Allen Hubbe <allenbh@gmail.com>,
        Serge Semin <fancer.lancer@gmail.com>,
        Dan Carpenter <error27@gmail.com>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        Wang Ming <machel@vivo.com>, ntb@lists.linux.dev,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v2] ntb:Fix an NULL vs IS_ERR() bug for debugfs_create_dir() in tool_setup_dbgfs()
Date:   Wed, 12 Jul 2023 20:39:59 +0800
Message-Id: <20230712124035.7981-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/J4FYjVNrqT783BiIfTfkanqPkODS//UYcMdk6G/fVpBjBmPBhVbazXpUKo8?=
 =?us-ascii?Q?xuIoXtyDEUINl7RCBnMYTKgcFVVkzb4/GASiKKqKi3vR8OtTO7HXI0iYkbd3?=
 =?us-ascii?Q?aXtq0e8kH7AdcoSY5GQg2Wy+iliAR07s1CjFL0OCNvwsk/FkB3DOuFKbIzGM?=
 =?us-ascii?Q?iVqt3AWL9e9cGl3aB7UINWGT8jRpMAmhP54dDVz7TI6yPOdlbaE1DylbyYFI?=
 =?us-ascii?Q?klhTJuaKgUiwmHLx+Uya8RKxl61D/RGWBB1z714aL6lESYZgmIHxYN2+KRib?=
 =?us-ascii?Q?U1S8OQHV80ympSA51lhX9YNLYfTWqnC+2JDXpwC00xhgDUaHlyBwVvbLlUgh?=
 =?us-ascii?Q?oImBUCx5BAxAN6Tc9F12fBwcMD5pjfQmkII80oCOSMmtacBj8nG6r6s7QKvl?=
 =?us-ascii?Q?tYZ+peGT01rRhK1aG8+/M8Ne1TcVKU/LEgBzF4UhWg0nFWw7uK5eJrcvHVkT?=
 =?us-ascii?Q?l0kWBhlX2d8w0/tRhyVsyVzofeiIkWkySj2am7UkXLYwgIf1sJ91arRPKRF6?=
 =?us-ascii?Q?QBGQ+qsCnu+DZk1AiLI4hxhm4bOrEF8sd+Du0ykt79oCVllDWp2N0PSI4kjG?=
 =?us-ascii?Q?sETqPe4TA9vM69B8bWcRzshuaCRO4ItMbhmwkaPP9QrVihOTUjzLdiciIh1P?=
 =?us-ascii?Q?/I6mV0Vc0nBapCDm0lNRpwxtgJIszZ4mK05CKLxBAU8WI5UPFuWrczSShvis?=
 =?us-ascii?Q?Mlcbro6exvuyBAehUFKus7+Pv882Xn/e2qzrDJJB5lB63BFttIiLG7++jywP?=
 =?us-ascii?Q?W1O4+vKfOVV8kWql5+iCiogHolPVr1VHeRodUr5t59lWwCG82cZh2OcaG5E6?=
 =?us-ascii?Q?DChOCsQYm2gRVT8s7DZVP8NcUlYVeQK7NZ02xWoZ19R4DwZE+m3+NZKBrIEF?=
 =?us-ascii?Q?ZgAwFdMpnfu8W2FVCIfF7SBjh/Cjs78L9BPsx+7J0neYpg/zzNFSxIZXviOx?=
 =?us-ascii?Q?0ct5Cp/YzOYTQEX3trw8c6u4gW8H36C8MFQ75aAAn9emz7MZGYMltC7EuQls?=
 =?us-ascii?Q?FqpeW18FQ4/6iqOu/QtrcIlboR9a91yNgKNr44/QAbvzSsYyN6Brsqk8nOGY?=
 =?us-ascii?Q?zNmYyKRM2Z4RM7ZAEackk+5LNlKOgzhOEaoZpyehMwInNQggOWWFSX56Q+bj?=
 =?us-ascii?Q?XQmc9FGJHwcrZKojLEgn3Odzx72uOUTCSVTK8CPCJjnpNdo8iilgI02uEiif?=
 =?us-ascii?Q?G8ere2CMsByRHFrpj1tfvQxGp1to1N0wq1Ve7yIr32C5Mc27E9LoMUQHJeNk?=
 =?us-ascii?Q?rBQty2hImiJ/60U96erc8CNn4Gc36Vxy349JxEtLQB1lO5jh4/KS2K6K6Tom?=
 =?us-ascii?Q?L8CxEc3OoDRyoyoYxmLT/o8zYA9Guln4EVdYrLhDOSpEn+ufmJ1pBG1utJ2o?=
 =?us-ascii?Q?fmBg0PkwixyfVTCMgnkdVTwhe6zNtpzUc0VvoJuT3WJ1RNEON0v5PtEjWHdX?=
 =?us-ascii?Q?EdcVjU0tfinkdPLjdube1edv2ZVYfhT6Mdq0vB8dRAxJx42tXGxW/YtZyGLc?=
 =?us-ascii?Q?ZpbSzXo3qYj1Rr7tlLiR6Ju42oHhMW+KRW59nE2leSftR81vkT3+/uTZDbJ9?=
 =?us-ascii?Q?xXCjC7eIPrR6G1fOLqE911p8PrvehWZT3wl2wqL0?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b01395bc-a8a5-4254-b519-08db82d53fd2
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 12:41:01.5131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3ykpuu/XJzb0nO8hdoP7Z9HqQr4aLCwU9OladpeCDh4dws0ysYeqSaHlL5gsxnW9POn2hFBRwyc7/oFrg2tIAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5347
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The debugfs_create_dir() function returns error pointers.
It never returns NULL. Most incorrect error checks were fixed,
but the one in tool_setup_dbgfs() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/ntb/test/ntb_tool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
index eeeb4b1c97d2..4fa69ea4331d 100644
--- a/drivers/ntb/test/ntb_tool.c
+++ b/drivers/ntb/test/ntb_tool.c
@@ -1495,7 +1495,7 @@ static void tool_setup_dbgfs(struct tool_ctx *tc)
 
 	tc->dbgfs_dir = debugfs_create_dir(dev_name(&tc->ntb->dev),
 					   tool_dbgfs_topdir);
-	if (!tc->dbgfs_dir)
+	if (IS_ERR(tc->dbgfs_dir))
 		return;
 
 	debugfs_create_file("port", 0600, tc->dbgfs_dir,
-- 
2.25.1