Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 14:18:50 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Cc:     Yang Rong <yangrong@vivo.com>, Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: Re: [PATCH v3] mtd: core: Fix resource leak in a
 for_each_child_of_node() loop
Message-ID: <20230712141850.0f30c70c@xps-13>
In-Reply-To: <ffc8f6162a863179f88304ed8801d44f@milecki.pl>
References: <20230711020752.2344-1-yangrong@vivo.com>
        <ffc8f6162a863179f88304ed8801d44f@milecki.pl>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rafa=C5=82,

rafal@milecki.pl wrote on Tue, 11 Jul 2023 18:37:42 +0200:

> On 2023-07-11 04:03, Yang Rong wrote:
> > Ensure child node references are properly decremented in the error path
> >   of this function implementation. =20
>=20
> Nitpicking: it's actually a /success/ code path that misses
> of_node_put().

Please also add:

Cc: stable...

>=20
>=20
> > Fixes: 2df11f00100d ("mtd: core: try to find OF node for every MTD > pa=
rtition")
> > Signed-off-by: Yang Rong <yangrong@vivo.com> =20
>=20
> Acked-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>=20
>=20
> > ---
> > v2: > https://lore.kernel.org/all/20230710061412.2272-1-yangrong@vivo.c=
om/
> > The modifications made copared to the previous version are as follows:
> > 1.Optimized the expression of the Subject, making it more accurate.
> > 2.Optimized the content of the commit message.
> > 3.Add the tag "Fixes".
> >=20
> >  drivers/mtd/mtdcore.c | 1 +
> >  1 file changed, 1 insertion(+)
> >  mode change 100644 =3D> 100755 drivers/mtd/mtdcore.c
> >=20
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index e00b12aa5ec9..b02cb8b1a38d
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -591,6 +591,7 @@ static void mtd_check_of_node(struct mtd_info *mtd)
> >  		if (plen =3D=3D mtd_name_len &&
> >  		    !strncmp(mtd->name, pname + offset, plen)) {
> >  			mtd_set_of_node(mtd, mtd_dn);
> > +			of_node_put(mtd_dn);
> >  			break;
> >  		}
> >  	} =20


Thanks,
Miqu=C3=A8l