Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 14:44:36 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Miquel Raynal <miquel.raynal@bootlin.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/27] thermal/drivers/armada: Convert to platform remove
 callback returning void
Message-ID: <20230712124436.64lnwv2kuglnbvuz@pengutronix.de>
References: <20230712081258.29254-1-frank.li@vivo.com>
 <20230712081258.29254-2-frank.li@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5rqmpg5rl7chtpsx"
Content-Disposition: inline
In-Reply-To: <20230712081258.29254-2-frank.li@vivo.com>
Precedence: bulk


--5rqmpg5rl7chtpsx
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 12, 2023 at 04:12:33PM +0800, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Cc: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--5rqmpg5rl7chtpsx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSuoDQACgkQj4D7WH0S
/k6mzgf/XpKByt+Ewo4xvdgoQLiLP2AMe1asCE7Q6NlLXz18dRQ7c/zfeby59HgQ
Tqysw5QMkWeKv76fCfLUTZvfH6Vnk1nwdWGdQzKu42OcRZEWHugDWpnJti28CLKd
Nf/IcfMi9F/qp6/axd2X2kDq6lfDfXY9nYJbqHYI2dBD79ved6gcI7splbC92FAt
CvDKfXMMsCDxrPVJIGfpYCG47NpQwvjL1minSTDh/bOI1blrt6OJxRRAUaZ24LBn
FstB8H2e6w+zECEUH8xbJBbbw9AqEZCCTxEj9QcYzbgeXVDcpjlBBMEFYZsem0Zn
73Om5+a1SNPngkKv47/+v+lUrKKgAg==
=7ExZ
-----END PGP SIGNATURE-----

--5rqmpg5rl7chtpsx--