Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <brauner@kernel.org>,
        Carlos Llamas <cmllamas@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] android:Fix error checking for debugfs_create_dir() in binder_init()
Date:   Wed, 12 Jul 2023 21:39:07 +0800
Message-Id: <20230712133920.9509-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vF+l4fzBmvCBn7uAQYVKJClIaURg3cTu7tBub2HNhEnpCXkrQRxthnRE7ReZ?=
 =?us-ascii?Q?VBh145pHBsyA2h/xeZJ9lBcCByqmmsCe+kXRDzbmDRS/MpZoEXnsy87cUYPV?=
 =?us-ascii?Q?j0QqGHHNMzqd+IXbVZ2kXvK9ozz/RuOnD03v4gbz2iU+BjEf51R5QEX4e0of?=
 =?us-ascii?Q?d8QSINUL3H47975NNphNf+gItKba2ubCGKzHVoFj39gfi125R2DJwscR/wM/?=
 =?us-ascii?Q?SA2IaPuz+QdyABgveiye3zV15uI2pLCNfnStk3Ww70J4kuotiGgNnRHG6UzK?=
 =?us-ascii?Q?EmD6KwI1qChAMvstGFZTWhURjLWDfiGuwQbnZmtrUiwUX8C3X0rKGu+4c6wd?=
 =?us-ascii?Q?0IhCCgGwX31Daxc+dbfmJyY2VVNGhT7QkIbxh9IArvMc1EN/7r6Dywc1xjxI?=
 =?us-ascii?Q?GSjQelv1ZB6KAiaTDyDiThvLTYK0wV7l84GVWTLh0VvxIiE+26fiLS8k0fq/?=
 =?us-ascii?Q?CUjpCgZj7jEwrCRI2FcgMbEVsBxO71VkWMu9REIVLlY/S8kaI0JwuheNXt8P?=
 =?us-ascii?Q?p4ZCryI3/cOxsPVCizsMeZt0uN2jC6uu12Eeo5DunEOlldOl1J0aIGpqhEQq?=
 =?us-ascii?Q?maHWk9NoS10X852a5i2R4trg+pBMD46E8XCQHywaHZPMdutEp6he6GjYgIhM?=
 =?us-ascii?Q?OIV6s/q4Gguk1ZugTJjgByISOj6hNLZlLFaQWOCaN2nclFJ16ZKnwYt6eqYU?=
 =?us-ascii?Q?bx/rMCilZ6qEwM9tKNsI+1EUqVCvAC9lkMslQ3j6zkDI/UXxf4xsIGYyCWrI?=
 =?us-ascii?Q?rFMtBBRPqDR1GsoH1iObLhv8LABDJ7Mf37xQ9R4GSTZIJFBTgQF+nAU0jnJC?=
 =?us-ascii?Q?Tt6Fg7J6WfpNqWB3/z4NtimYwHO5oKWpg0gt1md8DH8cWvGVwPSNjEloCMiK?=
 =?us-ascii?Q?p9bjsAHvVs/hGSJS3nRJzSpe7qAp7IAlFrshneEIeQTK672mMh0dh52HMgKO?=
 =?us-ascii?Q?v+EZjEcTRPalTJbDYN9b8McEAImUZk8NYBCRvk35lIDAbszJB5Q4nEFGiGAs?=
 =?us-ascii?Q?2lgoo1i5sPRj5tiegpatBGFZCautaIfhyURFF0XUMtRF8X60RPdKjU9FeXEL?=
 =?us-ascii?Q?yEi/iK7xpMDM4QgL/NfsvbkwTqIy/dZqJWlQJeCpIxjobGFmYBja/9rNFtDk?=
 =?us-ascii?Q?+mOW/pbR7u3L3WnDmq4+e12cxA6qxui1Nh2ms++02VafauHbGbWY6pSNd3ty?=
 =?us-ascii?Q?6Ihl6tiy4Ic4HsvSpBv9pCE/e6DnkoLPAerHGghSY/15vYEEeepabXEJpyKe?=
 =?us-ascii?Q?RYOwgbwQZ0f8IIaH5Ol3Z9f7CkhjMVZgcL8xpoWgswrvl0f5MROvaSZ7w1Il?=
 =?us-ascii?Q?17UsEhNpdMErOldFEBlxatRHYE5LGgHLHkC3RCWgSnHZbHwK0ysd+7SeNCyp?=
 =?us-ascii?Q?/hJDmEvnzXjEpE4SqIssvMSSdJ7R0NQ9znmkVUpt4ZIpr/Hbt7XjN4HeGNdZ?=
 =?us-ascii?Q?azzIF1Vf0ncp2cHM28aWgjOG4Ex+BFqEKzk/USSNdDiJUA6iNVBTOPlhEqo8?=
 =?us-ascii?Q?MlIzSdZ9X2+DIMXUQ3b5+aOf8t3HU/jjg4soOBqoRUhol2e6/JbjJt2GUAKX?=
 =?us-ascii?Q?A2+N4e22NckHO+BQtelpPiRvI4u8Cf9WnKOhtiEG?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 341ce5a2-c07a-4618-1362-08db82dd7014
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 13:39:38.4569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OfOI69Soc/KMHx7SNnZ4cfZOIhqf2ixXDoqAI8Ifg73CGbUoIWNrLSRR3uCHe57BUvYtUOhufydRmZQDNHEy0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5655
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

debugfs_create_dir() does not return NULL,but it is
possible to return error pointer. Most incorrect error checks
were fixed,but the one in binder_init() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/android/binder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 486c8271cab7..3b5309484df6 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -6566,7 +6566,7 @@ static int __init binder_init(void)
 	atomic_set(&binder_transaction_log_failed.cur, ~0U);
 
 	binder_debugfs_dir_entry_root = debugfs_create_dir("binder", NULL);
-	if (binder_debugfs_dir_entry_root) {
+	if (!IS_ERR(binder_debugfs_dir_entry_root)) {
 		const struct binder_debugfs_entry *db_entry;
 
 		binder_for_each_debugfs_entry(db_entry)
-- 
2.25.1