Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Wang Ming <machel@vivo.com>,
        Liu Shixin <liushixin2@huawei.com>,
        Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v1] bus:Fix error checking for debugfs_create_dir() in mvebu_mbus_debugfs_init()
Date:   Wed, 12 Jul 2023 21:23:28 +0800
Message-Id: <20230712132343.8802-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?of6gXoO6FA1kdn0JwcyE8BEWGsjjbNWeu6f39VDJBZMD/3KqPTtl9vTmUqgt?=
 =?us-ascii?Q?cjQQHDKhjN0HXYVQLiy7/n7KArvZ11SztBTSc3XBnfQELb7qxNRPAIagqeMP?=
 =?us-ascii?Q?d4GKqLeyU78sSeyCjZAb99Sl9NbHqnxRb4/jMwEZKwFk0un+2s1v2AYiH4PO?=
 =?us-ascii?Q?PeqnLyCX55foUjVwtt6fLE8kuOtKEbFxahJhLZ9X9/9fqGtwDRqJl3PlfHeU?=
 =?us-ascii?Q?M727UCa/mbiXemG6/AgmG8wwgnIQDedgZfKqKe/9QW7qsddMP6PLXtXdJ3v3?=
 =?us-ascii?Q?OVyuAaU1Zig+588+T9ZXjDDERzsqb8uz6r+DeYv9r9eeBfh7X2nylsbQhbDY?=
 =?us-ascii?Q?PbkqfhF1Sg9f4AMjYuvWdGYA/uXBue0G/RJEguyONh2ILC7KxhqBj12kOCIG?=
 =?us-ascii?Q?AtF64neNuPC3HWfC8kN/CeXf6CmgSJMd1hnzDHX6GRti+zUbfqvEmP61rNw0?=
 =?us-ascii?Q?2voR2bdAYUjuEidXwfmE9ZqQCexOyr+CtUbS+MiXh7xYtiQ8XihQlipbCwRa?=
 =?us-ascii?Q?rlo43pEeXsABOHBk3x6omJXw9yS6JTvC5XE5KZ3JHpRDFMDvhImDDVqs8gvG?=
 =?us-ascii?Q?RMNXrQZfbvv6JqpYfK6llXkgSEvtGEwvaLENoGKoAPoI2XH9+XtrE3HycOLY?=
 =?us-ascii?Q?7msHjoo+D4HZ6+EYfKITBAeVJXMwOzpVeOYlA+8w4+yfpPZvIH9ZfQApzhz/?=
 =?us-ascii?Q?f3PZkmfgCKjazw62cshhsf5QAmR0npDP+Eeg2dohGJc/yu6UNypFKMbFLEMp?=
 =?us-ascii?Q?1ZfeVeRsD1OpEkmYZLKCLNHfihjgIymWUPcIVBIsnz/syP57FReYtxLlFdhF?=
 =?us-ascii?Q?2eWOlATsIJfALqSYQEeE4sZd5acW757xtcr18bWMnbxEpS+BfDm3kPYTGN+L?=
 =?us-ascii?Q?XJavhiKXR+/EXDVo/ikexiSJ0PfovIFAeRU2fr5cn7LJSL1Wnx5A6bRHX7t7?=
 =?us-ascii?Q?ZzrRCvrvEp/v1VnUWNp9LN5KyGEA7j5AwdkQgyaJkgs7OrL8sQjwPjq6aE1t?=
 =?us-ascii?Q?wyD9DWHfUCkeIDAV2y66eGssRnHX2aJjAx5iafshXjpOHvVRSUt58yaJCeM2?=
 =?us-ascii?Q?nZK4a5wvxEgh/UUO4rFoikxZgvcCPxV7cU9hAbIQKAxTDjeF50x8JTcQXc90?=
 =?us-ascii?Q?yjxBU7V4v+nPgLHDfmDrA+T8YZ82GOIUfYZZiXjUb+LAOTQVABovSk2kvizD?=
 =?us-ascii?Q?vpsIvBEcCnwiQKOtz+Xwi/Ui9t68qU6746+K0Eh6QDy/grhl20pKMFc7zXl9?=
 =?us-ascii?Q?SYqtb4tlFYfhoZg7bknKM39sqe6PumGjYiVBqX0FLWEINKImY5As+I7Xj52D?=
 =?us-ascii?Q?wUt/W+DvDlABeBeUF3UetzzKqmbaDUmwjIV5sYM5hS68uC1BntHLSo9JVHek?=
 =?us-ascii?Q?3CegAe5aG1Ho7lV8FAwlGAU0wC3TLx0Tz0XnOp3MSmACW5etvzigTOWFpDGm?=
 =?us-ascii?Q?mKtsRcLq8wNd8GVVSrkBoVm9nokkhr7HbcaMYjICJ91iYPq8Rnv8pQc+OtUD?=
 =?us-ascii?Q?WBhS4UlcxB2CFb+m0pTZNlZpTGB2GZadsNZ0ZOvF+7Rx6jlqjbXk3zWDOSK/?=
 =?us-ascii?Q?CRD/VQmTLd775gPm+5jGkqESFWtV3X7q7+1Mh5xw?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac34f690-b390-49cf-38e3-08db82db4dfb
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 13:24:22.4337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Asi5ZUEsTvPcntTZp3T+5BPPunOrLPhP5fSWo/DvLWMNcMaCAewOm5kj2lNXVUQs7TgyQ5me219KYdbXnvqzLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6339
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

debugfs_create_dir() does not return NULL,but it is
possible to return error pointer. Most incorrect error checks
were fixed,but the one in mvebu_mbus_debugfs_init() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/bus/mvebu-mbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 00cb792bda18..4c514894cc1f 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -993,7 +993,7 @@ static __init int mvebu_mbus_debugfs_init(void)
 		return 0;
 
 	s->debugfs_root = debugfs_create_dir("mvebu-mbus", NULL);
-	if (s->debugfs_root) {
+	if (!IS_ERR(s->debugfs_root)) {
 		s->debugfs_sdram = debugfs_create_file("sdram", S_IRUGO,
 						       s->debugfs_root, NULL,
 						       &mvebu_sdram_debug_fops);
-- 
2.25.1