Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Sebastian Reichel <sre@kernel.org>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Wang Ming <machel@vivo.com>, Arnd Bergmann <arnd@arndb.de>,
        Miaoqian Lin <linmq006@gmail.com>,
        Yuan Can <yuancan@huawei.com>, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v1] hsi:controllers:Fix an NULL vs IS_ERR() bug for debugfs_create_dir() in ssi_debug_add_ctrl()
Date:   Wed, 12 Jul 2023 22:07:24 +0800
Message-Id: <20230712140739.10606-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y02R4NKsFmwdk+kUhVYvqHflOXrEtUijsXk5ZEysOm2zeOLaV33GSXamsuxF?=
 =?us-ascii?Q?hzTZEy22u0nHL3feC/N+7uzyz3DIkjzsVIRaLnr6m5hRkdtVZJx+NDC8DSoJ?=
 =?us-ascii?Q?0HdvEJ5zDlhLuaB8lVACL56HF4jMYdYXXIar+H9mQjtZjFhnkO37AL8cho5P?=
 =?us-ascii?Q?oiNSmiuU7cTaGudPrxkuASpXHWXjc65HmqSAjWOezCISLFX1T86SfDUdCpII?=
 =?us-ascii?Q?bcCoLEKDBrhr5CcQkt5+Tbd+7T3NwhEEz9/7JS7wbwyi+H+lCGdXF9m3bjC8?=
 =?us-ascii?Q?A9BDQWQgaPHucng6cHKkimqaCu04DH0VA7MPgwZUV/r/pxJiK/4xkTn9UcqD?=
 =?us-ascii?Q?TIWX0MDdRifgy79MUwfEFPXRJ3QYfH1XUQMKMYPF7+Cuc5pLJb9kc0evsABp?=
 =?us-ascii?Q?AM+1U8eKnT1OxPx+V8ZXmNmEuOq+CnbdxGx52i0C+Qu+/HZe7iPgwL1TAmC4?=
 =?us-ascii?Q?X0b8/5OJn98cWs/mT/xw0dTb7YtznubXgXQZmhldrGcy6U272sMan3UBwGPZ?=
 =?us-ascii?Q?CXm1zhMe6rj/GQd3iXhMG0YSMcXZSPr8tsp5EJ3F+voLvu7+BH8Aaok4et79?=
 =?us-ascii?Q?JC6yHwID5qgUuOPWqMNVRH5fochXBFyVdNX78jt3vGZVfWJPdjMJJ6U3rrHq?=
 =?us-ascii?Q?xVYNhIBOODmaQlIdRZmc2fnUEmiD9Va7iniwc5ICUbY72E/HdQ66JJZtP3u+?=
 =?us-ascii?Q?4HDE68MZ4h0HbotZpIHMtzGvwilZtFdEqrpERMXzbs3mjp053GQYzjDrccEd?=
 =?us-ascii?Q?WqPl4hczidFib5+v2u5flDr4t3Pwv29hHu+dCHuT+JIvNnQD3IxpdsxGAlyv?=
 =?us-ascii?Q?HCzbGNVkH30pmc6tXnHUVkicbxzTJMzj2+Eiebi6fe54N2KtPzKm92KhbDbD?=
 =?us-ascii?Q?DMndrdjEMV1NAMb0SEC+UsWfpCaeHJ5SvzLRqawyVuD4HiPXr2zgUvl0ithe?=
 =?us-ascii?Q?J53TbSoC1C9u4f1JibPrXfd+tL6inWda7q6X6YQlM5Zr2VpKo1bjWJP3wrJe?=
 =?us-ascii?Q?rrjVldQw6dQctrwlzj1InyRbwCoI1OK4umdjQzB5NakePQdGSbQFYugF+ufa?=
 =?us-ascii?Q?Hh1V5sZ1xxJCi9iukrPA+gQRAs+LM4vu+H5OiWZJbJw2NwoQDa5J5K4X4VoK?=
 =?us-ascii?Q?1Nh/aYdU8NpE2BK3nSuf/lFPnB7r2YTA37ODajhSzprvsIU/FzxLiB9iBb1q?=
 =?us-ascii?Q?/3Eq+LT/pmt5ZxP7yrYGH/T/Sf2V+E3R+U59X4+cG2HeYGji3xlOzOZZq3Mu?=
 =?us-ascii?Q?0gE6C/HSoSG3654wRZHQxn91AYPF7nHpUhMdPhXzATx9zfRrHRSTXI1DKZZ5?=
 =?us-ascii?Q?HdWUvYUFi64fBfV5rREr6zhkHFM/4O+oM9VepNgU5CiBHfvORraJVMPq7+qN?=
 =?us-ascii?Q?VBCzPzDSNGM1CuXm5a/PmtJ+JW7v2b44mqbXsb2YSBawVJ9PSmjvHziuhYHC?=
 =?us-ascii?Q?GHcRNypKwfQfjfZX9LGPagVzIeqM9xMTeqMrQ/oCIA2TMES4fbYV+7PYYZqk?=
 =?us-ascii?Q?O7NqIZlr0HSgZy0ShC29CXAgUZ9jdpL53q71Crb7PolNZmqjMFurOwCQbtOK?=
 =?us-ascii?Q?P3FT0JGq0p/+vjx8nnDVTxcqulu8K9tuRXNpg8Rq?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ee4b7f4-3f47-4619-9c6b-08db82e15fc0
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 14:07:49.6945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OyZCbP2cMOifUA6OC1gRfrAAYb/utPVDemkaupVaKXc9sM4Whke/6j1xZsNMRtWRbn4redKhCoAs/87OKiN+mQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6165
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The debugfs_create_dir() function returns error pointers.
It never returns NULL. Most incorrect error checks were fixed,
but the one in ssi_debug_add_ctrl() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/hsi/controllers/omap_ssi_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
index 84ba8b875199..a39bf323fb1a 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -115,7 +115,7 @@ static int ssi_debug_add_ctrl(struct hsi_controller *ssi)
 
 	/* SSI controller */
 	omap_ssi->dir = debugfs_create_dir(dev_name(&ssi->device), NULL);
-	if (!omap_ssi->dir)
+	if (IS_ERR(omap_ssi->dir))
 		return -ENOMEM;
 
 	debugfs_create_file("regs", S_IRUGO, omap_ssi->dir, ssi,
-- 
2.25.1