Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     David Hildenbrand <david@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Wang Ming <machel@vivo.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v1] lib:Fix an NULL vs IS_ERR() bug for debugfs_create_dir() in err_inject_init()
Date:   Wed, 12 Jul 2023 21:52:11 +0800
Message-Id: <20230712135226.10041-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k255KQ0pd0jLD29zK7nPN6dz9BPKBNt4vWusEL5lsNoI3nfkhyi+AfD9yaL5?=
 =?us-ascii?Q?kxc0SxKDStXpHeKVmby415mZaItx4iEYs3iIbcl+gG5mIU3ybQ/s1BcdKHsW?=
 =?us-ascii?Q?sITMgrSxI+vuN31HfvL0U7mPC/tySTXM2n7rLmjSPeWOV72MRZJY08DxT2Yl?=
 =?us-ascii?Q?xLc4+V6ocN+wwPA+PdkLsL3f72CR+OsnNgDcjXolyCGZ6jX7T0ga20HYjFbk?=
 =?us-ascii?Q?2pS7VYJ7b2i/zGEeG85SvkbDzuC1aULMcRNlFUYQ+kRGG9lslyiFpobwyslG?=
 =?us-ascii?Q?vC/95pI7nY2Z4+DHkIWTu37SabApR7wfhoA35eTN0UmkOFdcgecn9g+GqTbj?=
 =?us-ascii?Q?zcaC9H67DkRYRc5oTf7p+7zm4P571SP4zDk+pbSTjcmMp0pdY7m7yytfik1f?=
 =?us-ascii?Q?A77R3fkn3UVApsQyTKfKuVgADrNERPveRGS2S8AmobgBzwnfgWprlnoRw3fc?=
 =?us-ascii?Q?X4/rc6XhsVEQfUaLvQAmiIBQdX5Rtf8ugTVj39civUds/2QyAAg8DzTo4oKE?=
 =?us-ascii?Q?jIotfqNTui9o+2oXxaq2avhbYtoTRs7fQbehvWC7iWcFuG7CUnAI6gk/41vH?=
 =?us-ascii?Q?vEzIIPA8Sz0rC//iP872892uJqZSzxGZ6kMFZh2V1BxNTfKyhwDf6HaQt0OI?=
 =?us-ascii?Q?4Uc7JNAOXenCDyexCBpGEhfHgQsf/Xl+NxTTXYVjcmpSUBgq1fXPc1sOmFi+?=
 =?us-ascii?Q?6jAF6fXFCYQ6jED9zCm/dGrOZCWwOVanp2oyPyP/i3oU5Hfr/emNHEfSmxQk?=
 =?us-ascii?Q?4X046xH94uGfTMr3rA4ILj2AKQeMn80FqvEFBFV+XipcZTXkwiGvqoy2Nyr/?=
 =?us-ascii?Q?lvQQHGnx6pbXcywRNEJgSGyoXgvU4bMKzBcXBrfJvE932KmfkeL3Im7j15ex?=
 =?us-ascii?Q?oWHWPZtQFOyYfCL5tDxeMaWOTJrmiJ/adzkH+v1SsFE/NTCw1EhFvrBbdfFm?=
 =?us-ascii?Q?lpK7N1AFvB/mNUplQ8dI00mkUbNmoqBRFJHW3mCgqg4iIJSxdGpmH7DdoKfq?=
 =?us-ascii?Q?NOe4AyxVL4ydT2e3Q0b2HLUp4r+qnOtWchCHQPCsyk376fgsVL8k4g4cwdf3?=
 =?us-ascii?Q?Vy9xBIWPSE3j0tYbvtiWNcxZFToao+c0fdDDTshhMf0epxiyn/LYiZ1Z7oZh?=
 =?us-ascii?Q?qGGVXS4QNa9OaDuqfUUPv+hWV6z4yqsKL61eM0OYvbCytvxIBI4Z8Gm5m9XZ?=
 =?us-ascii?Q?8TM/ril1LfckKVCSM2W2BY0HP0uGKY9Rnhl6KigYiDmrKoVO0fJIdP0iUBx1?=
 =?us-ascii?Q?sCJ8cKlL9M1xhRRiGmjTmrtqUJPF5i469Ik5Db7Z7NLVcIF6vvLyeT5jITJl?=
 =?us-ascii?Q?X43DUeC3GNa8gUMVm1p2XhxTivJGN20XFR4QH7/rO1nq+v3qgrI/eCJeLpj3?=
 =?us-ascii?Q?1MKIG/SPHCi3/KH9VWX3jQ913CDA6nzvVEwH3X/YbdQ8exSwFgBGsJ18Y0O1?=
 =?us-ascii?Q?NuHlokEpe1z1ENlnGHbB5URP3Ou/FcQwtDidGQlWf78wKusR6e9vSsiTBkyR?=
 =?us-ascii?Q?Y+ZmhYLeX2Be2ciew+mZHmZYNomaTNiBF3NaXUhNrot3gbmJvRoFWKm6ej7T?=
 =?us-ascii?Q?V6LTxGaNJixKQiLtCBAZlOlOpfp6wQ1UgJwtNDgy?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3f1553-08f6-41e5-6bad-08db82df463b
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 13:52:47.2476
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oa1I58f40Fd4dSHpTPYV4HRrKkHAM2Q8p/eEkkfZkvLXYCtuVNm+HSjw9E4vFTPO5CYtUF9nvfHMy0breu6dDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6762
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The debugfs_create_dir() function returns error pointers.
It never returns NULL. Most incorrect error checks were fixed,
but the one in err_inject_init() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 lib/notifier-error-inject.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/notifier-error-inject.c b/lib/notifier-error-inject.c
index 2b24ea6c9497..c49354c23802 100644
--- a/lib/notifier-error-inject.c
+++ b/lib/notifier-error-inject.c
@@ -83,7 +83,7 @@ static int __init err_inject_init(void)
 	notifier_err_inject_dir =
 		debugfs_create_dir("notifier-error-inject", NULL);
 
-	if (!notifier_err_inject_dir)
+	if (IS_ERR(notifier_err_inject_dir))
 		return -ENOMEM;
 
 	return 0;
-- 
2.25.1