Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp38449822rwd; Wed, 12 Jul 2023 07:52:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlFbZvBZzllvDGUA6FMRpflJSx7+xlzHRnyoy5GeCBCgjG/FCa93e45Sr7gt613jAMQh8p1j X-Received: by 2002:a17:90a:5a47:b0:263:c0f9:451c with SMTP id m7-20020a17090a5a4700b00263c0f9451cmr14347499pji.3.1689173538001; Wed, 12 Jul 2023 07:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689173537; cv=none; d=google.com; s=arc-20160816; b=A6evkRE8wVdkSkPRZcnfLoxouwXPUgv1kPRu3H4ITUfvWbR61HfJ9VeCp63zLIhc8E hPac50sY5KY3Bfiambe3EqMw2q1ReIT5Fzip14BDZIxbseiuxGncqv0Wtp+pXgO4t21z Yhf3twcf6W8BmlegCedeP6OT9CSK9eVpry/V0z0JduDyTVlQAGyIGRn4XCqbjW7gper7 TJQpZuQc8yt60X9Z11uiZB+RzFn5IXrbXIGkKhPru/iw+id8yT70rVzGepIbZntN5IaL 2jPNCM5Ex2Si0TQxLiLwXoDQ+udUIOSIAn43RpT4aswDmy8xnT212kcgISoOjW2Ejc7q 39mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=f3+120nI0qsDe1YJ27JG6TM/bhTy85me+uHT6vnbIBE=; fh=NzhynLmRCbp9nPTK70cNVeCY8dz7hxT48qj/kthoNnc=; b=aOLIcNSM1SfNMzMdpi63iow1BftfIz6ShJdqRO5zhwzd3rycJhSYFH0cNmqgwf+P8R C7RpGCxJxuhCN5m3vhCy0haf56y5FIdy1dFveKX0XIj1TetQWyoKZKCdQtNWzDsCbyIA 49SzvItX0j+87T8puzLAJ3sHHzBLrPgq0jcKOcZm/VtjgWKP3oS4OPaDo7d3Fc9hI7Cp 244B4MaoOM6eciRJd8OBg46jHHGU5asVsQsVkdJyVzGO1UdHRqe6uIdk03R+ufI48mys HaXUzzhp9K3JuB1vHcJGH5NO+ysbLW3cMFq4WJxoPWtHz54H0btjXtp8l0biRDyEicFj gg/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=zhBomEzA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a17090a008700b002637aa0a4dbsi10466803pja.103.2023.07.12.07.52.04; Wed, 12 Jul 2023 07:52:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=zhBomEzA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231797AbjGLOmi (ORCPT + 99 others); Wed, 12 Jul 2023 10:42:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjGLOmh (ORCPT ); Wed, 12 Jul 2023 10:42:37 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FD84BB; Wed, 12 Jul 2023 07:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f3+120nI0qsDe1YJ27JG6TM/bhTy85me+uHT6vnbIBE=; b=zhBomEzAEIF6Wet6D0dCEHoDc9 okuiGV0HJ0zEb/6g3KT+kSOccac4dHYgXzgmsDXpd5wZ3ei7dOc22BhinkP4+RJ7NCVBTzXcBv0a+ mkdQEaNEfbsySg6JXBXksLnyMs5HzC1sQyuqHi9VEKswmzd+kYtoaru5bwiCoPxrcZUBp1cO/xy0y bCCdNiZ53tTwhsypKPiuSuZw7PiowQJiG+Lccs0ykZtxq9QACS+jqeeBsft5s18KqNPAfTUUX1Wyk FGYopr5EI2NQOSV19zN5vF0sLOsQE6sT2ANw/qeJXOTthiv+T/qnW2z43h+s7zvVxmvcr5LASvDU5 VUeU2pGA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qJb2z-000EDU-2z; Wed, 12 Jul 2023 14:42:29 +0000 Date: Wed, 12 Jul 2023 07:42:29 -0700 From: Christoph Hellwig To: Kefeng Wang Cc: Andrew Morton , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH 3/5] drm/amdkfd: use vma_is_stack() and vma_is_heap() Message-ID: References: <20230712143831.120701-1-wangkefeng.wang@huawei.com> <20230712143831.120701-4-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230712143831.120701-4-wangkefeng.wang@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 12, 2023 at 10:38:29PM +0800, Kefeng Wang wrote: > Use the helpers to simplify code. Nothing against your addition of a helper, but a GPU driver really should have no business even looking at this information..