Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 17:05:41 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Prathamesh Shete <pshete@nvidia.com>
Cc:     linus.walleij@linaro.org, jonathanh@nvidia.com,
        linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: tegra: Add support to display pin function
Message-ID: <ZK7BRXa9geC8SAGs@orome>
References: <20230712135553.25162-1-pshete@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="2YdKNK7uOPK99Kng"
Content-Disposition: inline
In-Reply-To: <20230712135553.25162-1-pshete@nvidia.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--2YdKNK7uOPK99Kng
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 12, 2023 at 07:25:53PM +0530, Prathamesh Shete wrote:
> The current function for a given pin is not displayed via the debugfs.
> Add support to display the current function that is set for each pin.
>=20
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> ---
>  drivers/pinctrl/tegra/pinctrl-tegra.c | 19 +++++++++++++++++--
>  drivers/pinctrl/tegra/pinctrl-tegra.h |  2 ++
>  2 files changed, 19 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegr=
a/pinctrl-tegra.c
> index 4547cf66d03b..2752c914f628 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -96,6 +96,7 @@ static const struct cfg_param {
>  	{"nvidia,slew-rate-falling",	TEGRA_PINCONF_PARAM_SLEW_RATE_FALLING},
>  	{"nvidia,slew-rate-rising",	TEGRA_PINCONF_PARAM_SLEW_RATE_RISING},
>  	{"nvidia,drive-type",		TEGRA_PINCONF_PARAM_DRIVE_TYPE},
> +	{"nvidia,func",			TEGRA_PINCONF_PARAM_FUNCTION},

Device tree bindings define the "nvidia,function" property to contain
this information, so shouldn't we use the same name here?

Thierry

--2YdKNK7uOPK99Kng
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSuwUMACgkQ3SOs138+
s6FQDRAAoK6Esw601lrSBOA9hLHuIBHRbnjQMnKgSZdA8eiMozPTc/zNQE7y48NV
coFrEGg5SIjmKMxcOIFsifB2VEtBd6R4CgHgvT4LD4IxMar6YhHtBW9uvpzQK4aV
0dgdW4SaFT3nxZDvCQEttCA7a0AzvMMhx/3sWcWPpFKx7ciSNGI+cFoeEQ53eQmC
6rzDpQvG6Wbyb8lypcCXBNyouuHTlpG6wINNpXqsZQGwsDLPRyeTTNTtXFi+ptzV
AM/5kgeNB3Svc7zFvMdvgU0kSux+gp6vziK8qEVeHx9eefGjWxYihMMAXWFHOl2f
Iy21wcyL3o4NK2Send2HJ/iSovJmhzAa1wgkrbYyB62kczl3HhkvAkbukRCv1WMG
zCKoDuyb1u58cDIJ71HQPfOY9ghRWUEUpKb8epwLSMSwOb23TxxjHENTqkiKqVt7
iXoulIqmAoQnVl7WtcD7d8o7ZYcd4kgeqMqjVgz9qJB5rh56IqxR7/a/CTuUGrhW
2/BtfxvKPpAMaa8IrRx1A9JH1fR5SDTN8sdbSMgfQm0tcQncT7ORh8YEtT7i/coO
XV0jqXJXm8l+kHXwgzKm0k1TK52mZjxHam4UgbVfqDm/8dsxrJJHuphnWrEcNHIZ
ToTIa5ulqz1RikLBCfPaH4GwZ6N9imejuFXwNg+cq294c1IbRT4=
=DFoZ
-----END PGP SIGNATURE-----

--2YdKNK7uOPK99Kng--