Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0cc30dc8-64d9-e58d-a436-fe92b8dcfb85@redhat.com>
Date:   Wed, 12 Jul 2023 17:13:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: Add Silicom Platform Driver
Content-Language: en-US, nl
To:     Henry Shi <henryshi2018@gmail.com>, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, markgross@kernel.org,
        jdelvare@suse.com, linux@roeck-us.net,
        linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-hwmon@vger.kernel.org
Cc:     wenw@silicom-usa.com, henrys@silicom-usa.com
References: <20230630203529.GA20585@build.adi.eng>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20230630203529.GA20585@build.adi.eng>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Henri,

On 6/30/23 22:35, Henry Shi wrote:
> Please review this patch.
> 
> The Silicom platform (silicom-platform) Linux driver for Swisscom
> Business Box (Swisscom BB) as well as Cordoba family products is a 
> software solution designed to facilitate the efficient management
> and control of devices through the integration of various Linux
> frameworks. This platform driver provides seamless support for
> device management via the Linux LED framework, GPIO framework,
> Hardware Monitoring (HWMON), and device attributes. The Silicom
> platform driver's compatibility with these Linux frameworks allows
> applications to access and control Cordoba family devices using
> existing software that is compatible with these frameworks. This
> compatibility simplifies the development process, reduces
> dependencies on proprietary solutions, and promotes
> interoperability with other Linux-based systems and software.
> 
> Thanks!
> 
> Henry Shi
> Silicom Ltd.
> Henrys@silicom-usa.com
> Henryshi2018@gmail.com

Thank you for the patch.

The Kconfig bits for this should be in drivers/platform/x86/Kconfig please move them there.

Please send a new version with that change with the contents of the patch actually in the body of the email so that we can quoute it while replying for review purposes.

Please use git send-email on the .patch file to submit the next version, e.g. :

git send-email Silicom-Platform-Driver.patch

Do NOT copy and paste the contents of the patch to your email client to send it, this will mangle the patch and make it unusable.

Once we have a submission with the patch content in the body of the email (with git send-email) then I'll try to make time to do a more thorough review.

Regards,

Hans