Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp45340rwp; Wed, 12 Jul 2023 09:26:38 -0700 (PDT) X-Google-Smtp-Source: APBJJlGAZErBY6TwJBtOVJwftbiW4/LUJSOeanaqu+KVYTBFYlLitirqCBou/5ca8OEYdPRPys2x X-Received: by 2002:a2e:9848:0:b0:2b6:a3b0:f4d3 with SMTP id e8-20020a2e9848000000b002b6a3b0f4d3mr16316791ljj.26.1689179197833; Wed, 12 Jul 2023 09:26:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689179197; cv=none; d=google.com; s=arc-20160816; b=ubn7YXgp/UGPVZOeOhl+7ZYmH8seliUDy8fA14ZqKJSAlj7MpBaUY39yF4ZViwcIST I5kGtI2/PhrPpwZrQ4x68n+FZ2q16rx8KJmfZ67aRFedPZg60aMC8ptNB78cyV1bFSEi 8l0ArgobssO0kIAYpEkgddl5E3+ew+e6nsooz5CeXBK1g73YdjAjtgWRXwavbXbhqf19 pIIOxkyP9FXXp6LgaJXIdoPqU5dOmAhb546xOeYtpWT5jp6+EYleFtW4fhtJ72oTJqYS iABfFfdC9vcxnEnVvfKYrUze8nXA+rXRd6M8YUZgAlST3NOF/jlDBxcPfj7KmwrAF1kZ 9QSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=bkK/lE9xVUoE2L0I2FE1bsKN4N40S5rUCyjcnz9lCPs=; fh=z4N4tEJ53LjbZ0+ulXhB1YbeLvGw3RqElzB311OuGSE=; b=Bkj9h4sMoxglu6AzcO/PIgO7QfdzYZoo4zEtehPrft8MAhxbqTe/M8Hw+KZvCL6kZf I4M9JNzX2nGTLex6PBb43PIgzMM4duDQYodr05y5HgHBTeM1yOfO5T8P4ggFU7fZPlCK uZfKI/aKKPVRXmOTbu0V/kVCm1f97qR/IZya+v51E9l+UYybgCWjOV3c5KaGfivfVP+L MhmGZsM5ktjTlSNG/MIPyoGUG1XKKRDo4m3geZUGgjZZY20btrTvn9VIEt8f6FPOFT16 3xZdA7MglPHz5HnPOA6Tovi9PPSckB6SBcsFWukKRgDquPRLPwvlKZ8iN70rlu4pUtiu dgwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f7JLtL4N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ce25-20020a170906b25900b0098759d6f22csi4980968ejb.161.2023.07.12.09.26.13; Wed, 12 Jul 2023 09:26:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f7JLtL4N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233815AbjGLPuE (ORCPT + 99 others); Wed, 12 Jul 2023 11:50:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232835AbjGLPuB (ORCPT ); Wed, 12 Jul 2023 11:50:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F1851BDA for ; Wed, 12 Jul 2023 08:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689176956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bkK/lE9xVUoE2L0I2FE1bsKN4N40S5rUCyjcnz9lCPs=; b=f7JLtL4Nap4buX7ad/9Jc+v8WpUjL/db9pCrxc6MJhg4yu8GRfu+sQHdGH4hZVMZGv0ZUH emSvWdNbYmrY+Z9r480wfBozAhy14gs1h6iHMhuN/vQWF80w+WcrtAzroG4gAkP6RvsMcP VldktcV1UTLZk/Vikpvonw75eEKa7Is= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-278-wvhaUxizMxiP9Jwb6MSV7A-1; Wed, 12 Jul 2023 11:49:15 -0400 X-MC-Unique: wvhaUxizMxiP9Jwb6MSV7A-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-30e3ee8a42eso4162739f8f.1 for ; Wed, 12 Jul 2023 08:49:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689176954; x=1691768954; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bkK/lE9xVUoE2L0I2FE1bsKN4N40S5rUCyjcnz9lCPs=; b=QhBNtapunpodthXZ7+iOtuRBsxF/YlNvE2XWJoGYJVQhah1G0iwa8I6o2jSk9e+19k 8ep/oY8dokAh2kRlWUfAkOtkQlP+nu2SUCKUeTUzbPXwi8FMBsDQl8A7aHn6UzSx3Nbm iFiBFvixhalqexfk7EyFYnShWV8M+srEQ2GnK+arAub0O7zZm9Q1+U70cVC7kS3bmhu4 UGbCzwrrw2gZiGL4eb3Vsq703oOtlwcy5XazZhWIfF6ymutR/qzF8P0lEeiAu3H2ajYZ snIdz7Gq0a1QcpFByoVbySYeJtjYr2IXss9a8B+Q9oiLQqs8ZdvDfmWHQxrYcR/ULMSS CSaA== X-Gm-Message-State: ABy/qLanMULQVAv7zJrybWJtRlsn3YbjbIRzhn2WBbXerLvom/5cVXbk /n+Knfce51DdPrrovkI03gXabHnda7zJrB2or0WDr0cdeWLK3D2f30ZUeFvqZE4I3n4zAXsw1Ul 2O1DfxW9TXC6V9vL5IltlDp0Ux6VbHMfh X-Received: by 2002:a5d:4603:0:b0:315:ad1a:5abc with SMTP id t3-20020a5d4603000000b00315ad1a5abcmr2505859wrq.5.1689176954068; Wed, 12 Jul 2023 08:49:14 -0700 (PDT) X-Received: by 2002:a5d:4603:0:b0:315:ad1a:5abc with SMTP id t3-20020a5d4603000000b00315ad1a5abcmr2505833wrq.5.1689176953749; Wed, 12 Jul 2023 08:49:13 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id u24-20020a170906069800b009920f18a5f0sm2732141ejb.185.2023.07.12.08.49.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jul 2023 08:49:13 -0700 (PDT) Message-ID: Date: Wed, 12 Jul 2023 17:49:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 0/2] platform/x86: thinkpad_acpi: lockdep support Content-Language: en-US, nl To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , Henrique de Moraes Holschuh , Mark Gross Cc: ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230704-thinkpad_acpi-lockdep-v1-0-60129548a738@weissschuh.net> From: Hans de Goede In-Reply-To: <20230704-thinkpad_acpi-lockdep-v1-0-60129548a738@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/4/23 23:03, Thomas Weißschuh wrote: > Validate locking requirements in thinkpad_acpi through lockdep. > > Signed-off-by: Thomas Weißschuh Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > Thomas Weißschuh (2): > platform/x86: thinkpad_acpi: take mutex for hotkey_mask_{set,get} > platform/x86: thinkpad_acpi: use lockdep annotations > > drivers/platform/x86/thinkpad_acpi.c | 45 ++++++++++++++++++++++-------------- > 1 file changed, 28 insertions(+), 17 deletions(-) > --- > base-commit: 03275585cabd0240944f19f33d7584a1b099a3a8 > change-id: 20230704-thinkpad_acpi-lockdep-7def9d7f91b5 > > Best regards,