Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 16:53:38 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Ivan Orlov <ivan.orlov0322@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Shuah Khan <shuah@kernel.org>,
        alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] selftests: ALSA: Fix fclose on an already fclosed
 file pointer
Message-ID: <03293bcf-7193-488f-9897-5d96790db55d@sirena.org.uk>
References: <20230712140122.457206-1-colin.i.king@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wVNsGP+PGG+ocxCF"
Content-Disposition: inline
In-Reply-To: <20230712140122.457206-1-colin.i.king@gmail.com>
Precedence: bulk


--wVNsGP+PGG+ocxCF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 12, 2023 at 03:01:22PM +0100, Colin Ian King wrote:
> In the case where a sysfs file cannot be opened the error return path
> fcloses file pointer fpl, however, fpl has already been closed in the
> previous stanza. Fix the double fclose by removing it.

Reviewed-by: Mark Brown <broonie@kernel.org>

--wVNsGP+PGG+ocxCF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSuzIEACgkQJNaLcl1U
h9BkeQf+PybKLN8z4YJie7BNQAYU4xABABxmQKw35R+xYMirTAbNdSteSQV3JRql
i2Z6aQ2e3HTAgx3tXQ4bgpNQrL4Lcz48rJAfMda0RBKReuIz1LfTW3d9ZoUIU0Lb
qYpvkL0Vjf0au1c1nRU6n6eb2ahu7VlJHgChwdB6ueOpBTKLbfpucVvt+dy3X5hJ
MbhkO/cs8jcOvyuzHZB6EjPHcPq1vr2zukAsTzmM0xZ5yxGFhewHpS+tPg7RjGwt
iC+4rv6dD85ZakRYIO5hYkdQhzIy9pOiuvE82+FGyaLSjnPOlwNAO444OHsWtiQ5
2CIxOWF/BIbsTJt+m2zSXOWZ3X8Mhw==
=spEy
-----END PGP SIGNATURE-----

--wVNsGP+PGG+ocxCF--