Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 18:57:06 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Li kunyu <kunyu@nfschina.com>
Cc:     dan.j.williams@intel.com, Jonathan.Cameron@huawei.com,
        gregkh@linuxfoundation.org, rafael@kernel.org, ira.weiny@intel.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: resource: =?utf-8?Q?Re?=
 =?utf-8?B?bW92ZSB1bm5lY2Vzc2FyeSDigJgw4oCZ?= values from err
Message-ID: <ZK7NUpb942858aiI@smile.fi.intel.com>
References: <20230713235339.3090-1-kunyu@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230713235339.3090-1-kunyu@nfschina.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Jul 14, 2023 at 07:53:39AM +0800, Li kunyu wrote:
> err is assigned first, so it does not need to initialize the assignment.

While this is fine, I would go further to make it more explicit, i.e.

> -	int err=0;
> +	int err;
>  	struct resource new = *old;
>  	struct resource *conflict;

-	if ((err = __find_resource(root, old, &new, newsize, constraint)))
+	err = __find_resource(root, old, &new, newsize, constraint);
+	if (err)

-- 
With Best Regards,
Andy Shevchenko