Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 18:50:05 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Andy Shevchenko <andy@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Hoan Tran <hoan@os.amperecomputing.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: gpio: snps,dw-apb: allow gpio-line-names
Message-ID: <7ik5zbqqveaysyruxpipvzuugabzomu2egr74yfl7avg75qyjk@j2rgeu72s7sy>
References: <20230712074553.35907-1-krzysztof.kozlowski@linaro.org>
 <d25vlma6vefztgggatas7ipn36rumhuodzcalfq7c6apwliy7a@ddgo3fgulv2s>
 <ZK7GqJlXhCIcA/J2@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZK7GqJlXhCIcA/J2@smile.fi.intel.com>
Precedence: bulk

On Wed, Jul 12, 2023 at 06:28:40PM +0300, Andy Shevchenko wrote:
> On Wed, Jul 12, 2023 at 12:53:00PM +0300, Serge Semin wrote:
> > On Wed, Jul 12, 2023 at 09:45:53AM +0200, Krzysztof Kozlowski wrote:
> > > Allow the GPIO controller subnode to define GPIO names.
> 
> Are we going to do this for each GPIO controller bindings? Can it be done once
> for all please?

AFAIU the DT-binding schemas which have "unevaluatedProperties: false"
property specified won't have such problem since any DT property with
"*-names" is already evaluated by the dt-validate core. Meanwhile in
this case the schema has "additionalProperties: false" property which
prohibits any none-explicitly defined property in the node.

Regarding the "gpio-line-names" DT-property constraints. Alas it can't
be done generically because at least a number of items is device
specific.

-Serge(y)

> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>