Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230711154449.1378385-1-eesposit@redhat.com> <7E9D397B-439F-484C-B950-9094605A7B4D@zytor.com>
 <5e01b6a5-f993-f99d-41a0-ab671ec598f8@redhat.com> <20230712120002.GIZK6Vwga6DlJqdjEh@fat_crate.local>
 <ZK6hLZcuAH9jXKuL@redhat.com> <20230712132840.GKZK6qiK70m1O90jFL@fat_crate.local>
 <ZK6zdsIbnQFUmK69@redhat.com> <2023071200-unopposed-unbuckled-cde8@gregkh>
In-Reply-To: <2023071200-unopposed-unbuckled-cde8@gregkh>
From:   Luca Boccassi <bluca@debian.org>
Date:   Wed, 12 Jul 2023 17:23:18 +0100
Message-ID: <CAMw=ZnTVRaqRmtz+sDj7AeAS7xivSu+56UgKbzmuW9+K6TTx1A@mail.gmail.com>
Subject: Re: [RFC PATCH v2] x86/boot: add .sbat section to the bzImage
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Emanuele Giuseppe Esposito <eesposit@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, lennart@poettering.net,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Alexander Potapenko <glider@google.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, 12 Jul 2023 at 16:43, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Jul 12, 2023 at 03:06:46PM +0100, Daniel P. Berrangé wrote:
> > On Wed, Jul 12, 2023 at 03:28:40PM +0200, Borislav Petkov wrote:
> > > On Wed, Jul 12, 2023 at 01:48:45PM +0100, Daniel P. Berrangé wrote:
> > > > That doesn't make it useless, as the 3rd/4th/5th fields in the SBAT
> > > > file are just human targetted metadata. The validation process just
> > > > works off the 1st/2nd field.
> > >
> > > It's a good thing I asked - feels like I'm just scratching the surface
> > > on what this thing actually is and the commit message is not explaining
> > > any of that.
> > >
> > > First, second field, that's what, "linux,1"?
> >
> > Each sbat CSV file line has following fields:
> >
> >   component_name: the name we're comparing
> >   component_generation: the generation number for the comparison
> >   vendor_name: human readable vendor name
> >   vendor_package_name: human readable package name
> >   vendor_version: human readable package version (maybe machine parseable too, not specified here)
> >   vendor_url: url to look stuff up, contact, whatever.
> >
> > So 'linux' is 'component_name' and '1' is component_generation
> >
> > > > From a functional POV, it doesn't have to be unique identified,
> > > > as it is just a human targetted metadata field. A friendly git
> > > > version as from 'git describe' is more appropriate than a build
> > > > ID sha.
> > >
> > > So can you explain what exactly that version is supposed to describe?
> > > Exact kernel sources the kernel was built from? Or a random, increasing
> > > number which tools can use to mark as bad?
> >
> > AFAICT beyond being "human readable package version", it is a fairly
> > arbitrary decision. A release version number for formal releases, or
> > a 'git describe' version string for git snapshots both satisfy the
> > versioning requirement IMHO.
> >
> > > How do you prevent people from binary-editing that section? Secure boot
> > > does that because that changes the signed kernel image?
> >
> > The PE files are signed by the vendor who builds them, using their
> > SecureBoot signing key. The data covered by the signature includes
> > the '.sbat' section.
> >
> > IOW, if you binary edit the section, the SecureBoot signature
> > verification fails and the kernel won't be booted.
> >
> > > > > And then why does it have to be a separate section? All those
> > > > > requirements need to be written down.
> > >
> > > You missed this question.
> >
> > That's simply what the spec defines as the approach.
> >
> > The PE file format used by EFI applications has multiple
> > sections and the spec has declare that the '.sbat' section
> > is where this data shall live.
> >
> > > > The first line just identifies the file format and should
> > > > never change:
> > > >
> > > >   sbat,1,SBAT Version,sbat,1,https://github.com/rhboot/shim/blob/main/SBAT.md
> > >
> > > Why do you even need it then?
> >
> > First it identifies the data format, and second if a
> > problem is ever discovered with the  SBAT concept,
> > a fixed approach can be indicated by changing to
> > 'sbat,2,.....' and thus have the effect of revoking
> > use of any binaries which declare the 'sbat,1,....'
> > version. Pretty unlikely this will happen, but a useful
> > backup plan/safety net.
> >
> > > > The second line identifies the kernel generation
> > > >
> > > >   linux,1,The Linux Developers,linux,6.5.0-rc1,https://linux.org
> > > >
> > > > The first field 'linux' should never change once decided upon, as it is
> > > > the name of the upstream project's EFI component - in this case the
> > > > linux kernel.
> > > >
> > > > The second field '1' is the most important one, as it is the mechanism
> > > > through which revokation takes places, and the only one a human upstream
> > > > maintainer should manually change.
> > >
> > > Hold on, how often are those things going to change? And who's going to
> > > change them? I sure hope we won't start getting patches constantly
> > > updating those numbers?
> >
> > It is hard to predict the future, but my gut feeling is very infrequently.
>
> Have you looked at the past as proof of this?

I can't quite think of relevant bugs, in the recent past. Are you
aware of past instances of kernel module signature verification being
broken? Or userspace being allowed to do arbitrary kernel memory
manipulation before ExitBootServices?

> > I can't say I recall any specific Linux bugs that would warrant it, but
> > those involved in Linux/Bootloade/SecureBoot world can probably answer
> > this better than me. IIUC, the scope of bugs relevent to this is quite
> > narrow.
>
> Really?  I know a lot of people who would disagree...

They'd better have some convincing reasons

> > > > If there is discovered a flaw in Linux that allows the Secure Boot chain
> > > > to be broken (eg some flaw allowed linux to be exploited as a mechanism
> > > > to load an unsigned binary), then this 'generation' number would need
> > > > to be incremented when a fix is provided in upstream Linux trees.
> > >
> > > Oh boy, there it is. And then when those fixes need to be backported to
> > > stable, then those patches updating that number would need to be
> > > backported too. I can already see the mess on the horizon.
> >
> > If applicable, yes.
>
> And how are you going to determine this?

Same as it's done for the bootloaders - does it enable a secure boot
bypass -> yes/no

> > > > The SBAT config for shim would be updated to say 'linux,2' was the new
> > > > baseline, at which point it would refuse to load any binaries that still
> > > > had 'linux,1' in their sbat PE section.
> > >
> > > Ok, I fetch the latest upstream kernel, it has "linux,1", shim refuses
> > > to load. I go, edit the sources, increment that to "linux,234" and secure
> > > boot works. No fixes applied.
> >
> > Everything involved in the boot path is covered by signatures, so if
> > SecureBoot is enabled you can't simply build custom binaries. They
> > won't run unless you modify your EFI firmware config to trust your
> > own signing keys. If a user wants to compromise their own machine in
> > that way, that's fine.
>
> "SecureBoot" is a distro-specific thing, they handle the keys, it's not
> anything the normal kernel deals with.

Nah, you are thinking of key management, but this is not about that.
This is about vulnerabilities that allow secure boot bypass, and the
normal kernel very much deals with that. Kernel module signature
enforcement, Lockdown LSM, ensuring ExitBootServices is called at the
right time, etc.

> > > > When a downstream vendor builds the kernel they would actually add a
> > > > third record, where they append a vendor identifier to the 'linux'
> > > > component name, so the .sbat PE section might say.
> > > >
> > > >  $ cat linux.sbat
> > > >  sbat,1,SBAT Version,sbat,1,https://github.com/rhboot/shim/blob/main/SBAT.md
> > > >  linux,1,The Linux Developers,linux,6.5.0-rc1,https://linux.org
> > > >  linux.fedora,1,The Fedora Project,linux,6.5.0-rc1,https://fedoraproject.org
> > > >
> > > > this allows Fedora to deal with revokation if they make a downstream
> > > > only mistake that compromises SecureBoot.
> > >
> > > What does that mean, "allows Fedora to deal with revokation"?
> >
> > Lets say Fedora applied a non-upstream kernel patch that compromised
> > SecureBoot. Upstream Linux has no reason to change their SBAT component
> > generation number. Instead Fedora would change their 'linux.fedora'
> > component generation number to reflect their own mistake.
>
> Why are you somehow trying to differenciate between "upstream" and
> Fedora's kernels here?

Because they _are_ different, and a secure boot bypass can be added
via a downstream patch or an upstream change, and it is important to
differentiate as we don't want to needlessly revoke. Having to rollout
a new Debian kernel because there is a vulnerability in a Fedora patch
would be a silly waste of time.

> Why does "upstream" need any of this?

Because 'upstream' is involved in the boot chain

> And how can you tell if upstream "makes a mistake" that compromises
> secure boot?  Who is going to keep track of this?  Who is auditing all
> of our fixes/changes to verify this?  Have you looked at the past year
> or so and actually determined if you could properly determine this?  If
> not, why not?

The same people who are already doing this for bootloaders, I would guess.

> > > In any case, I think this does not belong in the upstream kernel as this
> > > will turn us into CVE trackers. Distros sure, ofc, that's more along the
> > > lines of what they do but not the upstream kernel.
> >
> > My understanding is that CVEs in general would not apply in this
> > scenario, the scope of bugs that are impactful is reasonably
> > narrow. I'll defer to people more experienced in SecureBoot though
> > if they have a better answer.
>
> You have a kernel version number, we don't change anything outside of
> those version numbers (i.e. if we add changes to a release, we bump the
> version number.)
>
> So why do you need anything other than the kernel version number?

This is not about version identification, it is about cutoff points,
which are much more coarse _but_ apply to both mainline and stable
branches. The version number is not usable, as you would need N of
them, and the principal goal of SBAT is having fixed size metadata
that doesn't explode in size as time progresses.