Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <56681a68-a2cc-6bd1-3e29-dfc02bc07add@intel.com>
Date:   Wed, 12 Jul 2023 10:58:47 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.12.0
Subject: Re: [PATCH v2] dmaengine: idxd: Clear PRS disable flag when disabling
 IDXD device
To:     Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>
CC:     <dmaengine@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Tony Zhu <tony.zhu@intel.com>
References: <20230712174220.3434989-1-fenghua.yu@intel.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230712174220.3434989-1-fenghua.yu@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlhzYkhTUXByOTFBWFhPSWxscjcyZVJ5enZUWUxQeWdIcC9jdVoyVVVDN0dT?=
 =?utf-8?B?L3pFWW12RDFjSktaUEMzK2tPVnArTTlLM1RaUW1LSGwxNHhLeFNZTkIxSWg3?=
 =?utf-8?B?RDFDdTg2WGttQUtIckd5MklGK3dtQUNlRjZUaDBIYXg4Y3RWUWZsS2tKOVh0?=
 =?utf-8?B?YTFONk0xQ0crZUd6WWtLZGowQWM4VmpLZHdLOGQrdGFuejRrVzBiYjhybkov?=
 =?utf-8?B?ZTV5V0lhR09QMXpITzhYQjRFWHJEd0pGY0NGcHlJU3NYMXI1Wk5FWjg0UDNv?=
 =?utf-8?B?d3lBcHI0YitFcGkzbk0vMjdKcWJqalZBVlNtWHhmb05haGd3QkZEQ0NDRU1B?=
 =?utf-8?B?OTJ0NlhUeXZ6dStmUlVqM2F5QmFCc1JjZ3FIQzhRUFNpbjd1VllpNHpkRjRB?=
 =?utf-8?B?R2o2NjNPeUNlRmlsTVdsSmZLeXJYaFNPTENUUTNmOUYwZFhzTGNiaXV0ekV4?=
 =?utf-8?B?OWw2cmIwdWR5dGJlYUNraWVYeVlMYjV6UFpFQzgvTThxaEhqaVlubC9veEhS?=
 =?utf-8?B?M01YdjFWQzZhcWRxdXNtN2RSbHllanNlb2MwQTluNW0ySlVHZGdxU3lmTjJp?=
 =?utf-8?B?aE9DZVQvR3habnFpVjR0NEo0cXFEazVNV1J1VVZ2QWlZNndmUDg0OWN4S1I5?=
 =?utf-8?B?UU13SGlzKzlUdVJLcGdiQmRSWTBYOG1XcW50eGFJaURDMTF3WlR0Sm9iVUFl?=
 =?utf-8?B?RGlWc3NMdmgxQ25yV0lRSC80c0JlWnFoRHlZT3JIdUNyRFNYVGtwaTIxcGFr?=
 =?utf-8?B?ZmtCUWU1a255YmJCdkNZczA0V2xVc01lWkFmYjFodlVpOGlmMXQ5ZG8yS2hn?=
 =?utf-8?B?NGpUd2dVbXBiclU0OERGNzg3UHovQlJpTnlNVFNrRGwvd2U4clByZTdUZndR?=
 =?utf-8?B?VkJRNHZ5TTR1ek4zUHczaVpCbm9WSmZvTHpqWVBGMjhXUkZ1bTZ0UFQzbkM0?=
 =?utf-8?B?ZWNlclNxNHhLcXR6Uk1MY0Q0aVJxNFBnVUpUZ1JnOSs2OXlVS2szOHZHSExl?=
 =?utf-8?B?MGk1ZFo2bFVCTWx5VXNISGdWTE9XckxVbE43cEJLblF1TUFNeTQ1MmpyMGVv?=
 =?utf-8?B?K2ZucTU0ZDlYSGQ0VVQwZ3c3MGtNSVFTczEvSWN1WTdYSjkySlVzT3Vtdytq?=
 =?utf-8?B?Tm9uejJSem0vTkpKbWU3VDhPcFYwck04S2lvTzV3azQzK3k5Sy9sQWg1YVYv?=
 =?utf-8?B?eGhBUEZydjhQZVFzRjJjOFE5QnJSSGUwbXFXNlh2aUE5dE0wUjlYVEtManBz?=
 =?utf-8?B?RlBrc0xTZ3JXeUk3S1pHY1RXSjA1citCWDYycGRTOXpRWkZjbUtRcWtlaXhp?=
 =?utf-8?B?eVo3QnN2a093dnAvK0VmZCtFMHhMaUg0dXJRN01EcHVZUkdzbkE3b3d0cTBG?=
 =?utf-8?B?b3F6c0dkdjFiZ25aWUhxUjZFejREaWx1VnU5V0Q3U3BqczNjeGZYSHQ0a1NB?=
 =?utf-8?B?QnhPNFd6cENwak1RNUo4NWh1RjE1a1grTWxiWGtjR21RUGxxRERCSXRJdnY2?=
 =?utf-8?B?OEtkenY4elZtL05aMnVVMmlyVFU0cUNmajdUMzJOV2lqVHRjZ3U4c2RtczZw?=
 =?utf-8?B?U0JXaFBTOStNMnlVR3NBdjZobTY3MzNybk9CY1NqZGU1c2hzVWd5cW9lZEts?=
 =?utf-8?B?alRFeEZkQ2cwT3MvZGYzQ3BWRDBCU2hvdE5leGlTb1JreG90VUZ5dnNBdDl2?=
 =?utf-8?B?ay9OMEh6RkxEWjh5NWVkNWs2aHdZbjY4V2JUNzFHSG41RTI3WlNYQ0pRWnMx?=
 =?utf-8?B?Rno1RGlaNHJtbkFkYnJPeE1GbWpqR1g1TFhIQ3lESDJJa3ZVWUNHR1NrSlA1?=
 =?utf-8?B?MFllZkpMa3ZQaC8rN1VHRGMyMmt0cXQ3a2ZjZXVMdFdrTzRaaWI1WjFCbkZh?=
 =?utf-8?B?T0h3R01tMjUzUXhJUWxHVFVZUVp2ZWhyaFFmVFVNeU9vM1l6b0xjZlBnZlhG?=
 =?utf-8?B?cUZSSkhCNkxwT3lCV1J5d3Vvd2w0YjZoZ3JHZzB2Z0JIZ1doUGtuZDloUFUv?=
 =?utf-8?B?MHlhUXV5NVVYdHJubkZINUlqVFkwRGxyQlpQZ3ZLakNZNU04dEFTTERUdHJt?=
 =?utf-8?B?ZjlEREFXdU0wamlKZGc3SXZTN0NhVjdrWDJDaEc1bHBpYU5QakNha0JXS1FN?=
 =?utf-8?B?Sk1ha21QeFYzTk9tR0NBc2U0RUFyeEw3YXQwcTRwK3h2MGFpdE1zY29CVDdw?=
 =?utf-8?B?bUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b26b2397-eba5-4a8b-5895-08db8301a598
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 17:58:50.1391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TMNBskngVXxGlzn4ymusVPWJ9GxcDkLj6tsUw858N7n5zEbtVG/K/KAFbJHaYZXc4QsPdfkvAEq5eSVKzlhpmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7137
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/12/23 10:42, Fenghua Yu wrote:
> Disabling IDXD device doesn't reset Page Request Service (PRS)
> disable flag to its initial value 0. This may cause user confusion
> because once PRS is disabled user will see PRS still remains the
> previous setting (i.e. disabled) via sysfs interface even after the
> device is disabled.
> 
> To eliminate the confusion, reset PRS disable flag when the device
> is disabled.
> 
> Tested-by: Tony Zhu <tony.zhu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

Should there be a Fixes tag?
> ---
> v2:
> - Fix Tony's email typo
> 
>   drivers/dma/idxd/device.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 5abbcc61c528..71dfb2c13066 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -387,6 +387,7 @@ static void idxd_wq_disable_cleanup(struct idxd_wq *wq)
>   	clear_bit(WQ_FLAG_DEDICATED, &wq->flags);
>   	clear_bit(WQ_FLAG_BLOCK_ON_FAULT, &wq->flags);
>   	clear_bit(WQ_FLAG_ATS_DISABLE, &wq->flags);
> +	clear_bit(WQ_FLAG_PRS_DISABLE, &wq->flags);

I wonder if it's better if we just do wq->flags = 0? I don't see any 
bits we need to preserve. Do you?

>   	memset(wq->name, 0, WQ_NAME_SIZE);
>   	wq->max_xfer_bytes = WQ_DEFAULT_MAX_XFER;
>   	idxd_wq_set_max_batch_size(idxd->data->type, wq, WQ_DEFAULT_MAX_BATCH);