Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alejandro Tafalla <atafalla@dnyon.com>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH] iio: imu: lsm6dsx: Fix mount matrix retrieval
Date:   Wed, 12 Jul 2023 20:24:47 +0200
Message-ID: <13064186.O9o76ZdvQC@alexpc>
In-Reply-To: <ZK6IpZvG47zsKZFk@lore-rh-laptop>
References: <12960181.O9o76ZdvQC@alexpc> <ZK6IpZvG47zsKZFk@lore-rh-laptop>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On mi=C3=A9rcoles, 12 de julio de 2023 13:04:05 (CEST) Lorenzo Bianconi wro=
te:
> > The function lsm6dsx_get_acpi_mount_matrix should return true when ACPI
> > support is not enabled to allow executing iio_read_mount_matrix in the
> > probe function.
> >=20
> > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieva=
l")
> >=20
> > Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
> > ---
> >=20
> >  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > b/drivers/iio/imu/ st_lsm6dsx/st_lsm6dsx_core.c
> > index 6a18b363cf73..62bc3ee783fb 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct
> > device *dev,
> >=20
> >  static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> > =20
> >  					  struct
> >=20
> > iio_mount_matrix *orientation)
> >=20
> >  {
> >=20
> > -	return false;
> > +	return true;
>=20
> I would say it should return something like -EOPNOTSUPP.
>=20
> Regards,
> Lorenzo
>=20
> >  }
> > =20
> >  #endif

Hi, thank you for the review. I'll send a v2 with a better solution that us=
es=20
error codes.

Alejandro.