Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp239072rwp; Wed, 12 Jul 2023 12:29:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlEBABE1R8eRgrMpCwItZ8ZR+TCFS99UBF4mAxT0SSmWW2rCbSmlC63qLR5W3OsGUy0EQMpo X-Received: by 2002:a17:90a:d50e:b0:262:dec3:5477 with SMTP id t14-20020a17090ad50e00b00262dec35477mr14349344pju.7.1689190162036; Wed, 12 Jul 2023 12:29:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689190162; cv=none; d=google.com; s=arc-20160816; b=AFp1RdcEAiiG0MlaDGpZ5JuwciFHYUF2SyHAlKGdRaAmqOtmOc6541h/jeYgyfqWsc MvNQL6HdB1YGrLknKQFLfXpsPCQC2LwFHbGL/WXQL3p0yKFKasGRfh3A24YRsRQGpbFI BqVc1FBcMOGOJ8f5L5m5TlPOJ99gRfQBnYxbH4oivtHpBFgwi5bnvENBwZirdYM2CTBD VsgTTa/3oyREsoC8ifqIy4tlCxntiJIBdAlH3aXRglglykL0swbB8AIVm1vEIoRyzyq3 t0W3iIO3U1f2YP6cxEWduhOrZ1MRsui4x++ojImR4RiGdwjqvzwSSnt95DLv038G6OMc OxQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LLqzrNbP1vGUJ3OFTl9cGZWimtLx1fVpXRCMSqCEbU4=; fh=FMdbo7g3LGw7NbUznhA95CQj2pFh++cG6lJ0O/Ip+CM=; b=jgWz7k4NrsRY+UqazjGBN7T95eQwiaVZHmuL8FDBF13CwE3AgwzLjwkPooSfdm2jcY /qfI0/MbJRqrbR7Rg6whtzOI9N8Tcz/73iRxLlA+eXUk3iiobXX1LOFccd/NqV4N4PnU dA/WKQdG3w76+aAfKkRE/96rp6itQzJLjvgsl/k3qL18hQ9e+a4jtq1bIO1QjC8jRPCh EMl0B2UNW0I74z9gWzp6Uh4QzsCQF8B7ZZXHFKVAgR0YOhOszsyu26l7ByNafh+U86Tu 3OJ8yjNr5ksQAqVKmFCTU+2C1vARZ18RmVmoQ2CZM5cHpNkyWFN3lddwPuYizWsJdWhg EiEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=XA3Vl02j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp12-20020a17090b190c00b0025de453ee4csi3815087pjb.168.2023.07.12.12.29.08; Wed, 12 Jul 2023 12:29:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=XA3Vl02j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231532AbjGLSxv (ORCPT + 99 others); Wed, 12 Jul 2023 14:53:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbjGLSxu (ORCPT ); Wed, 12 Jul 2023 14:53:50 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 208811993; Wed, 12 Jul 2023 11:53:48 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-51452556acdso5092881a12.2; Wed, 12 Jul 2023 11:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689188027; x=1691780027; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LLqzrNbP1vGUJ3OFTl9cGZWimtLx1fVpXRCMSqCEbU4=; b=XA3Vl02j1f2uF3B1CdoVQFPL4RysVR28DRd+2vH7sNUPUxLbMXAeJZITMlSMUT7SxB 3bPK2zPxQqSSuiH45o2fRp4L8v/8fwS8TiZs2WOwg2C2dH3Va8iBoxsEsrhm+5QlBetZ Nh0LoETIXcy/FDyovB3cJUK4NMILYflp4j7/7he5QwY+l3RcdPYxnq8vnG2n7XyDbeMv 6wHHLDeDfZalZRBBmVivhLeWf5oYhRUIRKD/BD8Zm3SO7+dwwzFFmKvZO8A7JzeDciN0 JSyFICkrZuyIGhpVH01BqprI/2qzYEzneOLCPyw5rgxqX3mL2NmAFDWOi5jE9PdkQVjV jybQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689188027; x=1691780027; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LLqzrNbP1vGUJ3OFTl9cGZWimtLx1fVpXRCMSqCEbU4=; b=KZrPugSbiLiwBOz6oHtgMJYu/Pmr74/B7UM7pVeC9Al97yMVZEymUWMHRF+P5AG8Wp jk1AcWMMNke4S077SpfUC4Kn2Z5nQvsmLyN+Mzx+czXUXa+Dxg2CUhu13lGRJHxcZANL vRqW9vC39yzk4SzOR2OSA75K0OcjVjAovC1MNXm2yVm9CQ2VZde54Ww81TiklUMoz5gH xfePKvQnV1Ik4mxhxE5PW4Csc9OlmVeHYy7vn9pjisCUBipo5mH00Wcq1cdN/dE8qLcI zYI9jltBO9f7AhBY3nAAy3xNTMhul4BM2rcbwHo7/Wv2YkJYANongXWrkf8ERoDVqQud oYuQ== X-Gm-Message-State: ABy/qLYcevDi5qhYe+qEln0KpvaLuY+WPOmDNrmK+K4z8Fzb5TtcGNHt CtFF4tJxAv3ZyJmzvx4jFY0= X-Received: by 2002:a17:90b:3b41:b0:263:43c6:69ac with SMTP id ot1-20020a17090b3b4100b0026343c669acmr14503536pjb.44.1689188027373; Wed, 12 Jul 2023 11:53:47 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:a606:1b1e:7f66:3ee0]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a191e00b002640b7073cfsm11079277pjg.14.2023.07.12.11.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 11:53:46 -0700 (PDT) Date: Wed, 12 Jul 2023 11:53:43 -0700 From: Dmitry Torokhov To: Krzysztof Kozlowski Cc: Hans de Goede , Andy Shevchenko , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter Subject: Re: [PATCH v2] Input: bcm-keypad - Correct dev_err_probe() error Message-ID: References: <20230711072449.43569-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230711072449.43569-1-krzysztof.kozlowski@linaro.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FSL_HELO_FAKE, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 09:24:49AM +0200, Krzysztof Kozlowski wrote: > Pass proper PTR_ERR as dev_err_probe() argument. > > Fixes: a2c795b696b2 ("Input: bcm-keypad - simplify with dev_err_probe()") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/202306261505.wTjCXRIO-lkp@intel.com/ > Signed-off-by: Krzysztof Kozlowski Applied, thank you. -- Dmitry