Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp280275rwp; Wed, 12 Jul 2023 13:12:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlF4XzmU+6lnl+8Khqt0CwcK7BY6hHWtp7jRhhxlHcsFjkW961xRNH6AO8RiVNNoBlQdanAd X-Received: by 2002:a17:902:c1cd:b0:1b6:b829:7065 with SMTP id c13-20020a170902c1cd00b001b6b8297065mr19888358plc.63.1689192773461; Wed, 12 Jul 2023 13:12:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689192773; cv=none; d=google.com; s=arc-20160816; b=SU97kYm8TFBhGBK+RMzQe/K3ezsUcowNv5beSXjZUVY7tZ416LwwmJt8FKNEntl7Gu sP1DGGuu72IG5yg60GIvMZ+dmiZ92+q5flMOM723mkIluzebxpLZXefuceQQRjW+WZ6s Lk/VXwG6mv/8qAFfMNTf4+ybpXNH78uhjtg2Fs8oYWl6bOgZwWdr4MN4lJ/Wzi0kzgN3 2OoANH8WZ2GjYQxYRPT4G1hukfazddCW/Jmf3powJ5vY57QkQ7LZ40bFrByC9ubXXM2r x3K8VwNTjkxL4VtjXkgCE3KucZg8nR/45ue7pLPpYlaouiceUb5NNQfWQlkY09sBYsMD Y4zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=M4ZDRM5fvQMo9GlwKOHCyQm7Bm/RC8HHEV7PqArueRk=; fh=0FIrkBM9FLm7/GonnWGsda+NnjeLdu6OwvpueYdbZAU=; b=xLcCwZf3lVvbiFJVQMrYHTpATJA3KPni1xk7YgpWcti0+qClPEuxJX+xHPah2+8v0P JpXKtEBxXjHZv5Mh6d85a2Ago3dzFyo3X+JiawAmBcKcO4Hz/QETv94dGM4y0E5om4Xv +6KnAZWP2lOp4Q/C8V82Wd5X8u5uA4nc0ibye7ljXnPckM46e23syZMkaESy6kbuFnAn vLkGjSamYmzouPq1V1GYGtrH8PQY6GOvkMod7RMPgdXzTro3BGb9Xwz/6ID5nXNKTsaf q09koke2QuQrk1X5DU9+MhTLViCeVR+n2OyQFJ+X2yzHt0KlDI7+WQ+4AUNDomM2UAIK k5HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=P+qxeFDI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d5-20020a170902b70500b001a51368b098si3722416pls.209.2023.07.12.13.12.40; Wed, 12 Jul 2023 13:12:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=P+qxeFDI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232650AbjGLTsf (ORCPT + 99 others); Wed, 12 Jul 2023 15:48:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232473AbjGLTse (ORCPT ); Wed, 12 Jul 2023 15:48:34 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A8711FDA for ; Wed, 12 Jul 2023 12:48:33 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-67ef5af0ce8so6576868b3a.2 for ; Wed, 12 Jul 2023 12:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689191312; x=1691783312; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M4ZDRM5fvQMo9GlwKOHCyQm7Bm/RC8HHEV7PqArueRk=; b=P+qxeFDIOXYrfb8mKf4q2MKsfsAdNORvRZzlqorQhCiYlGDr4HR+fqoRqyaaCSw8qs gqW+0q6vFVb2yZh+NqTkF3pZvEHl6EAsJ5/5S2zGkkS41VQ+jjWhCanZHeMf4krxerwW t0YdCT3qXtqyZGRJ7+TrJBxjvX45zPbkp8JNg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689191312; x=1691783312; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M4ZDRM5fvQMo9GlwKOHCyQm7Bm/RC8HHEV7PqArueRk=; b=fgWQKJgc6yoZk4Z0Qv7PmEYCILwiLw7xO2O3CKF//r9BanXStuzjbVMOLRrvB4V8bY Au7ASIma3duzaAtzHjjD1YIp0OpRB/3/0XT/8b6gWpr2YqlS9LztPg7I8G3TTZ4zEQo5 iASBnGWikUv/jspBZd0/Mp9ug1XPRsOIbFGD1vY61F19v+S7Y3cl8xPB4Y8hnxkpIc8c PktyV9Efb4OjbbqhDnMjXjtwXRBEOpv0gLxoiTVS34K9FRmAmXU22X9EQD7vWnzWOdM9 Jayum0S7DNmIzShMsQMTjkinpVUDz+3LkPDN2YzVfnPVR0vGT0hLEqIQwdt4MWvIqwUy ebhA== X-Gm-Message-State: ABy/qLZ0R0oTvdLokxJO1zpmipsHychdg/wT744IbH+d1k/SHyJIFx2j 6GpYFYTezQrTJAfLN+RLcCkSQw== X-Received: by 2002:a05:6a20:7353:b0:132:2f7d:29ca with SMTP id v19-20020a056a20735300b001322f7d29camr7630596pzc.24.1689191312528; Wed, 12 Jul 2023 12:48:32 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id h3-20020aa786c3000000b00682af82a9desm4082520pfo.98.2023.07.12.12.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 12:48:32 -0700 (PDT) Date: Wed, 12 Jul 2023 12:48:31 -0700 From: Kees Cook To: Kent Overstreet Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, djwong@kernel.org, dchinner@redhat.com, sandeen@redhat.com, willy@infradead.org, josef@toxicpanda.com, tytso@mit.edu, bfoster@redhat.com, jack@suse.cz, andreas.gruenbacher@gmail.com, brauner@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, dhowells@redhat.com, snitzer@kernel.org Subject: Re: [GIT PULL] bcachefs Message-ID: <202307121241.8295B924F@keescook> References: <20230626214656.hcp4puionmtoloat@moria.home.lan> <20230706155602.mnhsylo3pnief2of@moria.home.lan> <20230712025459.dbzcjtkb4zem4pdn@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230712025459.dbzcjtkb4zem4pdn@moria.home.lan> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 10:54:59PM -0400, Kent Overstreet wrote: > - Prereq patch series has been pruned down a bit more; also Mike > Snitzer suggested putting those patches in their own branch: > > https://evilpiepirate.org/git/bcachefs.git/log/?h=bcachefs-prereqs > > "iov_iter: copy_folio_from_iter_atomic()" was dropped and replaced > with willy's "iov_iter: Handle compound highmem pages in > copy_page_from_iter_atomic()"; he said he'd try to send this for -rc4 > since it's technically a bug fix; in the meantime, it'll be getting > more testing from my users. > > The two lockdep patches have been dropped for now; the > bcachefs-for-upstream branch is switched back to > lockdep_set_novalidate_class() for btree node locks. > > six locks, mean and variance have been moved into fs/bcachefs/ for > now; this means there's a new prereq patch to export > osq_(lock|unlock) > > The remaining prereq patches are pretty trivial, with the exception > of "block: Don't block on s_umount from __invalidate_super()". I > would like to get a reviewed-by for that patch, and it wouldn't hurt > for others. > > previously posting: > https://lore.kernel.org/linux-bcachefs/20230509165657.1735798-1-kent.overstreet@linux.dev/T/#m34397a4d39f5988cc0b635e29f70a6170927746f Can you send these prereqs out again, with maintainers CCed appropriately? (I think some feedback from the prior revision needs to be addressed first, though. For example, __flatten already exists, etc.) -- Kees Cook