Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <14f4e06e-8584-9dc3-ce85-b2491645b894@intel.com>
Date:   Wed, 12 Jul 2023 12:07:19 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v2] dmaengine: idxd: Clear PRS disable flag when disabling
 IDXD device
Content-Language: en-US
To:     Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
CC:     <dmaengine@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Tony Zhu <tony.zhu@intel.com>
References: <20230712174220.3434989-1-fenghua.yu@intel.com>
 <56681a68-a2cc-6bd1-3e29-dfc02bc07add@intel.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <56681a68-a2cc-6bd1-3e29-dfc02bc07add@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmorYTZxbUYzbUsrYzg4T1F6ZmJCRGNSNUphN1l6ZTJtc2JhNzlzN3FsMm9m?=
 =?utf-8?B?a205SVd5QXZhVmNkQ3k0eHcwYWdxS0xOOEMvTmQxSGVJb2h3KzB0OE9pMURt?=
 =?utf-8?B?SitIR2dmSWlEcWwrc0k0Uk9MNVZIanRVcjh5VkNvbHBMNnpYVkthVGg2Ry9F?=
 =?utf-8?B?RkhHUjJOdFR4d2ZERWF1cjgwblFDaHJSSlpWbFJuUENPdllyQzRSNTNBR3dU?=
 =?utf-8?B?M2NiRVJsSnFDcDhZd2NQYzVKUEpPYWtjNEJnTWVUQTBHcmsxUllrd1IyQjRW?=
 =?utf-8?B?elFiLzFRazRqTkdEckxHeSs4QXVrUjUxRWZtblZFYSt2NEQvZHZrUEl3RWNK?=
 =?utf-8?B?K09hbDBDSGdya2FjVHlqTXhQZm5BYzYvVHdGYVBEZ0p2WDg3OUtrSU9aK1dN?=
 =?utf-8?B?S1AwaEo0ZFplbyt2Nk1neHRUczdPVm9DVnlJOWhyRnRQR0sycmdRVXdHNndF?=
 =?utf-8?B?QzczcjgrdTR5elFjSHNRNDlNRmtrNGd2c0ZxWEdmdUZVMTYxbmZ4ZUZsNHNB?=
 =?utf-8?B?SDYxcXU2am1rSjl2OWVrZ004T0ZLalBJd1RPemdwSWhvWUNNNHdpaFluWnl0?=
 =?utf-8?B?Yi80L2RTYVUzN2prQmRQYkFwbmpiQXVGVnVXdmQrWjR6TUxlR25ldER4eGMv?=
 =?utf-8?B?bmQrSHZubXI0d1lEM2hRdzlIYUw4d1NYNmxSQ3RBOVNsR1BRZHlrOEpLQ2tv?=
 =?utf-8?B?Z09rMjJOcEJjRmRGb2hwM3F6VzRaNTNzZW5OWHJWQUhHWFhudWlWZFhBUHFt?=
 =?utf-8?B?WWlFWEpjZXd3ckgvYi9FOVRYeGlqUmpocisrdHdwUHd6Qkt1YVFxZTVBMWk5?=
 =?utf-8?B?STBwMzhra0UvOFdvR0JSR0dzcWxBMFFqRnN3cjlaSXIvek41VlVwY0kvTFlu?=
 =?utf-8?B?eGlUWHhGRUpzMnVoaVhqNmpvSS9maS9kL00xZTdYUE1aczI4NjZVNllGMGxp?=
 =?utf-8?B?YUlmQ0g1S202WHI3RkhadW8vNC8wQ1FGbVUrZ1hwMnY1NCs4WXQrQnZVbU8v?=
 =?utf-8?B?UEVLVkNnREs2c3lmazdJMTJJUk1qL3VDOEl3SmxzVjU4R1hXVXlVTWR2U21P?=
 =?utf-8?B?dVI1MnhhK3VNTDVUaU44TXFQYUkxZlM2NVR4T3VxYjUwTXdJKzBQV3B3UEhY?=
 =?utf-8?B?RDlpbVdJYlh0cllzWE0xazZJT1EwckR6T0IrTkFnTi9oMFhaSVFJYmdaZ21R?=
 =?utf-8?B?STZnTnd0b0puWEV2NTBzWkNPRlUvRm53L1FEaGp1Z2dQT3Aza2R1Ry9QME91?=
 =?utf-8?B?SmR3ZTl6enNJOEQrMythbk41M2kwN1lEWHA0WjdnY3V1WVMyQWM4YlFEWmpv?=
 =?utf-8?B?aE1GK2Vla2tOMUtYMHBvb21GSzNqajRIa1BaM3NhU0tSdS83c1MrYzE5ODg4?=
 =?utf-8?B?TmVOYWZYc2xzVWdsTSs5YU9Ka1lOLzkzLzI1ek1RR0J6cGxFSHUrdjZoaCt1?=
 =?utf-8?B?cEtSSkxOcjlhQUVKM2V0OFVOVXdMZ3ZVMXVwb0w0cEsvdjBuV0FManduSUY0?=
 =?utf-8?B?Rm1jOVpZa05EVkFkU3lacnk1Y2hYL2VYUlJuOGVMOEtZcXVscVhlQ3l6TGhn?=
 =?utf-8?B?VVNNNHY1a0RYZGFYVW4zV2lXVmhFOGZ2VXpjQTMraDhjQ3VsUktobS9oM0w5?=
 =?utf-8?B?NHk1WjlpZm84dkp0ZlpyRDJjMkNCZDRmRi8rQ0d1aHJmUlRJWElYdEdDcGx4?=
 =?utf-8?B?amQydGZQMGhFVDRXVEgyOVpkOUFQUEZIUEthR1NKS1NKdlN0YjRmcTJZWUxJ?=
 =?utf-8?B?UW9mVFhUNW9kSmdjUTZXcHlJUEhzdHc2TTBJUzlPMVFlT05QalRDODBUbWdV?=
 =?utf-8?B?TWpHSURMdlNEaU1qNDR2M2R6NjRKUzlBZm8rYTQycSt6VGZVcFc2VTh3WkxU?=
 =?utf-8?B?VHdoSCtMOEZYWEp4eGc3RTRCd1FkZ1E2NllCR0lLdkoxaWJVTkZnWitxS2M1?=
 =?utf-8?B?SE5ZbHkrZis1VWlwK1krR2M3dTJoTUdtellVNjROY1UzY0ZWUTI0OGxjTFQw?=
 =?utf-8?B?L3grbkhzejdFTmMycnlPWVBFMGFhVkFsaVB0emdEVGhxNks4SDM4eEZORWYy?=
 =?utf-8?B?Tm4yOGNJT3MxeC9KR3F6QWJEY083aUtYRFEzK0JFTm1NUWJURmJjcXhRbERO?=
 =?utf-8?Q?Zq5XcHonolq7EmtN1iuRihETq?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b864e327-746e-460b-b886-08db830b2edd
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 19:07:05.8921
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zIdXeek60fPO3zT+J7DoGApoH6Kp1WaKRClLuXN4y8xA7k1aSixs/5Wso7FHe2AreSxmJuCY8Yge/fgqnItePA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6025
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Dave,

On 7/12/23 10:58, Dave Jiang wrote:
> 
> 
> On 7/12/23 10:42, Fenghua Yu wrote:
>> Disabling IDXD device doesn't reset Page Request Service (PRS)
>> disable flag to its initial value 0. This may cause user confusion
>> because once PRS is disabled user will see PRS still remains the
>> previous setting (i.e. disabled) via sysfs interface even after the
>> device is disabled.
>>
>> To eliminate the confusion, reset PRS disable flag when the device
>> is disabled.
>>
>> Tested-by: Tony Zhu <tony.zhu@intel.com>
>> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> 
> Should there be a Fixes tag?

Will add a Fixes tag.

>> ---
>> v2:
>> - Fix Tony's email typo
>>
>>   drivers/dma/idxd/device.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
>> index 5abbcc61c528..71dfb2c13066 100644
>> --- a/drivers/dma/idxd/device.c
>> +++ b/drivers/dma/idxd/device.c
>> @@ -387,6 +387,7 @@ static void idxd_wq_disable_cleanup(struct idxd_wq 
>> *wq)
>>       clear_bit(WQ_FLAG_DEDICATED, &wq->flags);
>>       clear_bit(WQ_FLAG_BLOCK_ON_FAULT, &wq->flags);
>>       clear_bit(WQ_FLAG_ATS_DISABLE, &wq->flags);
>> +    clear_bit(WQ_FLAG_PRS_DISABLE, &wq->flags);
> 
> I wonder if it's better if we just do wq->flags = 0? I don't see any 
> bits we need to preserve. Do you?

wq->flags = 0 is better.

Thanks.

-Fenghua