Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230712132840.GKZK6qiK70m1O90jFL@fat_crate.local>
 <ZK6zdsIbnQFUmK69@redhat.com> <2023071200-unopposed-unbuckled-cde8@gregkh>
 <CAMw=ZnTVRaqRmtz+sDj7AeAS7xivSu+56UgKbzmuW9+K6TTx1A@mail.gmail.com>
 <2023071239-progress-molasses-3b3d@gregkh> <CAMw=ZnRheXk7W_r-32bGymbHKdXc7aKUpwGAOX+k7DJkN+DiCQ@mail.gmail.com>
 <2023071229-dusk-repacking-da3a@gregkh> <CAMw=ZnSmZTBs+bJsQ_Y2CVO8K3OTuHOZDKW4cbxKpGbo4Vgs7Q@mail.gmail.com>
 <20230712194202.GNZK8CCj4yacgFMgfB@fat_crate.local> <CAMw=ZnSa-NqfbEd9vchEwHwdUujNAXo=gb3dfd=HDw4W37RNjQ@mail.gmail.com>
 <20230712200108.GOZK8GhJTkpuIDI4Rg@fat_crate.local>
In-Reply-To: <20230712200108.GOZK8GhJTkpuIDI4Rg@fat_crate.local>
From:   Luca Boccassi <bluca@debian.org>
Date:   Wed, 12 Jul 2023 21:16:50 +0100
Message-ID: <CAMw=ZnSBv=R5A9Yn5n-N+_QMaaUipVGxEJA1JWv__S3z5MmHrA@mail.gmail.com>
Subject: Re: [RFC PATCH v2] x86/boot: add .sbat section to the bzImage
To:     Borislav Petkov <bp@alien8.de>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,
        Emanuele Giuseppe Esposito <eesposit@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, lennart@poettering.net,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Alexander Potapenko <glider@google.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 12 Jul 2023 at 21:01, Borislav Petkov <bp@alien8.de> wrote:
>
> On Wed, Jul 12, 2023 at 08:56:36PM +0100, Luca Boccassi wrote:
> > Everything < 3 is revoked _and_ the generation id in the stable branch
> > is _not_ bumped, because it's still vulnerable and so that branch is
> > effectively dead and unbootable on any system with secure boot
> > enabled. This is a revocation mechanism, not a bug tracking mechanism.
> > There's no mix-and-matching.
>
> No, this is a mess waiting to happen.

That's not very convincing. You are aware that this mechanism exists
and is already used by other EFI components, yes?

> > Nah, it belongs in both places. Please read the documentation and
> > spend at least some time trying to understand the actual problem being
>
> You want to have this patch in the tree - the commit message should
> explain why it is needed and not point to some documentation somewhere.

Then why not just ask for that, instead of making convoluted
assumptions based on nothing of substance?

> > solved before commenting - or don't comment at all, that's fine too.
>
> Here's a comment for ya:
>
> Naked-by: Borislav Petkov (AMD) <bp@alien8.de>

So very mature. No wonder kernel maintainers and the LKML are
universally loved and praised.