Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42f9e042-e404-2ecb-5e92-c3810671ecad@intel.com>
Date:   Wed, 12 Jul 2023 13:11:07 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.12.0
Subject: Re: [PATCH v3] dmaengine: idxd: Clear PRS disable flag when disabling
 IDXD device
To:     Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>
CC:     <dmaengine@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Tony Zhu <tony.zhu@intel.com>
References: <20230712193505.3440752-1-fenghua.yu@intel.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230712193505.3440752-1-fenghua.yu@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUFqZGR4ODBuaisvZDllVjlFb2UwZlhLSFM2TktCL00wNTFCa2NHUVIzeC9Q?=
 =?utf-8?B?RkZLdStlSnQ0S3V0YW44Z2ZTN1RFclNnZjg4MTQ0TU40SWRmOFNLVEw1MG9l?=
 =?utf-8?B?eWErQ0xSSHRjbFZRNFpRS0EyaFFuVFh2WDBnS3l2NXE0MHBGRjk0cDdsQVFH?=
 =?utf-8?B?YWdVK3B5UDNsWEpFeXFyb2FrREQxMzF4UVF1MUJmQ2EvSDVZVDhieUc3NkJ3?=
 =?utf-8?B?UWoyWE1hVXpFSVZkTmVZR093a08vcGczWXY3dHBsMUEycVd2SFN5RWdUbW5x?=
 =?utf-8?B?bksvKzFBc0YrS2JDaEJQOXVuR3gxL3RoTXJvSHI1cGwrcGhYa1F0c3B2NEZk?=
 =?utf-8?B?eUZwZWhvOFQrejRNT0ZkTFVwaHNFZ2hrUFZJNDh5RTlBcUhuQWsrZWFNMWxX?=
 =?utf-8?B?cnpyYm1RZCsvT2dUTFhZVForTHZEK2RZaDd5cjJwdXIyRDBKY2hubkJDU05h?=
 =?utf-8?B?c2NDZFBnYXFSVVFmbFZVVHV3a0xkVDkwejRySWluQ0E3ZFVEbkpmYU1yMHg3?=
 =?utf-8?B?clpKOHFxMVlXakpPRGk0K1g2NXM1Q0tSZXVxYTVueW8zT3JQbjNvdEVjL0NZ?=
 =?utf-8?B?bi96ZFlqYXJLUmdPY244UUhIQ29PdFNScm54cndFZWhpeUhVMjVrWGE3NU55?=
 =?utf-8?B?N1kwVkdWakY2eGdraHpTSXAxZSt4YnIwS0Z4YnhSaWZBaGZNQUNYTFBaTkhH?=
 =?utf-8?B?U0FMaXdjNnRpb21TRmFPUllyQ09iQjlUUzhNa2dJNXVndUNadEhiN0tELzVZ?=
 =?utf-8?B?SmdHdVF3ZVJoajYwcTdDQmcwaFZyQ2p0N2hvT0dlUS9lY08yTEgxbXFYVUx4?=
 =?utf-8?B?eE5NRUZSaENIUHYzRVdZR2hMNTBPZ1d1RUU3MjhiRUlIdkY2RW9tbEgwOVRT?=
 =?utf-8?B?MVhwbTh3VkpqQ0thV0xrMnhkVFc4OFdUUmVPYmVIektaUWR6SW5MdGIvM21y?=
 =?utf-8?B?ejFhYTZmZGdzMHpMaXdqcTh6ZWROSDFLK09pNXV3Nzhyb05OM3h4TDg4TGx3?=
 =?utf-8?B?WHlpcnBQenBkbXhqSTRDRHYvcGgxQ0hwY0M0MlhSRW5TSm1tMWw4SU9RR2Rk?=
 =?utf-8?B?cFgxMEVmVGJzdGdxbmJEaVJVcGpJenVTLytvdzlPamRBczZuM0x6Y0RiU3JY?=
 =?utf-8?B?TW9VcXlJOGQ4RzZpZjRkM3Fyd1d3TkxPVFRaRHZpaTlmeGNQQ2kzSE4zeFRW?=
 =?utf-8?B?dHBmUERDaGI1WEw2S3FHVjBIT2trUHcxL0FPS3dCSDU3NFE4eU0rZUFuajdi?=
 =?utf-8?B?blVSZUFlWTJaalh0R0tSSG9LbDVPckZSOU52VkFiM2hzNGUrR09UZFZId0di?=
 =?utf-8?B?ektWaUhuL3VxSFhjaFZkWUVENXNOcDY1eFpqakM1Tm9hU01LL2pRQnQwd09n?=
 =?utf-8?B?L3VIWFlPYkkvWklDWFRzK21FM2xVZWlzWXF0ZWV4UW1MKzZhbXlKaDFEOFVC?=
 =?utf-8?B?N3FCWmkyQ0tpUUw5RTlFaU4vajFVbzU1ZEsvTy9XWkpJS3pleWRIVThpZFlr?=
 =?utf-8?B?K1ZDME9OTWQ4T3U1dU1ad0RYVXhWV3BONTdHUjFlR2l6V1RYYzJUMGlvOEt2?=
 =?utf-8?B?ZE9Fb2ZlWCsxb2FKTWh1Tm4zT1lpK2tERXJzZlVMOThyNlNwYzBWNytrVE1F?=
 =?utf-8?B?QnJaaGE4T3UyK2tZNS9OWStmaU5qQzF6OVBhajloT1pkdks4Q3J2RWxVQzEy?=
 =?utf-8?B?Mm5ac05BV0FaRW5BOEFKKzRRcEZHdGExbExMeFRvYk04eENqbzZ3OGltdmoz?=
 =?utf-8?B?b212aXAyazI3ZFlwVDVidmN4ZmJwQTVvNHlrVkFxUm9pVFRibk54eDFxMkF3?=
 =?utf-8?B?bEI1SkozK3IvZGJQUnNtRTdnTVJkNlk0aHFwTmM2NlYxcUtZRCtaUXVtREV1?=
 =?utf-8?B?bHYycmxVTmJPeDNJWkgyUXRaZFlMZEVvZU85ZkVxZ3YvODFKVXhkOEhRZk15?=
 =?utf-8?B?QXhVTzVjUXFPTG03QkhuYjRxMEdqWi9iMkEwa3FCSGczUVB0ejUvQjNKWGZN?=
 =?utf-8?B?QWRBdFJDUzYyT24vRlZjbzM3WlE4aXlod25CQzJSSDBLaEZXWnJCR1M0ZUNN?=
 =?utf-8?B?dkFCaGFmb09NTXFreExtZWpNeXJGVkU0SnQrNHdtay9KVHk3dkJ1a1BmSk15?=
 =?utf-8?Q?VX3sYaGOlYcw7O2MKlZkBcyAF?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 629a2077-f30f-4bd9-dfee-08db8314276a
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 20:11:18.9665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ojIpklwvJeton5sOkGLL0F9y1+rkufGyMFY5DEPIdjtUuB2Qi00VpT+yJreNCJHH46Mxt5k8glaRiwYZe31K7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB8266
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/12/23 12:35, Fenghua Yu wrote:
> Disabling IDXD device doesn't reset Page Request Service (PRS)
> disable flag to its initial value 0. This may cause user confusion
> because once PRS is disabled user will see PRS still remains the
> previous setting (i.e. disabled) via sysfs interface even after the
> device is disabled.
> 
> To eliminate user confusion, reset PRS disable flag to ensure that
> the PRS flag bit reflects correct state after the device is disabled.
> 
> Additionally, simplify the code by setting wq->flags to 0, which clears
> all flag bits, including any future additions.
> 
> Fixes: f2dc327131b5 ("dmaengine: idxd: add per wq PRS disable")
> Tested-by: Tony Zhu <tony.zhu@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> v3:
> - Add "Fixes" tag.
> - Set wq->flags to 0.
> 
> v2:
> - Fix Tony's email typo
> 
>   drivers/dma/idxd/device.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 5abbcc61c528..9a15f0d12c79 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -384,9 +384,7 @@ static void idxd_wq_disable_cleanup(struct idxd_wq *wq)
>   	wq->threshold = 0;
>   	wq->priority = 0;
>   	wq->enqcmds_retries = IDXD_ENQCMDS_RETRIES;
> -	clear_bit(WQ_FLAG_DEDICATED, &wq->flags);
> -	clear_bit(WQ_FLAG_BLOCK_ON_FAULT, &wq->flags);
> -	clear_bit(WQ_FLAG_ATS_DISABLE, &wq->flags);
> +	wq->flags = 0;
>   	memset(wq->name, 0, WQ_NAME_SIZE);
>   	wq->max_xfer_bytes = WQ_DEFAULT_MAX_XFER;
>   	idxd_wq_set_max_batch_size(idxd->data->type, wq, WQ_DEFAULT_MAX_BATCH);