Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp439544rwp; Wed, 12 Jul 2023 16:13:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlHZfiip9Pf+A/OmprS46pnmPe3GdkNyiXp67fUJMkTwGEhac4n6PqTYEKcVTlXRLLLA8fn3 X-Received: by 2002:a05:6a20:1584:b0:12e:3394:e2b6 with SMTP id h4-20020a056a20158400b0012e3394e2b6mr288911pzj.8.1689203599758; Wed, 12 Jul 2023 16:13:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689203599; cv=none; d=google.com; s=arc-20160816; b=g5tzTRqVF9oERQPrD0YnWUI6yK0AJrmv2zfnXLFcj7zpkL3yeVnSK0pXmlrw0cZL8c PxSmPejGJ/i4YacATN5O1+QKjLE8iOEmrHmhnNS9IvfeaMeVN20iALIqNATGAQJzU6R2 IwnCtKPOg3uvrVBEa/EIeG+/5iBYpg9HvQ1ckqrpBYDl4eMU+ndpF2bbymr/EyOFZ1ds ajy3B9d27j0UeLUWvY//peFHG93T/aT7juOT6rqUlQAtGSMl9LM3w6WG60ScpliIgWlX wiGyraXZXNFGZI3ztAzCDF+tfD0dzA+5PaCDpRI9jQBTZtAfvqVtIWKmdaJgah8KKHyi SQDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=W74OVpeHRuNiX8pMSZJwMLioV1gL07KE3H1a2Sb6peY=; fh=Y8Ld5I1ws7Bn9xLvDfzp8W4VJcPtqIxOmCanyAtCmeY=; b=CEuG7bgV24Z8KceTFH5D7rVA0jdN3K/dvJUGgk160uyHpHJF0r4dhwn5tXNcR4KcLd NBTlMw4prKdQprtvGSbAOM9/i7QuK3xZQXaNKqNM8IDn0l7L1J511/58Mbf8X2TndiEp DSjS2MiRUoP/+anzFv1q0fI/gCb4pYDP8/mrztsQb8hZ6YEmrYlQD++VC+JiWP9kGhuX IOYu8CPmF+VNQJCd1vE+Q30aWwqnoXZ9TuTn08BEE7jL0PS2qAurB9fKipcQwawhglH1 UWZ4DuLiDgSoQLb/+RnzwamG8K7kNpK8UmpWaB107BSQDWkD0+swyTWW3PimoW1n2IjP bzRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QgNyeryY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q185-20020a632ac2000000b00553b5116cefsi4044382pgq.16.2023.07.12.16.13.07; Wed, 12 Jul 2023 16:13:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QgNyeryY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229570AbjGLWkl (ORCPT + 99 others); Wed, 12 Jul 2023 18:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232427AbjGLWkj (ORCPT ); Wed, 12 Jul 2023 18:40:39 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 950EC1BF9 for ; Wed, 12 Jul 2023 15:40:35 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1b852785a65so256325ad.0 for ; Wed, 12 Jul 2023 15:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689201635; x=1691793635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W74OVpeHRuNiX8pMSZJwMLioV1gL07KE3H1a2Sb6peY=; b=QgNyeryYTTACVv5xzPnNBA4fBv8uhd7VsaVJyHLSkvwtHQ661hFCyV66BZ6tioghkS IiSrAN7DKiJZGemA6V8wlUMgmctAMNrRpVUKhk/5Lv33vAAYGSUdGM69pCLaNnlbNOXh 8XefLt2O2fzoj5+Y6R5Z6VGjlTW+vbMv4QtDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689201635; x=1691793635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W74OVpeHRuNiX8pMSZJwMLioV1gL07KE3H1a2Sb6peY=; b=EK+YCt8WTuk7ekbxYVWaHzPGondw6mcVdUz9xhRmgPxR6ukMpRsf4qfiOCGWeg/k2K k+oST84Gst/wSXD1qwGweyPOWTJZZyOBBuuFpL/epA5nw+Ncu8Ti673TwTrZbzB66LBD XDkiQHqtsld1JimU83Hlg3Dq1lcVMYrNrDaM+gPac2KUAIE4atVoXyu0TP0PcD41S1m9 5ndRoTuqJmu8zsa4E7Dff516GqoruVUIMnIAD4f/KDSv48GMKmmQtgpbZ/zm2e/9Nvjf 3Syqs7HQCX1PimxcxGJmSoyoLSSFsau2UI0wi23NcnEpmx/nFNd4SqLROfSu1MY+kRmc hIIg== X-Gm-Message-State: ABy/qLalFX4ovv/YOxJ4tCLtgWHa+I0C3iKVfyfdn5Fu4Q85cgXokv9m PpAZkTGtGgdDU0yqnc6lAig0FA== X-Received: by 2002:a17:902:ea03:b0:1b9:d38d:efb1 with SMTP id s3-20020a170902ea0300b001b9d38defb1mr196238plg.8.1689201635138; Wed, 12 Jul 2023 15:40:35 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id d14-20020a170903230e00b001b864add154sm4475679plh.154.2023.07.12.15.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 15:40:34 -0700 (PDT) Date: Wed, 12 Jul 2023 15:40:34 -0700 From: Kees Cook To: Christophe JAILLET Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] soc: qcom: smem: Use struct_size() Message-ID: <202307121540.F8EBBCA1D3@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 12, 2023 at 10:42:15PM +0200, Christophe JAILLET wrote: > Use struct_size() instead of hand-writing it, when allocating a structure > with a flex array. > > This is less verbose. > > Signed-off-by: Christophe JAILLET Reviewed-by: Kees Cook -- Kees Cook