Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Oliver Upton <oliver.upton@linux.dev>
To:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kvmarm@lists.linux.dev, maz@kernel.org,
        Mostafa Saleh <smostafa@google.com>
Cc:     Oliver Upton <oliver.upton@linux.dev>, suzuki.poulose@arm.com,
        tabba@google.com, james.morse@arm.com, qperret@google.com,
        bgardon@google.com, sudeep.holla@arm.com, gshan@redhat.com,
        yuzenghui@huawei.com, will@kernel.org, catalin.marinas@arm.com
Subject: Re: [PATCH v2] KVM: arm64: Add missing BTI instructions
Date:   Wed, 12 Jul 2023 22:50:34 +0000
Message-ID: <168920214959.3096128.780259299986215400.b4-ty@linux.dev>
In-Reply-To: <20230706152240.685684-1-smostafa@google.com>
References: <20230706152240.685684-1-smostafa@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 6 Jul 2023 15:22:40 +0000, Mostafa Saleh wrote:
> Some bti instructions were missing from
> commit b53d4a272349 ("KVM: arm64: Use BTI for nvhe")
> 
> 1) kvm_host_psci_cpu_entry
> kvm_host_psci_cpu_entry is called from __kvm_hyp_init_cpu through "br"
> instruction as __kvm_hyp_init_cpu resides in idmap section while
> kvm_host_psci_cpu_entry is in hyp .text so the offset is larger than
> 128MB range covered by "b".
> Which means that this function should start with "bti j" instruction.
> 
> [...]

Applied to kvmarm/fixes. Sorry this took longer than expected, Mostafa. I
was hitting an unrelated issue with pKVM initialization on the only system
I have that supports BTI.

[1/1] KVM: arm64: Add missing BTI instructions
      https://git.kernel.org/kvmarm/kvmarm/c/dcf89d111199

--
Best,
Oliver