Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp484048rwp; Wed, 12 Jul 2023 17:08:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlHBpLpCOzmLkKhw9muawpLt9EkGi0X8HIqGxaeU/VulOiOxrF7hbCJ2SgfVgrDYJm/QdnHo X-Received: by 2002:a17:906:4f:b0:994:356a:2034 with SMTP id 15-20020a170906004f00b00994356a2034mr1361116ejg.43.1689206912132; Wed, 12 Jul 2023 17:08:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689206912; cv=none; d=google.com; s=arc-20160816; b=lFvWhGSlxxL0U2nHvRSFU8aPpvWnQ+x8LAHDCnzp5kz30FpOikoNeGSuFxH6FxsUbV frH9Jk8TFbRmlZZWm3xLSXQXK2tei/jZb260JZ4Z2/fh9+HkyTmv0zRnNht50IbCmB9i JfF8NiFXsw+b27DdRWUFIwWUSVW09lrKm3cAb/oDxvY68ppA/po9I/0nsLZ8ACzkcXrl zVW4ghyZMNDxEqvKnCS22727Kdv1xdkOYuHna9SHmKZP0S7mo2qy1BoPYiYWdDUg69e1 vk7NXHrb2THx48NCdPfw7+UWpvKyV6hUlxOCzBUHE+qzM/1RXPtzcdp84/TiZwgxeXrd Nf2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=HdRkPHQbmL+KI99hg0WRVveywwwtcvtnYc1upC65aKI=; fh=Ez9t8yDua1Y+1h/9agxcfYkH5PmSL8yqrF8dYJAgUXU=; b=B6ICZC1B1pauqjh24zJ1hxLh62lVy+GcUDVPvNG8AvrIgcreND7sHWUKsQnk/j1PEO KYH15aGQgbVOn1mFycio/7cOeB5C7UqM9qFwIyJqpt9oy1qURPbiON3XeldcFJRI4mqO 9oEyHAM7VTXiZkzCgoiBY8lU1Wwb/sQfuNf3VrzGdBYq3YkPacQI4uQBUlJ++/MP/g6t R7EGeu+URZvNpsleoVItg3i+LzSu3O4ryUgN+UVZvAYK0qSLYYVTjmEbbd7gjhAuUDaq 9RW7Hv3adQutCtkQH8D+Cx7MjrqQ7HqyTzzIOI3PuQzM8PnKGxsMJNmCYxJJWuERzRNK Vjrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020a1709064acc00b00992e26642ddsi5679480ejt.251.2023.07.12.17.08.08; Wed, 12 Jul 2023 17:08:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232817AbjGLX4m (ORCPT + 99 others); Wed, 12 Jul 2023 19:56:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232125AbjGLX4l (ORCPT ); Wed, 12 Jul 2023 19:56:41 -0400 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45EDA1BF2 for ; Wed, 12 Jul 2023 16:56:40 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0VnEWYjT_1689206197; Received: from 192.168.3.2(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VnEWYjT_1689206197) by smtp.aliyun-inc.com; Thu, 13 Jul 2023 07:56:37 +0800 Message-ID: Date: Thu, 13 Jul 2023 07:56:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH RESEND] erofs: DEFLATE compression support To: Randy Dunlap , linux-erofs@lists.ozlabs.org Cc: LKML References: <20230712233026.118706-1-hsiangkao@linux.alibaba.com> <20230712233347.122544-1-hsiangkao@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 2023/7/13 07:46, Randy Dunlap wrote: > Hi-- > > On 7/12/23 16:33, Gao Xiang wrote: >> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig >> index f259d92c9720..d7b5327215f0 100644 >> --- a/fs/erofs/Kconfig >> +++ b/fs/erofs/Kconfig >> @@ -99,6 +99,21 @@ config EROFS_FS_ZIP_LZMA >> >> If unsure, say N. >> >> +config EROFS_FS_ZIP_DEFLATE >> + bool "EROFS DEFLATE compressed data support" >> + depends on EROFS_FS_ZIP >> + select ZLIB_INFLATE >> + help >> + Saying Y here includes support for reading EROFS file systems >> + containing DEFLATE compressed data. It gives better compression >> + ratios than the default LZ4 format, whileas it costs more CPU > > while > or although > or but Thanks for pointing out, let me fix in the next version! Thanks, Gao Xiang