Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp511231rwp; Wed, 12 Jul 2023 17:44:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlGircsCOwubLRbvfltPOU74fydFICoIZ9NJT/qmnHeCdpbwc2CTPAMeWMrmZPx/B5S9lWG3 X-Received: by 2002:a05:6a00:15d2:b0:67c:db:c2f4 with SMTP id o18-20020a056a0015d200b0067c00dbc2f4mr5585372pfu.4.1689209060009; Wed, 12 Jul 2023 17:44:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689209059; cv=none; d=google.com; s=arc-20160816; b=wguHXmPsc7WEu8BEX8h4WY8RBOTSa7T3K3R6YYrQ3EGzc9xU29gRWXvwgMUokzNGx6 PWFnKsW+0t0GWKj3OvFIiBl3qj+XX4DlpjPeCdHdm99Z1L6a5Y96PFbPB+lao5Ar8jM4 W/+KaSBd1e16MW4raMGV4UmCqPC2oDDOjx2IgLp4YTHCYJh+lwGGRg56Y392xzj3LTDg GxHSAsxbyUID0QQIZMLoU2DEkgufV8+4VKwIbAsN3O/Qv+eZpLKO4CaiXUUFbJjBCNAR YA2p6Yqu85L1q95bqJVRGf4h0gbmHbrg8/RR/YxQCYs2+z9yByeuX6arnaWvPWMe3VYt r9vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=/2ikk6ITdUBNd3xg+KLMCsNUQClENe9rI5qzRDw9bIk=; fh=Ez9t8yDua1Y+1h/9agxcfYkH5PmSL8yqrF8dYJAgUXU=; b=gBC1wZvmNvmXg3wt4LOZluJLq9/w5gKdpUuLPUjOKIWbRS/PtbafRGuMx+/ctY0/ei KZ3f4AINOgTvBpwFG9BoCTNmPmgIaq0lHUj8zHc5PXTUpoLy2HAtlHtT75svnGNArI3Z 8OjF9VtPHUKRZnpCNgNgQcAjag9PeothMIugvYNxEbzy0+4s6uXzBYl/p1gZQxfngRTQ sWVd+Q2Cknybaye5mlAI9t0FncOja3DTyQQtVG/oFNqFnFqg17E+xm6GKIrqiKBxPyRn O5+I0vdTz1ZTmb8wWAaelBAGCy1DKvoR20k2ZoNrFqIzd+hGnxr8jpoNcRxPxJT47Vxw pJHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fj26-20020a056a003a1a00b0066df86b9458si4268645pfb.223.2023.07.12.17.44.07; Wed, 12 Jul 2023 17:44:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232473AbjGMAHn (ORCPT + 99 others); Wed, 12 Jul 2023 20:07:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjGMAHm (ORCPT ); Wed, 12 Jul 2023 20:07:42 -0400 Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BDA41FC9 for ; Wed, 12 Jul 2023 17:07:40 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0VnEWdSj_1689206856; Received: from 192.168.3.2(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VnEWdSj_1689206856) by smtp.aliyun-inc.com; Thu, 13 Jul 2023 08:07:37 +0800 Message-ID: <23174b54-b7c6-866a-8e84-f705fc391b4d@linux.alibaba.com> Date: Thu, 13 Jul 2023 08:07:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] erofs: DEFLATE compression support To: Randy Dunlap , linux-erofs@lists.ozlabs.org Cc: LKML References: <20230712233347.122544-1-hsiangkao@linux.alibaba.com> <20230712234611.4712-1-hsiangkao@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 2023/7/13 08:01, Randy Dunlap wrote: > > > On 7/12/23 16:46, Gao Xiang wrote: >> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig >> index f259d92c9720..d7b5327215f0 100644 >> --- a/fs/erofs/Kconfig >> +++ b/fs/erofs/Kconfig >> @@ -99,6 +99,21 @@ config EROFS_FS_ZIP_LZMA >> >> If unsure, say N. >> >> +config EROFS_FS_ZIP_DEFLATE >> + bool "EROFS DEFLATE compressed data support" >> + depends on EROFS_FS_ZIP >> + select ZLIB_INFLATE >> + help >> + Saying Y here includes support for reading EROFS file systems >> + containing DEFLATE compressed data. It gives better compression >> + ratios than the default LZ4 format, whileas it costs more CPU > > not a word: whileas After v2 is sent, I saw your comment then. Okay, anyway, let me send v3 now. Thanks, Gao Xiang