Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp518601rwp;
        Wed, 12 Jul 2023 17:56:13 -0700 (PDT)
X-Google-Smtp-Source: APBJJlFwHmWPjMPhkxQeEN2boakbCySHqevwmmQGmhj08BA514D4cLShYsyCsALDWgtjEjH4fRx0
X-Received: by 2002:a17:907:d8d:b0:993:b230:936b with SMTP id go13-20020a1709070d8d00b00993b230936bmr5107955ejc.6.1689209773459;
        Wed, 12 Jul 2023 17:56:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1689209773; cv=none;
        d=google.com; s=arc-20160816;
        b=yjXnDuLl60nifppWR31dvjST5tB7b0/0jQkrLfiK9A+gBOhHz2DSDb/PZ311O1Zjfu
         vo86+6THDbu3QSrkwmpQsrM+YNs5qyrSKCg66FCx9O/tLfstqYRhVFjn5q2rA7IGg8Yd
         zknife6vZ1izzv+VQDjxO7jpIfVyxjJoyS1NDEtfDaQTCU83NAGVyhydmU6OI8licWYO
         LSOcMD8FSKtz4BO5sVNlrv7MpdyYkk04OcITNZyYCq0nrv5t0sn71zfaAxUrsTjwpXgU
         RaWGRV7ViOr3z5zw31HwoXxB16ldK3EJ5v9ZwB7X7PSwJbxyQAnOnzB4N9DBM3Y52SzD
         srWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=1N6cc0hlKJLdeJuPEei/oBEsdDeQT/RH1OA0EEMjv+o=;
        fh=FZEwbGjmaZaHh5jEsyZgJN7dWVa2XX1xopXuy9DrJYI=;
        b=C6hMKhTYmLBYjrF2BylXTfNMRDoBMCtBLvATgcuu2N5LGhUQ0NsEacWjjIlS9mM5pj
         BdvVP7vWirfOBi2rMlYKvA0lS6/I8N7uO9SHzyGXs87gGGOQXxr/m7szeldgc0rrQkJs
         qxxl+pgxT5CfDBbFDu4Duufa36OAcn9+Abfgwqfe9tEZpkWCp1YUvsJwisCeUdRJgLyy
         hdn4D73PMsSaxs9m6ZWlX/7SUSwiKHCcv5PNVseR2rQFWrVLWZdqh0hVNi+ouyR56X3O
         FRGIJ1LmZzNlJqrhX3ylbY5cLq0IoYlFRjjUB6PhD4rM2qE3EDqrqu8kCF1oIL37+FJW
         8IzA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b="X/8mgt68";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id o1-20020a1709061b0100b00987d66e6d26si6163099ejg.250.2023.07.12.17.55.49;
        Wed, 12 Jul 2023 17:56:13 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b="X/8mgt68";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233437AbjGMAyL (ORCPT <rfc822;allen.lkml@gmail.com> + 99 others);
        Wed, 12 Jul 2023 20:54:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47994 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233305AbjGMAyF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 12 Jul 2023 20:54:05 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA0582115;
        Wed, 12 Jul 2023 17:53:56 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (2048 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id A360A619EB;
        Thu, 13 Jul 2023 00:53:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C39E9C433C7;
        Thu, 13 Jul 2023 00:53:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1689209635;
        bh=NVtdLL8+xBR7hSGyKtnjjHvGDMITqkluq9Z4RcbYLcY=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=X/8mgt68l7feMz0hsXgsMTNUkn0ONkHeP5UBKgp99f/bxTz8LMoGZFmyn4A1/AkKP
         cattpVEPet5zNiBKZ2BzIqpL2E43KBGfSEd9HR8EyEKlvyeKyseTaMyihI1k5F5fbZ
         K/CHYNUswo+EFn0/n/t54vsjh3+6mSvQ7adfTb9Ujai/N9a2n0mmOYdH8yCI5FZjia
         WDSOl+5nAa2Yk/FI2pUcTGSHpEmYlPyINWd3TyJcGRy10S9NeCC7GcXk9MxljrCiK+
         5tHUjG09w/vomiNcCqGKZm0qZZZ96xkLKuCUuNVuOYRecgJ7gsin6LoyWxTZHQyGaZ
         TJDJEvizn1ieQ==
Date:   Wed, 12 Jul 2023 17:53:53 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Zhang Shurong <zhang_shurong@foxmail.com>
Cc:     pkshih@realtek.com, kvalo@kernel.org,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] wifi: rtw89: debug: fix error code in
 rtw89_debug_priv_send_h2c_set()
Message-ID: <20230712175353.01ca65c5@kernel.org>
In-Reply-To: <tencent_AD09A61BC4DA92AD1EB0790F5C850E544D07@qq.com>
References: <tencent_AD09A61BC4DA92AD1EB0790F5C850E544D07@qq.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu,  6 Jul 2023 10:45:00 +0800 Zhang Shurong wrote:
> If there is a failure during rtw89_fw_h2c_raw() rtw89_debug_priv_send_h2c
> should return negative error code instead of a positive value count.
> Fix this bug by returning correct error code.
> 
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>

Applied, thanks!