Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <c64f5cb7-4750-512d-f105-dff6ec03de12@amd.com>
Date:   Wed, 12 Jul 2023 17:51:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RESEND PATCH V2 QDMA 1/1] dmaengine: amd: qdma: Add AMD QDMA
 driver
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>, <vkoul@kernel.org>,
        <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Nishad Saraf <nishads@amd.com>, <max.zhen@amd.com>,
        <sonal.santan@amd.com>
References: <1689179104-58089-1-git-send-email-lizhi.hou@amd.com>
 <1689179104-58089-2-git-send-email-lizhi.hou@amd.com>
 <5955d0ec-cd3a-5ad3-2c28-4ae819d1366d@infradead.org>
From:   Lizhi Hou <lizhi.hou@amd.com>
In-Reply-To: <5955d0ec-cd3a-5ad3-2c28-4ae819d1366d@infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 00:51:44.0936
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 02efce64-82b8-45a8-a0c6-08db833b5427
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT116.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7198
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/12/23 14:19, Randy Dunlap wrote:
> Hi--
>
> On 7/12/23 09:25, Lizhi Hou wrote:
>> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
>> index 644c188d6a11..89b26e68988a 100644
>> --- a/drivers/dma/Kconfig
>> +++ b/drivers/dma/Kconfig
>> @@ -85,6 +85,19 @@ config AMCC_PPC440SPE_ADMA
>>   	help
>>   	  Enable support for the AMCC PPC440SPe RAID engines.
>>   
>> +config AMD_QDMA
>> +	tristate "AMD Queue-based DMA"
>> +	depends on HAS_IOMEM
>> +	select DMA_ENGINE
>> +	select DMA_VIRTUAL_CHANNELS
>> +	select REGMAP_MMIO
>> +	help
>> +	  Enable support for the AMD Queue-based DMA subsystem.The primary
> Need a space...                                  DMA subsystem. The primary

Oh, ok. I will fix it.


Thanks,

Lizhi

>
>> +	  mechanism to transfer data using the QDMA is for the QDMA engine to
>> +	  operate on instructions (descriptors) provided by the host operating
>> +	  system. Using the descriptors, the QDMA can move data in both the Host
>> +	  to Card (H2C) direction, or the Card to Host (C2H) direction.