Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2b7bf9b6-c676-c1fb-28c9-b46c7d99459a@kernel.org>
Date:   Wed, 12 Jul 2023 17:58:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 08/10] serial: arc_uart: simplify flags handling in
 arc_serial_rx_chars()
Content-Language: en-US
To:     "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
        gregkh@linuxfoundation.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Vineet Gupta <vgupta@kernel.org>
References: <20230712081811.29004-1-jirislaby@kernel.org>
 <20230712081811.29004-9-jirislaby@kernel.org>
From:   Vineet Gupta <vgupta@kernel.org>
In-Reply-To: <20230712081811.29004-9-jirislaby@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/12/23 01:18, Jiri Slaby (SUSE) wrote:
> * move the declaration of flg (with the initializer) to the loop, so
>    there is no need to reset it to TTY_NORMAL by an 'else' branch.
> * use TTY_NORMAL as initializer above, not a magic zero constant
> * remove the outer 'if' from this construct:
>    if (S & (A | B)) {
>      if (S & A)
>        X;
>      if (S & B)
>        Y;
>    }
> * drop unlikely() as I doubt it has any benefits here. If it does,
>    provide numbers.
>
> All four make the code easier to read.
>
> Signed-off-by: Jiri Slaby (SUSE)<jirislaby@kernel.org>
> Cc: Vineet Gupta<vgupta@kernel.org>

Thanks for the cleanup.

Acked-by: Vineet Gupta <vgupta@kernel.org>

Th,
-Vineet