Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230614062234.24149-1-luojianhong@cdjrlc.com> <329a5b1b6e2c9061467ed6ef82247b8d@208suo.com>
In-Reply-To: <329a5b1b6e2c9061467ed6ef82247b8d@208suo.com>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 12 Jul 2023 18:20:12 -0700
Message-ID: <CAP-5=fW_tgXjWpevy+y4gY5XxpYq27zHahPZ8fv5L3+LdjaFnQ@mail.gmail.com>
Subject: Re: [PATCH] perf tools:remove unneeded variable from perf_event_attr__fprintf()
To:     baomingtong001@208suo.com
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com,
        anshuman.khandual@arm.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 13, 2023 at 11:25=E2=80=AFPM <baomingtong001@208suo.com> wrote:
>
> fix the following coccicheck warning:
>
> tools/perf/util/perf_event_attr_fprintf.c:97:5-8: Unneeded variable:
> "ret". Return "0".
>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>   tools/perf/util/perf_event_attr_fprintf.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/perf_event_attr_fprintf.c
> b/tools/perf/util/perf_event_attr_fprintf.c
> index 7e5e7b30510d..4a8f625b80c7 100644
> --- a/tools/perf/util/perf_event_attr_fprintf.c
> +++ b/tools/perf/util/perf_event_attr_fprintf.c
> @@ -94,7 +94,6 @@ int perf_event_attr__fprintf(FILE *fp, struct
> perf_event_attr *attr,
>                    attr__fprintf_f attr__fprintf, void *priv)
>   {
>       char buf[BUF_SIZE];
> -    int ret =3D 0;
>
>       PRINT_ATTRf(type, p_unsigned);
>       PRINT_ATTRf(size, p_unsigned);
> @@ -155,5 +154,5 @@ int perf_event_attr__fprintf(FILE *fp, struct
> perf_event_attr *attr,
>       PRINT_ATTRf(aux_sample_size, p_unsigned);
>       PRINT_ATTRf(sig_data, p_unsigned);
>
> -    return ret;
> +    return 0;
>   }