Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <31f9d78d-aec0-8e34-f499-ada44578657a@nvidia.com>
Date:   Thu, 13 Jul 2023 10:22:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH net-next V1 0/4] virtio_net: add per queue interrupt
 coalescing support
Content-Language: en-US
To:     Heng Qi <hengqi@linux.alibaba.com>
Cc:     virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org, mst@redhat.com,
        jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
        hawk@kernel.org, john.fastabend@gmail.com, jiri@nvidia.com,
        dtatulea@nvidia.com
References: <20230710092005.5062-1-gavinl@nvidia.com>
 <e77232b9-a290-545b-cb02-ae1fbc2cd5cb@linux.alibaba.com>
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <e77232b9-a290-545b-cb02-ae1fbc2cd5cb@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2d4VjRsUXVQeHd5NDVUVWRrbUdvL3hGbnc1cW9RLzVBNTl6Z3NkRlRRWHFr?=
 =?utf-8?B?cTJqeEgxUWt5Q29VRkMvdzNGRXIyZXB5RHNzTEtjS0s5VlBJYk1xY3pWU3hz?=
 =?utf-8?B?WFVNeU1GenlnYVkrb0s5QW8rN0xJdm9jWTBXK2FjNFBwcElJL0JXRWhjS2w2?=
 =?utf-8?B?cHB6QzFpSTJDOWpsd3RuMnY1b0VCclRaZmNMbEVFUXN3TW1UeWMxdkgxdmtM?=
 =?utf-8?B?YWEwWGtqbEZCSS9NbFZUNS9Gdy9xMmVEdmNFZEtUN1ZMWlhOUXkyNHluY01Q?=
 =?utf-8?B?aXFwM25sZHJmZUFCQXJCTWxXU0RUbFU4TWhZNThzT0hORnBOemR2YTlVdmlX?=
 =?utf-8?B?RGVzQ29FSXlXYzdMenZiWDBJT0FBVDBUdlduaHRqZXVXdU5oVDVYL2JVTEpz?=
 =?utf-8?B?Rit5UXF5N3RNbHFtdUNqQlR0REpQOWpLSlZZbGRqSnFPTXZUTXJ0d0VDbG9X?=
 =?utf-8?B?U2VRVDQ1T2p6UEQvU3FKNnEzTUUvM2c2SHVDNXRvZWdIMGxIUy93ZDlqZDVG?=
 =?utf-8?B?NmdOcjcxaWgrMnkxc1dKTW02M0lwL3pjNEJwYy8xdldFb3c0NCtnaWsyLzNG?=
 =?utf-8?B?bFZ6UHdNSHhQcDZZL3ZtcVhLTWRzVzNVV291eEcrZFNacDY1YVhDcm1jd1I4?=
 =?utf-8?B?WmNEOWpOdndGQnRJcEo0U1lWTjRLelA5TFNnVTdXN0ZqRGI1UGM5OURldWhI?=
 =?utf-8?B?UnhaQUZERHNXQmVnNGUrNThhQ1J1bUhoWm9ZN1VCM1IxY0lld0RpV1hyb3ZI?=
 =?utf-8?B?ZHZVamNrREtrRHNRT0ZtQStnLzhBSFhNcC9TekpiN3ZPd3c2TVdJZ00rR2lx?=
 =?utf-8?B?WEpvUVRrYzJZRzllV0wwbjgzV1BNOVNPYmFUK0RRUlJMQjZ0eHF6R0xkZ28v?=
 =?utf-8?B?S3RhK3JjZkdDTjNsRnJQUmJIMFJIcVNMWXQ4M0VjNGh5YXhNcmhpbHZ0STIv?=
 =?utf-8?B?SDRuc1UyZ1RQMW96OHdYWUpHT2tHRWxBRWRORUhKZ255WXVmNnVPUTVhMStD?=
 =?utf-8?B?OWk0K0lPSHd0b3l1bWpETlp5MWcwR1lWaDNvN2ZpdE1kc3NlVzVPMjZzMnZl?=
 =?utf-8?B?dThGUjNvNmNwaFhOaGpzYmUrZFJGOGVTMmQzTmZTbGo3clMwemYyM2xJUUNi?=
 =?utf-8?B?R2kvRUxvWlhSd0ttM3BmRENGeUVEVGRJUzB0bm5ycW96WUljRGg1TU5kWmxY?=
 =?utf-8?B?NnlDZkhGUXQzaEgvQWpyaEJLNFYxdm5lNFl2STMvMWRLM056dWVEUjRIdkxR?=
 =?utf-8?B?N0ZBbVNJbU1KVDU0Nm1HSlpxRVZDdlRxc2RVa2tMYUc5WW9WZmE5dmgzcmZp?=
 =?utf-8?B?L0tiWDdqOGoxeXFwcFVEWnhncjFuK1hoY2lxYk5CZUZvK1RRakRKV242aEdr?=
 =?utf-8?B?ZjNuOE1VOWZKVFoyamRLSnVRZktsZlc4RS8zdWpDR2ZDSkpwMTVVbE0rMHdL?=
 =?utf-8?B?ZzRkalFVdXdMY2lOYzUzaCtJazY5cVdubXVoaWZuL1JkbzB2VDFXdFFoRHJs?=
 =?utf-8?B?Wk9zWEIvbEt0OGFRRnJCZEI0MnAzeVlacVVaNW9JeVRoN245YVllQ253NkZ2?=
 =?utf-8?B?T3lXdGZaWGNTYnNvanQvenBtMlR5Qk93R0k4VGU4NUptRVByeGpCS3hKOWV2?=
 =?utf-8?B?RzJiSkJBVTZEa1BMUGZBMU40QzVhVjhOZHpMZUh6RzZmby9JZUdXbDhobnln?=
 =?utf-8?B?MTQ3SFZkbjBBY1Z2WWJTaHlZcXhOYk9VNFlTWFJKVnpmV0dpbDFaUmJDNmZ5?=
 =?utf-8?B?MnRtbm9xRU9ZVTlRWFFnZG1lalZ3NTYwRzdyNUdKYVNTemRoOXNFY1BRNWc4?=
 =?utf-8?B?Slh4OE5tMTBIY0hwWG1uVXEweFpqaXpzeUhDMXVXL29kdG5rcEFoZnlIL3Bi?=
 =?utf-8?B?S2VOeXZSYlc4QkgrUXdESUVNTUFaeFMwaEFpcWdHdGMvT1MwUDBOTGVLelNK?=
 =?utf-8?B?STREcEl0RlI4MTkzcTBvNjdaOHlmMVpTYmFxTXlxSzEyWjY3SHhORDZod080?=
 =?utf-8?B?WkhyeUloaDAwZEk0N0QvMUh1VUxXZTVnZTA5RE05dTl6VmdVRVJzYXdrVGIw?=
 =?utf-8?B?a2oraGxlRXEzc3NxUEhZQnRZUkJoaFdpK296WHZhZW5yUG50RTRVTjMzdWcr?=
 =?utf-8?Q?MdDg84DW1EOSdS+IXsVZomkyX?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0306b83-91e5-47b8-58c8-08db834818a8
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6019.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 02:23:08.1046
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mCJakgMK/vro8jEXaWyz5ss1dXtxenJupvNvaBkGlDt/BdVanzkWrm1YSJ/APTI/AnISTq9svwCthHps86FnrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6796
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/12/2023 4:34 PM, Heng Qi wrote:
> 
> 
> 在 2023/7/10 下午5:20, Gavin Li 写道:
>> Currently, coalescing parameters are grouped for all transmit and receive
>> virtqueues. This patch series add support to set or get the parameters 
>> for
>> a specified virtqueue.
>>
>> When the traffic between virtqueues is unbalanced, for example, one 
>> virtqueue
>> is busy and another virtqueue is idle, then it will be very useful to
>> control coalescing parameters at the virtqueue granularity.
> 
> 
> We definitely did the same thing, and I'm waiting for our hardware 
> implementation to be ready to
> push the ethtool + netdim implementation.
> 
> Since this commit log is completely copied from the implementation of 
> the virtio spec, consulting
> each other's scheduling plan in advance can be friendly to avoid us 
> doing the same thing and consuming an extra effort.
> 
> Thanks.
> 
I didn't know about the effort you made and the progress of it.
Since the code has been done and tested, I'll continue submission.
>>
>> Example command:
>> $ ethtool -Q eth5 queue_mask 0x1 --coalesce tx-packets 10
>> Would set max_packets=10 to VQ 1.
>> $ ethtool -Q eth5 queue_mask 0x1 --coalesce rx-packets 10
>> Would set max_packets=10 to VQ 0.
>> $ ethtool -Q eth5 queue_mask 0x1 --show-coalesce
>>   Queue: 0
>>   Adaptive RX: off  TX: off
>>   stats-block-usecs: 0
>>   sample-interval: 0
>>   pkt-rate-low: 0
>>   pkt-rate-high: 0
>>
>>   rx-usecs: 222
>>   rx-frames: 0
>>   rx-usecs-irq: 0
>>   rx-frames-irq: 256
>>
>>   tx-usecs: 222
>>   tx-frames: 0
>>   tx-usecs-irq: 0
>>   tx-frames-irq: 256
>>
>>   rx-usecs-low: 0
>>   rx-frame-low: 0
>>   tx-usecs-low: 0
>>   tx-frame-low: 0
>>
>>   rx-usecs-high: 0
>>   rx-frame-high: 0
>>   tx-usecs-high: 0
>>   tx-frame-high: 0
>>
>> In this patch series:
>> Patch-1: Extract interrupt coalescing settings to a structure.
>> Patch-2: Extract get/set interrupt coalesce to a function.
>> Patch-3: Support per queue interrupt coalesce command.
>> Patch-4: Enable per queue interrupt coalesce feature.
>>
>> Gavin Li (4):
>>    virtio_net: extract interrupt coalescing settings to a structure
>>    virtio_net: extract get/set interrupt coalesce to a function
>>    virtio_net: support per queue interrupt coalesce command
>>    virtio_net: enable per queue interrupt coalesce feature
>>
>>   drivers/net/virtio_net.c        | 169 ++++++++++++++++++++++++++------
>>   include/uapi/linux/virtio_net.h |  14 +++
>>   2 files changed, 154 insertions(+), 29 deletions(-)
>>
>