Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759751AbXJXR3G (ORCPT ); Wed, 24 Oct 2007 13:29:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753762AbXJXR24 (ORCPT ); Wed, 24 Oct 2007 13:28:56 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:40862 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752437AbXJXR2z (ORCPT ); Wed, 24 Oct 2007 13:28:55 -0400 Date: Wed, 24 Oct 2007 18:17:52 +0100 From: Russell King To: Arjan van de Ven Cc: Adrian Bunk , davej@codemonkey.org.uk, Thomas Gleixner , linux-kernel@vger.kernel.org, cpufreq@lists.linux.org.uk Subject: Re: [2.6 patch] #if 0 cpufreq.c:cpufreq_get() Message-ID: <20071024171751.GG32333@flint.arm.linux.org.uk> References: <20071024162312.GH30533@stusta.de> <20071024093839.232e5cd5@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071024093839.232e5cd5@laptopd505.fenrus.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 27 On Wed, Oct 24, 2007 at 09:38:39AM -0700, Arjan van de Ven wrote: > On Wed, 24 Oct 2007 18:23:12 +0200 > Adrian Bunk wrote: > > > cpufreq.c:cpufreq_get() no longer has any user. > > > > it's... also a really bad/buggy interface... frquency is a per cpu > property for one, and constantly changing (esp in a multi-core world) > even depending on what other parts of the system are doing. ... and such an assumption which would make it impossible to use the LCD controller on StrongARM-11x0 processors. This is precisely why we have CPUFREQ - so that hardware which needs to be re-timed when the CPU frequency changes can get notified of that event and take the appropriate action. It exists. It works. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/