Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Thierry Reding <thierry.reding@gmail.com>,
        Krishna Reddy <vdumpa@nvidia.com>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-tegra@vger.kernel.org (open list:TEGRA IOMMU DRIVERS),
        iommu@lists.linux.dev (open list:IOMMU SUBSYSTEM),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init()
Date:   Thu, 13 Jul 2023 10:56:53 +0800
Message-Id: <20230713025653.1540-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Kb2P06fFPnw5SFBIaUt3Qt47HyhGA6OypMdopoJU/cXJJWuAv6O9W/hv1wf4?=
 =?us-ascii?Q?3UI1zuAGn8K7LQm6bOFMINcTVheGbgqGY9rjZzpmv0F/c3Wmi+KoWfyIVVyR?=
 =?us-ascii?Q?EIxfD6KFqnvBXoMOl4xlD7m1yYr+OrLpbbsuB/qFEs3e8IzJr6HS1u1lxdxo?=
 =?us-ascii?Q?u092MEoEp9VSyJvhHdqSPTQRHYPrhzA7lhHGuU49BQ57ytZAE6AgdY/iyDq0?=
 =?us-ascii?Q?MhRujVHWkrbFLc3PkCz46kFMg+p1p9b67+YmCElq4Mwqada1JveG+SMHcBb0?=
 =?us-ascii?Q?Aal0V9GNwWlOmlav4vpZClmoG838rGrATx7qBYHQI+50IETj5fBQW6IuPwwc?=
 =?us-ascii?Q?gjCr1posGx5hhN1KRaoBlRLn4n9ZheydhjPVjvI3hNVR1lPWTJJK5wRM5V3f?=
 =?us-ascii?Q?qssr9GYVe0tsW9MRsdm/PWN0vjvjrv2ERMQznnqWlJyMeKIqivSZXFIcK9lO?=
 =?us-ascii?Q?Z71QAxnoVdGyu1AReZU0CPNA4+KKbcw6l1J7yqAoRmxTFJymebGz40BvHWiP?=
 =?us-ascii?Q?tjOOOsYdNJp+o81Pqn3/9qwgvKtFiNIEfctWGsuk4DQEGg40XoqdYOib1RdN?=
 =?us-ascii?Q?zrthj792XSbPtycZ0b/DJG9fT95sxgoabikpWLuWsHgZeeQb0qNuvWe1YLan?=
 =?us-ascii?Q?I6c2VK+Ck0ct0p9+B2859vd3FctA2ZakXX3svj5Oetlfu73Xvka3Qks/dH5l?=
 =?us-ascii?Q?povXXya5opAIeZLV+nlv7KHLfLtxhac1rqbzbWhjimsZiAEPfuUPKc4q3eee?=
 =?us-ascii?Q?9yN3GQwJ+vJts4wa+uwposp0GHFE9Rh7wHgFKPUr9iwGOHd+6tTbwLbPDhzG?=
 =?us-ascii?Q?DLPLUQX3MlfFCMZu8eXN3A8BDZtL0/bI0hiQFDDhfH+vDX8KAeF6EnPL2+tU?=
 =?us-ascii?Q?brMFL1IjXodGHwm6upSRxPE2gKNvVzkN+ATrrs4sF3olc1Mdpv9d8mmwdGIx?=
 =?us-ascii?Q?OaghtaAu47iHol7w3JyDuVD13sqdzObm4aeHggw+2o1TVQCEIyB1k5B/EAlp?=
 =?us-ascii?Q?UWmurRoG18r9ezEFV5uKY5+FJZ6lnhtGcM8fz3/Mk/6GzVQgFpYM/BMA68yY?=
 =?us-ascii?Q?wAmVqkB7jm2mip23q61DV4R+0qhx6Jh4xD9GRvQ9n6v4Z3fb2tVDfNMu+6kn?=
 =?us-ascii?Q?dxsldJzi2Qlm5EyiePT1BVuVgo+QuFMTRX6BZGZwqVtGeaB818yjsTMtcEYE?=
 =?us-ascii?Q?xG8IAQTWE/Qj3qBDWJ+UXNqDubO12dyGWuzyvQZzKVMrsZzOi3C8g1/1rhfw?=
 =?us-ascii?Q?k0to4VGwXcu9bOCjv6badpicnuJxIF9u7pHdCinmmlH6LuzKrBdzZFpp01F+?=
 =?us-ascii?Q?RwCjtbCKSFpj3/m0YHFYgB349rMUr/dhxhZPdjUcsgM3Iyo8jbrJxehnHEwe?=
 =?us-ascii?Q?5IK1oU4yqzJNnfeGIzhs0Q+q310ksIigmesjYhpOrLb7oQEXNHAPcidQbW/v?=
 =?us-ascii?Q?NFKkPvYylys7cUyX8Of0GqZbz5MDVymYj1D9EsydMFTZjYEXkwXapKAg1yxB?=
 =?us-ascii?Q?ZEZtE+Lak8EmYQLLL7HYtW4lWFSyGUZ9SShimtFP4XTuYNZHzX2TBbFWRvgP?=
 =?us-ascii?Q?AhsnN+ffhsNK9EFRc1XEsP9v7HApqFN9V09rrHgL?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69349346-66b0-494f-e595-08db834cd5fe
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 02:57:03.7712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YrNVyikbuCPbCL6WtKyQvPIZ3Fvo85NEXT6luulXot7+e/loIZi9kYNWJMbYLWTBCKPF+Hy8HRAF46cadGg4Fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5519
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

debugfs_create_file() will simply return early if
 smmu->debugfs is an error pointer.
Make smmu->debugfs check delete in tegra_smmu_debugfs_init().

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/iommu/tegra-smmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index 1cbf063cc..2137040b7 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -1056,8 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients);
 static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
 {
 	smmu->debugfs = debugfs_create_dir("smmu", NULL);
-	if (!smmu->debugfs)
-		return;
 
 	debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
 			    &tegra_smmu_swgroups_fops);
-- 
2.39.0